Skip to content

Prettier printing for gradient operators #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 7, 2024
Merged

Prettier printing for gradient operators #111

merged 4 commits into from
Dec 7, 2024

Conversation

@MilesCranmer
Copy link
Member

@MilesCranmer MilesCranmer commented Dec 7, 2024

This is in support of MilesCranmer/SymbolicRegression.jl#377, so that D(f, 1) will look nice when printed.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2024 •
edited
Loading

Benchmark Results

master e27214a... master/e27214a2b86e7c...
eval/ComplexF32/evaluation 7.22 ± 0.53 ms 7.27 ± 0.51 ms 0.993
eval/ComplexF64/evaluation 10.7 ± 0.79 ms 10.7 ± 0.95 ms 0.996
eval/Float32/derivative 11.8 ± 1.4 ms 11.8 ± 1.4 ms 0.999
eval/Float32/derivative_turbo 12 ± 1.5 ms 11.8 ± 1.4 ms 1.01
eval/Float32/evaluation 2.76 ± 0.25 ms 2.71 ± 0.25 ms 1.02
eval/Float32/evaluation_bumper 0.579 ± 0.014 ms 0.577 ± 0.014 ms 1
eval/Float32/evaluation_turbo 0.582 ± 0.03 ms 0.576 ± 0.029 ms 1.01
eval/Float32/evaluation_turbo_bumper 0.581 ± 0.014 ms 0.578 ± 0.014 ms 1.01
eval/Float64/derivative 15.5 ± 0.71 ms 15.4 ± 0.83 ms 1.01
eval/Float64/derivative_turbo 15.1 ± 0.86 ms 15.1 ± 0.77 ms 1
eval/Float64/evaluation 3.19 ± 0.3 ms 3.18 ± 0.31 ms 1
eval/Float64/evaluation_bumper 1.19 ± 0.042 ms 1.19 ± 0.042 ms 1.01
eval/Float64/evaluation_turbo 1.08 ± 0.063 ms 1.05 ± 0.062 ms 1.03
eval/Float64/evaluation_turbo_bumper 1.19 ± 0.041 ms 1.18 ± 0.044 ms 1.01
utils/combine_operators/break_sharing 0.0386 ± 0.00084 ms 0.0382 ± 0.00063 ms 1.01
utils/convert/break_sharing 27.2 ± 2 μs 27.7 ± 2.3 μs 0.984
utils/convert/preserve_sharing 0.099 ± 0.0036 ms 0.0995 ± 0.0045 ms 0.994
utils/copy/break_sharing 27.9 ± 2.1 μs 28.2 ± 2 μs 0.989
utils/copy/preserve_sharing 0.0985 ± 0.0032 ms 0.0985 ± 0.004 ms 1
utils/count_constant_nodes/break_sharing 8.91 ± 0.23 μs 9.14 ± 0.21 μs 0.975
utils/count_constant_nodes/preserve_sharing 0.0845 ± 0.0026 ms 0.0863 ± 0.0037 ms 0.979
utils/count_depth/break_sharing 9.63 ± 0.24 μs 9.64 ± 0.26 μs 0.999
utils/count_nodes/break_sharing 8.41 ± 0.19 μs 8.38 ± 0.22 μs 1
utils/count_nodes/preserve_sharing 0.084 ± 0.0027 ms 0.0842 ± 0.0028 ms 0.997
utils/get_set_constants!/break_sharing 0.0341 ± 0.0021 ms 0.0339 ± 0.0026 ms 1
utils/get_set_constants!/preserve_sharing 0.174 ± 0.005 ms 0.175 ± 0.0051 ms 0.998
utils/get_set_constants_parametric 0.0447 ± 0.0028 ms 0.0445 ± 0.0022 ms 1
utils/has_constants/break_sharing 4.13 ± 0.15 μs 4.07 ± 0.14 μs 1.02
utils/has_operators/break_sharing 2.07 ± 0.095 μs 2 ± 0.097 μs 1.04
utils/hash/break_sharing 22.8 ± 0.47 μs 22.6 ± 0.64 μs 1.01
utils/hash/preserve_sharing 0.097 ± 0.0029 ms 0.0971 ± 0.003 ms 0.999
utils/index_constant_nodes/break_sharing 25.2 ± 0.9 μs 25.6 ± 1.2 μs 0.984
utils/index_constant_nodes/preserve_sharing 0.0974 ± 0.0029 ms 0.0984 ± 0.004 ms 0.989
utils/is_constant/break_sharing 4.46 ± 0.16 μs 4.4 ± 0.17 μs 1.01
utils/simplify_tree/break_sharing 0.166 ± 0.0028 ms 0.168 ± 0.003 ms 0.987
utils/simplify_tree/preserve_sharing 0.214 ± 0.0041 ms 0.22 ± 0.0057 ms 0.972
utils/string_tree/break_sharing 0.46 ± 0.016 ms 0.458 ± 0.016 ms 1
utils/string_tree/preserve_sharing 0.569 ± 0.02 ms 0.567 ± 0.021 ms 1
time_to_load 0.231 ± 0.001 s 0.233 ± 0.0037 s 0.993

@coveralls
Copy link

coveralls commented Dec 7, 2024

Pull Request Test Coverage Report for Build 12215381038

Details

  • 27 of 27 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 95.357%
Totals Coverage Status
Change from base Build 12141849831: 0.04%
Covered Lines: 2444
Relevant Lines: 2563
💛 - Coveralls

@MilesCranmer MilesCranmer merged commit 7e0a1b4 into master Dec 7, 2024
14 checks passed
@MilesCranmer MilesCranmer deleted the clean-up-zygote-gradients branch December 7, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MilesCranmer @coveralls