Skip to content

Commit 36f261d

Browse files
authored
feature #298 replace final annotation with final class keyword
1 parent 3ba8851 commit 36f261d

File tree

6 files changed

+18
-69
lines changed

6 files changed

+18
-69
lines changed

CHANGELOG.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,14 @@
33
*We intend to follow [Semantic Versioning 2.0.0](https://semver.org/), if you
44
find a change that break's semver, please create an issue.*
55

6+
## [v2.0.0](https://github.com/symfonycasts/reset-password-bundle/releases/tag/v2.0.0)
7+
8+
*January 99th, 2099*
9+
10+
### Feature
11+
12+
- [#298](https://github.com/symfonycasts/reset-password-bundle/pull/298) - replace final annotation with final class keyword - *@jrushlow*
13+
614
## [v1.18.0](https://github.com/symfonycasts/reset-password-bundle/releases/tag/v1.18.0)
715

816
*September 19th, 2023*

UPGRADING.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,10 @@ ResetPasswordBundle now requires PHP `8.3`+ & Symfony `6.4.5`+
44

55
## ResetPasswordHelper
66

7-
- Class became `@final` in `v1.22.0`. Extending this class will not be allowed
8-
in version `v2.0.0`.
7+
- Class became `@final` in `v1.22.0` and in `v2.0.0` the `@final` annotation was
8+
replaced with the `final` class keyword. Extending this class is not allowed.
99

1010
## ResetPasswordRemoveExpiredCommand
1111

12-
- Class became `@final` in `v1.22.0`. Extending this class will not be allowed
13-
in version `v2.0.0`.
12+
- Class became `@final` in `v1.22.0` and in `v2.0.0` the `@final` annotation was
13+
replaced with the `final` class keyword. Extending this class is not allowed.

src/Command/ResetPasswordRemoveExpiredCommand.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,8 @@
1717
/**
1818
* @author Jesse Rushlow <[email protected]>
1919
* @author Ryan Weaver <[email protected]>
20-
*
21-
* @final
2220
*/
23-
class ResetPasswordRemoveExpiredCommand extends Command
21+
final class ResetPasswordRemoveExpiredCommand extends Command
2422
{
2523
private $cleaner;
2624

src/ResetPasswordHelper.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,8 @@
2121
/**
2222
* @author Jesse Rushlow <[email protected]>
2323
* @author Ryan Weaver <[email protected]>
24-
*
25-
* @final
2624
*/
27-
class ResetPasswordHelper implements ResetPasswordHelperInterface
25+
final class ResetPasswordHelper implements ResetPasswordHelperInterface
2826
{
2927
/**
3028
* The first 20 characters of the token are a "selector".

tests/Functional/Command/ResetPasswordRemoveExpiredCommandTest.php

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* file that was distributed with this source code.
88
*/
99

10-
namespace SymfonyCasts\Bundle\ResetPassword\Tests\FunctionalTests\Command;
10+
namespace SymfonyCasts\Bundle\ResetPassword\Tests\Functional\Command;
1111

1212
use Doctrine\Bundle\DoctrineBundle\Registry;
1313
use Doctrine\ORM\Tools\SchemaTool;
@@ -27,15 +27,9 @@
2727
*/
2828
final class ResetPasswordRemoveExpiredCommandTest extends TestCase
2929
{
30-
/**
31-
* @var ObjectManager|object
32-
*/
33-
private $manager;
34-
35-
/**
36-
* @var CommandTester
37-
*/
38-
private $commandTester;
30+
private ObjectManager $manager;
31+
32+
private CommandTester $commandTester;
3933

4034
protected function setUp(): void
4135
{

tests/Unit/Command/ResetPasswordRemoveExpiredCommandTest.php

Lines changed: 0 additions & 49 deletions
This file was deleted.

0 commit comments

Comments
 (0)