Merge pull request #79 from jrushlow/fix/fake-repo-ns

fixed incorrect fake repo namespace

Author: weaverryan

src/Resources/config/reset_password_services.xml

@@ -5,7 +5,7 @@
     xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd">
 
     <services>
-        <service id="symfonycasts.reset_password.fake_request_repository" class="SymfonyCasts\Bundle\ResetPassword\Persistence\FakeInternalRepository" public="false"/>
+        <service id="symfonycasts.reset_password.fake_request_repository" class="SymfonyCasts\Bundle\ResetPassword\Persistence\Fake\FakeResetPasswordInternalRepository" public="false"/>
         <service id="symfonycasts.reset_password.cleaner" class="SymfonyCasts\Bundle\ResetPassword\Util\ResetPasswordCleaner" public="false">
             <argument /> <!-- reset password request persister -->
             <argument /> <!-- reset password request enable_garbage_collection -->

tests/IntegrationTests/ResetPasswordServiceDefinitionTest.php

@@ -0,0 +1,82 @@
+<?php
+
+/*
+ * This file is part of the SymfonyCasts ResetPasswordBundle package.
+ * Copyright (c) SymfonyCasts <https://symfonycasts.com/>
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace SymfonyCasts\Bundle\ResetPassword\Tests\IntegrationTests;
+
+use PHPUnit\Framework\TestCase;
+use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
+use Symfony\Component\DependencyInjection\ContainerBuilder;
+use SymfonyCasts\Bundle\ResetPassword\Tests\Fixtures\AbstractResetPasswordTestKernel;
+
+/**
+ * @author Jesse Rushlow <[email protected]>
+ * @author Ryan Weaver   <[email protected]>
+ */
+final class ResetPasswordServiceDefinitionTest extends TestCase
+{
+    public function bundleServiceDefinitionDataProvider(): \Generator
+    {
+        $prefix = 'symfonycasts.reset_password.';
+
+        yield [$prefix.'fake_request_repository'];
+        yield [$prefix.'cleaner'];
+        yield [$prefix.'random_generator'];
+        yield [$prefix.'token_generator'];
+        yield [$prefix.'helper'];
+        yield ['SymfonyCasts\Bundle\ResetPassword\Command\ResetPasswordRemoveExpiredCommand'];
+    }
+
+    /**
+     * @dataProvider bundleServiceDefinitionDataProvider
+     */
+    public function testBundleServiceDefinitions(string $definition): void
+    {
+        // Make private reset-password-bundle services public
+        $pass = new DefinitionPublicCompilerPass();
+        $pass->definition = $definition;
+
+        $kernel = new ResetPasswordDefinitionTestKernel();
+        $kernel->compilerPass = $pass;
+        $kernel->boot();
+
+        $container = $kernel->getContainer();
+        $container->get($definition);
+
+        // If a service is not correctly defined, i.e. wrong class namespace, an exception will be thrown.
+        $this->expectNotToPerformAssertions();
+    }
+}
+
+/**
+ * @internal
+ */
+final class DefinitionPublicCompilerPass implements CompilerPassInterface
+{
+    public $definition;
+
+    public function process(ContainerBuilder $container)
+    {
+        $container->getDefinition($this->definition)
+            ->setPublic(true)
+        ;
+    }
+}
+
+/**
+ * @internal
+ */
+final class ResetPasswordDefinitionTestKernel extends AbstractResetPasswordTestKernel
+{
+    public $compilerPass;
+
+    protected function build(ContainerBuilder $container)
+    {
+        $container->addCompilerPass($this->compilerPass);
+    }
+}