follow symfony coding standards

Author: jrushlow

.php-cs-fixer.dist.php

@@ -12,7 +12,6 @@
     ->setRules(array(
         '@Symfony' => true,
         '@Symfony:risky' => true,
-        'native_function_invocation' => ['include' => ['@internal'], 'scope' => 'namespaced', 'strict' => true],
         'header_comment' => [
             'header' => <<<EOF
 This file is part of the SymfonyCasts ResetPasswordBundle package.

src/Command/ResetPasswordRemoveExpiredCommand.php

@@ -50,7 +50,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
 
         $intRemoved = $this->cleaner->handleGarbageCollection(true);
 
-        $output->writeln(\sprintf('Garbage collection successful. Removed %s reset password request object(s).', $intRemoved));
+        $output->writeln(sprintf('Garbage collection successful. Removed %s reset password request object(s).', $intRemoved));
 
         return 0;
     }

src/Generator/ResetPasswordRandomGenerator.php

@@ -30,10 +30,10 @@ public function getRandomAlphaNumStr(): string
         while (($len = \strlen($string)) < 20) {
             $size = 20 - $len;
 
-            $bytes = \random_bytes($size);
+            $bytes = random_bytes($size);
 
-            $string .= \substr(
-                \str_replace(['/', '+', '='], '', \base64_encode($bytes)), 0, $size);
+            $string .= substr(
+                str_replace(['/', '+', '='], '', base64_encode($bytes)), 0, $size);
         }
 
         return $string;

src/Generator/ResetPasswordTokenGenerator.php

@@ -50,7 +50,7 @@ public function createToken(\DateTimeInterface $expiresAt, $userId, string $veri
 
         $selector = $this->randomGenerator->getRandomAlphaNumStr();
 
-        $encodedData = \json_encode([$verifier, $userId, $expiresAt->getTimestamp()]);
+        $encodedData = json_encode([$verifier, $userId, $expiresAt->getTimestamp()]);
 
         return new ResetPasswordTokenComponents(
             $selector,
@@ -61,6 +61,6 @@ public function createToken(\DateTimeInterface $expiresAt, $userId, string $veri
 
     private function getHashedToken(string $data): string
     {
-        return \base64_encode(\hash_hmac('sha256', $data, $this->signingKey, true));
+        return base64_encode(hash_hmac('sha256', $data, $this->signingKey, true));
     }
 }

src/Model/ResetPasswordRequestTrait.php

@@ -52,7 +52,7 @@ public function getRequestedAt(): \DateTimeInterface
 
     public function isExpired(): bool
     {
-        return $this->expiresAt->getTimestamp() <= \time();
+        return $this->expiresAt->getTimestamp() <= time();
     }
 
     public function getExpiresAt(): \DateTimeInterface

src/Model/ResetPasswordToken.php

@@ -135,7 +135,7 @@ public function getExpirationMessageData(): array
     public function getExpiresAtIntervalInstance(): \DateInterval
     {
         if (null === $this->generatedAt) {
-            throw new \LogicException(\sprintf('%s initialized without setting the $generatedAt timestamp.', self::class));
+            throw new \LogicException(sprintf('%s initialized without setting the $generatedAt timestamp.', self::class));
         }
 
         $createdAtTime = \DateTimeImmutable::createFromFormat('U', (string) $this->generatedAt);

src/ResetPasswordHelper.php

@@ -68,7 +68,7 @@ public function generateResetToken(object $user): ResetPasswordToken
             throw new TooManyPasswordRequestsException($availableAt);
         }
 
-        $expiresAt = new \DateTimeImmutable(\sprintf('+%d seconds', $this->resetRequestLifetime));
+        $expiresAt = new \DateTimeImmutable(sprintf('+%d seconds', $this->resetRequestLifetime));
 
         $generatedAt = ($expiresAt->getTimestamp() - $this->resetRequestLifetime);
 
@@ -120,10 +120,10 @@ public function validateTokenAndFetchUser(string $fullToken): object
         $hashedVerifierToken = $this->tokenGenerator->createToken(
             $resetRequest->getExpiresAt(),
             $this->repository->getUserIdentifier($user),
-            \substr($fullToken, self::SELECTOR_LENGTH)
+            substr($fullToken, self::SELECTOR_LENGTH)
         );
 
-        if (false === \hash_equals($resetRequest->getHashedToken(), $hashedVerifierToken->getHashedToken())) {
+        if (false === hash_equals($resetRequest->getHashedToken(), $hashedVerifierToken->getHashedToken())) {
             throw new InvalidResetPasswordTokenException();
         }
 
@@ -166,7 +166,7 @@ public function getTokenLifetime(): int
      */
     public function generateFakeResetToken(): ResetPasswordToken
     {
-        $expiresAt = new \DateTimeImmutable(\sprintf('+%d seconds', $this->resetRequestLifetime));
+        $expiresAt = new \DateTimeImmutable(sprintf('+%d seconds', $this->resetRequestLifetime));
 
         $generatedAt = ($expiresAt->getTimestamp() - $this->resetRequestLifetime);
 
@@ -175,7 +175,7 @@ public function generateFakeResetToken(): ResetPasswordToken
 
     private function findResetPasswordRequest(string $token): ?ResetPasswordRequestInterface
     {
-        $selector = \substr($token, 0, self::SELECTOR_LENGTH);
+        $selector = substr($token, 0, self::SELECTOR_LENGTH);
 
         return $this->repository->findResetPasswordRequest($selector);
     }

tests/Fixtures/Entity/ResetPasswordTestFixtureRequest.php

@@ -55,7 +55,7 @@ public function getRequestedAt(): \DateTimeInterface
 
     public function isExpired(): bool
     {
-        return $this->expiresAt->getTimestamp() <= \time();
+        return $this->expiresAt->getTimestamp() <= time();
     }
 
     public function getExpiresAt(): \DateTimeInterface

tests/ResetPasswordTestKernel.php

@@ -47,7 +47,7 @@ public function __construct(ContainerBuilder $builder = null, array $routes = []
 
     public function registerBundles(): iterable
     {
-        return \array_merge(
+        return array_merge(
             $this->extraBundles,
             [
                 new FrameworkBundle(),
@@ -133,11 +133,11 @@ public function loadRoutes(LoaderInterface $loader): RouteCollection
 
     public function getCacheDir()
     {
-        return \sys_get_temp_dir().'/cache'.\spl_object_hash($this);
+        return sys_get_temp_dir().'/cache'.spl_object_hash($this);
     }
 
     public function getLogDir()
     {
-        return \sys_get_temp_dir().'/logs'.\spl_object_hash($this);
+        return sys_get_temp_dir().'/logs'.spl_object_hash($this);
     }
 }

tests/UnitTests/Generator/ResetPasswordTokenGeneratorTest.php

@@ -64,17 +64,17 @@ public function testHashedTokenIsCreatedWithExpectedParams(): void
             ->willReturn(2020)
         ;
 
-        $expected = \hash_hmac(
+        $expected = hash_hmac(
             'sha256',
-            \json_encode(['verifier', 'user1234', 2020]),
+            json_encode(['verifier', 'user1234', 2020]),
             'key',
             true
         );
 
         $generator = $this->getTokenGenerator();
         $result = $generator->createToken($this->mockExpiresAt, 'user1234');
 
-        self::assertSame(\base64_encode($expected), $result->getHashedToken());
+        self::assertSame(base64_encode($expected), $result->getHashedToken());
     }
 
     public function testHashedTokenIsCreatedUsingOptionVerifierParam(): void
@@ -95,17 +95,17 @@ public function testHashedTokenIsCreatedUsingOptionVerifierParam(): void
             ->willReturn($date)
         ;
 
-        $knownToken = \hash_hmac(
+        $knownToken = hash_hmac(
             'sha256',
-            \json_encode([$knownVerifier, $userId, $date]),
+            json_encode([$knownVerifier, $userId, $date]),
             'key',
             true
         );
 
         $generator = $this->getTokenGenerator();
         $result = $generator->createToken($this->mockExpiresAt, $userId, $knownVerifier);
 
-        self::assertSame(\base64_encode($knownToken), $result->getHashedToken());
+        self::assertSame(base64_encode($knownToken), $result->getHashedToken());
     }
 
     private function getTokenGenerator(): ResetPasswordTokenGenerator