Skip to content

Commit ad9d2f0

Browse files
Merge pull request #40 from xabbuh/issue-39
case-insensitive alias matching
2 parents 75b758e + 05c97a9 commit ad9d2f0

File tree

3 files changed

+14
-1
lines changed

3 files changed

+14
-1
lines changed

PhpUnit/ContainerBuilderHasAliasConstraint.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ private function evaluateServiceId(ContainerBuilder $containerBuilder, $returnRe
7979
*/
8080
$actualServiceId = (string) $alias;
8181

82-
$constraint = new \PHPUnit_Framework_Constraint_IsEqual($this->expectedServiceId);
82+
$constraint = new \PHPUnit_Framework_Constraint_IsEqual(strtolower($this->expectedServiceId));
8383
if (!$constraint->evaluate($actualServiceId, '', true)) {
8484
if ($returnResult) {
8585
return false;

Tests/Loader/LoaderFactoryTest.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ private function createMockContainerBuilder()
4444
return $this
4545
->getMockBuilder('Symfony\Component\DependencyInjection\ContainerBuilder')
4646
->disableOriginalConstructor()
47+
->setMethods(null)
4748
->getMock();
4849
}
4950
}

Tests/PhpUnit/ContainerBuilderHasAliasConstraintTest.php

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,4 +73,16 @@ public function it_expects_a_string_for_service_id()
7373
$this->setExpectedException('\InvalidArgumentException', 'string');
7474
new ContainerBuilderHasAliasConstraint('alias_id', new \stdClass());
7575
}
76+
77+
/**
78+
* @test
79+
*/
80+
public function it_lower_cases_aliased_service_ids()
81+
{
82+
$containerBuilder = new ContainerBuilder();
83+
$containerBuilder->setAlias('foo', 'fooBar');
84+
$constraint = new ContainerBuilderHasAliasConstraint('foo', 'fooBar');
85+
86+
$this->assertTrue($constraint->evaluate($containerBuilder, null, true));
87+
}
7688
}

0 commit comments

Comments
 (0)