Prepend is now ALWAYS invoked.

Author: TheCelavi

PhpUnit/AbstractExtensionTestCase.php

@@ -49,15 +49,14 @@ protected function setUp()
      * set $withPrependInvocation to TRUE to invoke prepend() method prior to load() method of your extension.
      *
      * @param array $configurationValues
-     * @param bool $withPrependInvocation
      */
-    protected function load(array $configurationValues = array(), $withPrependInvocation = false)
+    protected function load(array $configurationValues = array())
     {
         $configs = array($this->getMinimalConfiguration(), $configurationValues);
 
         foreach ($this->container->getExtensions() as $extension) {
 
-            if ($withPrependInvocation && $extension instanceof PrependExtensionInterface) {
+            if ($extension instanceof PrependExtensionInterface) {
                 $extension->prepend($this->container);
             }
 

README.md

@@ -102,26 +102,6 @@ class MyExtensionTest extends AbstractExtensionTestCase
 To prevent duplication of required configuration values, you can provide some minimal configuration, by overriding
 the ``getMinimalConfiguration()`` method of the test case.
 
-If your extension implements `Symfony\Component\DependencyInjection\Extension\PrependExtensionInterface`, you may test
-its effect on execution by passing ``true`` as a second parameter to ``load()`` method.
-
-```php
-<?php
-
-class MyExtensionTest extends AbstractExtensionTestCase
-{
-    /**
-     * @test
-     */
-    public function after_loading_the_correct_parameter_has_been_set()
-    {
-        $this->load(array(), true);
-
-        ...
-    }
-}
-```
-
 ## Testing a compiler pass
 
 To test a compiler pass, create a test class and extend from

Tests/Fixtures/MatthiasDependencyInjectionTestExtension.php

@@ -5,20 +5,11 @@
 use Symfony\Component\DependencyInjection\Definition;
 use Symfony\Component\DependencyInjection\Extension\ExtensionInterface;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
-use Symfony\Component\DependencyInjection\Extension\PrependExtensionInterface;
 use Symfony\Component\DependencyInjection\Loader\XmlFileLoader;
 use Symfony\Component\Config\FileLocator;
 
-class MatthiasDependencyInjectionTestExtension implements ExtensionInterface, PrependExtensionInterface
+class MatthiasDependencyInjectionTestExtension implements ExtensionInterface
 {
-    /**
-     * {@inheritdoc}
-     */
-    public function prepend(ContainerBuilder $container)
-    {
-        $container->setParameter('prepend_extension_interface.successfully_invoked', 'prepended value');
-    }
-
     public function load(array $config, ContainerBuilder $container)
     {
         // load some service definitions

Tests/Fixtures/NonPrependableTestExtension.php

@@ -0,0 +1,31 @@
+<?php
+
+namespace Matthias\SymfonyDependencyInjectionTest\Tests\Fixtures;
+
+use Symfony\Component\DependencyInjection\ContainerBuilder;
+use Symfony\Component\DependencyInjection\Extension\ExtensionInterface;
+
+class NonPrependableTestExtension implements ExtensionInterface
+{
+    public function prepend(ContainerBuilder $container)
+    {
+        $container->setParameter('ignored_invocation', 'ignored value');
+    }
+
+    public function load(array $config, ContainerBuilder $container)
+    {
+    }
+
+    public function getAlias()
+    {
+        return 'non_prependable_test';
+    }
+
+    public function getNamespace()
+    {
+    }
+
+    public function getXsdValidationBasePath()
+    {
+    }
+}

Tests/Fixtures/PrependableTestExtension.php

@@ -0,0 +1,32 @@
+<?php
+
+namespace Matthias\SymfonyDependencyInjectionTest\Tests\Fixtures;
+
+use Symfony\Component\DependencyInjection\ContainerBuilder;
+use Symfony\Component\DependencyInjection\Extension\ExtensionInterface;
+use Symfony\Component\DependencyInjection\Extension\PrependExtensionInterface;
+
+class PrependableTestExtension implements ExtensionInterface, PrependExtensionInterface
+{
+    public function prepend(ContainerBuilder $container)
+    {
+        $container->setParameter('prepend_parameter_set', 'prepended value');
+    }
+
+    public function load(array $config, ContainerBuilder $container)
+    {
+    }
+
+    public function getAlias()
+    {
+        return 'prependable_test';
+    }
+
+    public function getNamespace()
+    {
+    }
+
+    public function getXsdValidationBasePath()
+    {
+    }
+}

Tests/PhpUnit/AbstractPrependExtensionTestCaseTest.php

@@ -3,38 +3,40 @@
 namespace Matthias\DependencyInjectionTests\Test\DependencyInjection;
 
 use Matthias\SymfonyDependencyInjectionTest\PhpUnit\AbstractExtensionTestCase;
-use Matthias\SymfonyDependencyInjectionTest\Tests\Fixtures\MatthiasDependencyInjectionTestExtension;
+use Matthias\SymfonyDependencyInjectionTest\Tests\Fixtures\NonPrependableTestExtension;
+use Matthias\SymfonyDependencyInjectionTest\Tests\Fixtures\PrependableTestExtension;
 use PHPUnit\Framework\ExpectationFailedException;
 
 class AbstractPrependExtensionTestCaseTest extends AbstractExtensionTestCase
 {
     protected function getContainerExtensions()
     {
         return array(
-            new MatthiasDependencyInjectionTestExtension()
+            new PrependableTestExtension(),
+            new NonPrependableTestExtension()
         );
     }
 
     /**
      * @test
      */
-    public function if_prepend_invoked_it_does_not_fails()
+    public function prepend_invoked_only_if_prepend_interface_is_implemented()
     {
-        $this->load([], true);
+        $this->load();
 
-        $this->assertContainerBuilderHasParameter('prepend_extension_interface.successfully_invoked', 'prepended value');
+        $this->assertContainerBuilderHasParameter('prepend_parameter_set', 'prepended value');
     }
 
     /**
      * @test
      */
-    public function if_prepend_is_not_invoked_it_does_not_fails()
+    public function if_prepend_interface_is_not_implemented_prepend_is_not_invoked()
     {
         $this->load();
 
         $this->expectException(ExpectationFailedException::class);
-        $this->expectExceptionMessage('prepend_extension_interface.successfully_invoked');
+        $this->expectExceptionMessage('ignored_invocation');
 
-        $this->assertContainerBuilderHasParameter('prepend_extension_interface.successfully_invoked', 'prepended value');
+        $this->assertContainerBuilderHasParameter('ignored_invocation', 'ignored value');
     }
 }