Fix CI post-merge PHP 8 (#31)

* Fix CI post-merge PHP 8

* Update .github/workflows/ci.yml

* Update .github/workflows/ci.yml

* Remove scrutinizer and coverage + update CI

Co-authored-by: Tobias Nyholm <[email protected]>

Author: vincentchalamon

.github/workflows/ci.yml

@@ -15,24 +15,36 @@ jobs:
     strategy:
       matrix:
         php:
-          - '5.5'
-          - '5.6'
-          - '7.0'
-          - '7.1'
           - '7.2'
           - '7.3'
           - '7.4'
           - '8.0'
+        dependency:
+          - ''
+          - 'lowest'
         symfony:
           - '3.4.*'
           - '4.4.*'
           - '5.0.*'
-        include:
-          - php: '7.1'
-            coverage: true
-        dependency:
-          - ''
-          - 'lowest'
+        exclude:
+          - php: '7.2'
+            symfony: '3.4.*'
+            dependency: 'lowest'
+          - php: '7.2'
+            symfony: '4.4.*'
+            dependency: 'lowest'
+          - php: '7.3'
+            symfony: '3.4.*'
+          - php: '7.3'
+            symfony: '4.4.*'
+          - php: '7.4'
+            symfony: '3.4.*'
+          - php: '7.4'
+            symfony: '4.4.*'
+          - php: '8.0'
+            symfony: '3.4.*'
+          - php: '8.0'
+            symfony: '4.4.*'
       fail-fast: false
     steps:
       - name: Checkout
@@ -42,7 +54,10 @@ jobs:
         uses: shivammathur/setup-php@v2
         with:
           php-version: ${{ matrix.php }}
-          extensions: curl, dom, iconv, intl, json, libxml, mbstring, phar, tokenizer, xdebug, xml, xmlwriter
+          extensions: composer:v2, flex, pcov
+
+      - name: Configure Symfony
+        run: composer config extra.symfony.require "${{ matrix.symfony }}"
 
       - name: Get Composer Cache Directory
         id: composer-cache
@@ -55,11 +70,6 @@ jobs:
           key: ${{ matrix.php }}-composer-${{ hashFiles('**/composer.json') }}
           restore-keys: ${{ matrix.php }}-composer-
 
-      - name: Configure Symfony
-        run: |
-          composer global require symfony/flex
-          composer config extra.symfony.require "${{ matrix.symfony }}"
-
       - name: Update project dependencies
         if: matrix.dependency == ''
         run: composer update --no-progress --ansi --prefer-stable
@@ -72,15 +82,4 @@ jobs:
         run: composer validate --strict --no-check-lock
 
       - name: Run tests
-        if: !matrix.coverage
         run: vendor/bin/phpunit
-
-      - name: Run tests with coverage
-        if: matrix.coverage
-        run: vendor/bin/phpunit --coverage-text --coverage-clover=build/coverage.xml
-
-      - name: Upload coverage
-        if: matrix.coverage
-        run: |
-          wget https://scrutinizer-ci.com/ocular.phar
-          php ocular.phar code-coverage:upload --format=php-clover build/coverage.xml

Readme.md

@@ -2,18 +2,16 @@
 
 [![Latest Version](https://img.shields.io/github/release/Nyholm/symfony-bundle-test.svg?style=flat-square)](https://github.com/Nyholm/symfony-bundle-test/releases)
 [![Build Status](https://img.shields.io/travis/SymfonyTest/symfony-bundle-test/master.svg?style=flat-square)](https://travis-ci.org/SymfonyTest/symfony-bundle-test)
-[![Code Coverage](https://img.shields.io/scrutinizer/coverage/g/Nyholm/symfony-bundle-test.svg?style=flat-square)](https://scrutinizer-ci.com/g/Nyholm/symfony-bundle-test)
-[![Quality Score](https://img.shields.io/scrutinizer/g/Nyholm/symfony-bundle-test.svg?style=flat-square)](https://scrutinizer-ci.com/g/Nyholm/symfony-bundle-test)
 [![Total Downloads](https://img.shields.io/packagist/dt/nyholm/symfony-bundle-test.svg?style=flat-square)](https://packagist.org/packages/nyholm/symfony-bundle-test)
 
 **Test if your bundle is compatible with different Symfony versions**
 
 When you want to make sure that your bundle works with different versions of Symfony
-you need to create a custom `AppKernel` and load your bundle and configuration. 
+you need to create a custom `AppKernel` and load your bundle and configuration.
 
-Using this bundle test together with Matthias Nobacks's 
+Using this bundle test together with Matthias Nobacks's
 [SymfonyDependencyInjectionTest](https://github.com/SymfonyTest/SymfonyDependencyInjectionTest)
-will give you a good base for testing a Symfony bundle. 
+will give you a good base for testing a Symfony bundle.
 
 ## Install
 
@@ -42,7 +40,7 @@ class BundleInitializationTest extends BaseBundleTestCase
     {
         // Boot the kernel.
         $this->bootKernel();
-        
+
         // Get the container
         $container = $this->getContainer();
 
@@ -51,22 +49,22 @@ class BundleInitializationTest extends BaseBundleTestCase
         $service = $container->get('acme.foo');
         $this->assertInstanceOf(Foo::class, $service);
     }
-    
+
     public function testBundleWithDifferentConfiguration()
     {
         // Create a new Kernel
         $kernel = $this->createKernel();
-        
+
         // Add some configuration
         $kernel->addConfigFile(__DIR__.'/config.yml');
-        
+
         // Add some other bundles we depend on
         $kernel->addBundle(OtherBundle::class);
 
         // Boot the kernel as normal ...
         $this->bootKernel();
-        
-        // ... 
+
+        // ...
     }
 }
 
@@ -75,18 +73,18 @@ class BundleInitializationTest extends BaseBundleTestCase
 ## Private services in Symfony 4
 
 In Symfony 4 services are private by default. This is a good thing, but in order to test them properly we need to make
-them public when we are running the tests. This can easily be done with a compiler pass. 
+them public when we are running the tests. This can easily be done with a compiler pass.
 
 ```php
 class BundleInitializationTest extends BaseBundleTestCase
 {
     protected function setUp()
     {
         parent::setUp();
-        
+
         // Make all services public
         $this->addCompilerPass(new PublicServicePass());
-        
+
         // Make services public that have an idea that matches a regex
         $this->addCompilerPass(new PublicServicePass('|my_bundle.*|'));
     }
@@ -101,7 +99,7 @@ Be aware that if you make all services public then you will not get any errors i
 
 ## Configure Travis
 
-You want Travis to run against each currently supported LTS version of Symfony (since there would be only one per major version), plus the current if it's not an LTS too. There is no need for testing against version in between because Symfony follows [Semantic Versioning](http://semver.org/spec/v2.0.0.html). 
+You want Travis to run against each currently supported LTS version of Symfony (since there would be only one per major version), plus the current if it's not an LTS too. There is no need for testing against version in between because Symfony follows [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
 ```yaml
 language: php

composer.json

@@ -17,7 +17,7 @@
         "symfony/yaml": "^3.4 || ^4.3 || ^5.0"
     },
     "require-dev": {
-        "phpunit/phpunit": "^4.8.36 || ^5.5 || ^6.2"
+        "phpunit/phpunit": "^8.5 || ^9.4"
     },
     "autoload": {
         "psr-4": { "Nyholm\\BundleTest\\": "src/" }