Skip to content

Commit c0299a5

Browse files
authored
Make aliases public in compiler pass (#20)
* Make aliases public as wll * Added changelog * Removed HHVM
1 parent 35fb99a commit c0299a5

File tree

3 files changed

+13
-2
lines changed

3 files changed

+13
-2
lines changed

.travis.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ matrix:
3232
- php: 5.6
3333
- php: 7.0
3434
- php: 7.2
35-
- php: hhvm
3635
dist: trusty
3736
- php: 7.1
3837
env: DEPENDENCIES="dunglas/symfony-lock:^2"

Changelog.md

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,17 @@
22

33
The change log describes what is "Added", "Removed", "Changed" or "Fixed" between each release.
44

5+
## 1.4.0
6+
7+
### Added
8+
9+
- Aliases can be made public with the `PublicServicePass`.
10+
511
## 1.3.1
612

713
### Fixed
814

9-
- Show our dependencies directly in require secion of composer.json.
15+
- Show our dependencies directly in require section of composer.json.
1016

1117
## 1.3.0
1218

src/CompilerPass/PublicServicePass.php

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,5 +35,11 @@ public function process(ContainerBuilder $container)
3535
$definition->setPublic(true);
3636
}
3737
}
38+
39+
foreach ($container->getAliases() as $id => $alias) {
40+
if (preg_match($this->regex, $id)) {
41+
$alias->setPublic(true);
42+
}
43+
}
3844
}
3945
}

0 commit comments

Comments
 (0)