Skip to content

Commit dbdfb26

Browse files
authored
Remove non-PHP5 code (#62)
* Remove non-PHP5 code * Added php 5 to CI * Use phpunit bridge
1 parent 5d82bed commit dbdfb26

File tree

3 files changed

+9
-7
lines changed

3 files changed

+9
-7
lines changed

.github/workflows/ci.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@ jobs:
88
strategy:
99
matrix:
1010
php:
11+
- '5.5'
12+
- '5.6'
1113
- '7.2'
1214
- '7.3'
1315
- '7.4'
@@ -77,4 +79,4 @@ jobs:
7779
run: composer validate --strict --no-check-lock
7880

7981
- name: Run tests
80-
run: vendor/bin/phpunit
82+
run: vendor/bin/simple-phpunit

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
"symfony/yaml": "^3.4 || ^4.3 || ^5.0 || ^6.0"
1818
},
1919
"require-dev": {
20-
"phpunit/phpunit": "^8.5 || ^9.4"
20+
"symfony/phpunit-bridge": "^4.4 || ^5.3"
2121
},
2222
"autoload": {
2323
"psr-4": {

src/AppKernel.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -81,17 +81,17 @@ public function addConfigFile($configFile)
8181
$this->configFiles[] = $configFile;
8282
}
8383

84-
public function getCacheDir(): string
84+
public function getCacheDir()
8585
{
8686
return sys_get_temp_dir().'/NyholmBundleTest/'.$this->cachePrefix;
8787
}
8888

89-
public function getLogDir(): string
89+
public function getLogDir()
9090
{
9191
return sys_get_temp_dir().'/NyholmBundleTest/log';
9292
}
9393

94-
public function getProjectDir(): string
94+
public function getProjectDir()
9595
{
9696
if (null === $this->fakedProjectDir) {
9797
return realpath(__DIR__.'/../../../../');
@@ -116,7 +116,7 @@ public function setProjectDir($projectDir)
116116
$this->fakedProjectDir = $projectDir;
117117
}
118118

119-
public function registerBundles(): iterable
119+
public function registerBundles()
120120
{
121121
$this->bundlesToRegister = array_unique($this->bundlesToRegister);
122122
$bundles = [];
@@ -204,7 +204,7 @@ public function loadRoutes(LoaderInterface $loader)
204204
/**
205205
* {@inheritdoc}
206206
*/
207-
protected function buildContainer(): ContainerBuilder
207+
protected function buildContainer()
208208
{
209209
$container = parent::buildContainer();
210210

0 commit comments

Comments
 (0)