Skip to content

Commit 0d88c4e

Browse files
Addressed review changes.
1 parent a8d57d6 commit 0d88c4e

File tree

2 files changed

+10
-72
lines changed

2 files changed

+10
-72
lines changed

lib/main.dart

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,7 @@ class _CustomRangeColumnSeriesRenderer
231231
class _RangeColumnCustomPainter extends RangeColumnSegment<G7DebtData, String> {
232232
_RangeColumnCustomPainter();
233233

234-
void paintText(Canvas canvas, String text, Offset position, double fontSize,
234+
void _paintText(Canvas canvas, String text, Offset position, double fontSize,
235235
{bool isCenter = false, Color baseColor = Colors.black}) {
236236
final TextSpan span = TextSpan(
237237
style: TextStyle(
@@ -252,7 +252,7 @@ class _RangeColumnCustomPainter extends RangeColumnSegment<G7DebtData, String> {
252252
Offset(position.dx - tp.width / 2, position.dy - tp.height / 2));
253253
}
254254

255-
void drawCustomCircle(Canvas canvas, Offset center, double radius,
255+
void _drawCustomCircle(Canvas canvas, Offset center, double radius,
256256
Paint fillPaint, Paint strokePaint) {
257257
canvas.drawCircle(center, radius, fillPaint);
258258
canvas.drawCircle(center, radius - 1, strokePaint);
@@ -294,16 +294,16 @@ class _RangeColumnCustomPainter extends RangeColumnSegment<G7DebtData, String> {
294294

295295
canvas.drawRRect(segmentRect!, gradientPaint);
296296

297-
drawCustomCircle(canvas, Offset(center, top), segmentRect!.width / 2,
297+
_drawCustomCircle(canvas, Offset(center, top), segmentRect!.width / 2,
298298
isPositiveChange ? customPaint : fillPaint, strokePaint);
299-
drawCustomCircle(canvas, Offset(center, bottom), segmentRect!.width / 2,
299+
_drawCustomCircle(canvas, Offset(center, bottom), segmentRect!.width / 2,
300300
isPositiveChange ? fillPaint : customPaint, strokePaint);
301301

302-
paintText(canvas, '${topText.round()}%', Offset(center, top), 20);
303-
paintText(canvas, '${bottomText.round()}%', Offset(center, bottom), 20);
302+
_paintText(canvas, '${topText.round()}%', Offset(center, top), 20);
303+
_paintText(canvas, '${bottomText.round()}%', Offset(center, bottom), 20);
304304

305305
if (centerText.abs() > 5) {
306-
paintText(
306+
_paintText(
307307
canvas,
308308
'${centerText >= 0 ? '+' : ''}${centerText.round()}pp',
309309
segmentRect!.center,

pubspec.yaml

Lines changed: 3 additions & 65 deletions
Original file line numberDiff line numberDiff line change
@@ -1,95 +1,33 @@
11
name: range_column_blog
22
description: "A new Flutter project."
3-
# The following line prevents the package from being accidentally published to
4-
# pub.dev using `flutter pub publish`. This is preferred for private packages.
5-
publish_to: 'none' # Remove this line if you wish to publish to pub.dev
6-
7-
# The following defines the version and build number for your application.
8-
# A version number is three numbers separated by dots, like 1.2.43
9-
# followed by an optional build number separated by a +.
10-
# Both the version and the builder number may be overridden in flutter
11-
# build by specifying --build-name and --build-number, respectively.
12-
# In Android, build-name is used as versionName while build-number used as versionCode.
13-
# Read more about Android versioning at https://developer.android.com/studio/publish/versioning
14-
# In iOS, build-name is used as CFBundleShortVersionString while build-number is used as CFBundleVersion.
15-
# Read more about iOS versioning at
16-
# https://developer.apple.com/library/archive/documentation/General/Reference/InfoPlistKeyReference/Articles/CoreFoundationKeys.html
17-
# In Windows, build-name is used as the major, minor, and patch parts
18-
# of the product and file versions while build-number is used as the build suffix.
3+
publish_to: 'none'
194
version: 1.0.0+1
205

216
environment:
227
sdk: ^3.6.0
238

24-
# Dependencies specify other packages that your package needs in order to work.
25-
# To automatically upgrade your package dependencies to the latest versions
26-
# consider running `flutter pub upgrade --major-versions`. Alternatively,
27-
# dependencies can be manually updated by changing the version numbers below to
28-
# the latest version available on pub.dev. To see which dependencies have newer
29-
# versions available, run `flutter pub outdated`.
309
dependencies:
3110
flutter:
3211
sdk: flutter
3312

34-
# The following adds the Cupertino Icons font to your application.
35-
# Use with the CupertinoIcons class for iOS style icons.
3613
cupertino_icons: ^1.0.8
3714
syncfusion_flutter_charts: ^28.1.37
3815

3916
dev_dependencies:
4017
flutter_test:
4118
sdk: flutter
4219

43-
# The "flutter_lints" package below contains a set of recommended lints to
44-
# encourage good coding practices. The lint set provided by the package is
45-
# activated in the `analysis_options.yaml` file located at the root of your
46-
# package. See that file for information about deactivating specific lint
47-
# rules and activating additional ones.
4820
flutter_lints: ^5.0.0
4921

50-
# For information on the generic Dart part of this file, see the
51-
# following page: https://dart.dev/tools/pub/pubspec
52-
53-
# The following section is specific to Flutter packages.
5422
flutter:
55-
# The following line ensures that the Material Icons font is
56-
# included with your application, so that you can use the icons in
57-
# the material Icons class.
23+
5824
uses-material-design: true
5925

60-
# To add assets to your application, add an assets section, like this:
6126
assets:
6227
- Image\Canada.png
6328
- Image\France.png
6429
- Image\Germany.png
6530
- Image\Italy.png
6631
- Image\Japan.png
6732
- Image\UK.png
68-
- Image\USA.png
69-
70-
71-
# An image asset can refer to one or more resolution-specific "variants", see
72-
# https://flutter.dev/to/resolution-aware-images
73-
74-
# For details regarding adding assets from package dependencies, see
75-
# https://flutter.dev/to/asset-from-package
76-
77-
# To add custom fonts to your application, add a fonts section here,
78-
# in this "flutter" section. Each entry in this list should have a
79-
# "family" key with the font family name, and a "fonts" key with a
80-
# list giving the asset and other descriptors for the font. For
81-
# example:
82-
# fonts:
83-
# - family: Schyler
84-
# fonts:
85-
# - asset: fonts/Schyler-Regular.ttf
86-
# - asset: fonts/Schyler-Italic.ttf
87-
# style: italic
88-
# - family: Trajan Pro
89-
# fonts:
90-
# - asset: fonts/TrajanPro.ttf
91-
# - asset: fonts/TrajanPro_Bold.ttf
92-
# weight: 700
93-
#
94-
# For details regarding fonts from package dependencies,
95-
# see https://flutter.dev/to/font-from-package
33+
- Image\USA.png

0 commit comments

Comments
 (0)