fix(validator-dir): fix realpathAlloc failure if dir doesn't exist

- allow ensureValidatorDir to create directory if it does not exist
- move ensureValidatorDir dir to outside sub command

Author: Ubuntu

src/cmd.zig

@@ -104,7 +104,7 @@ pub fn main() !void {
     current_config.metrics_port = cmd.metrics_port;
     current_config.log_file = cmd.log_file;
     current_config.tee_logs = cmd.tee_logs;
-    current_config.validator_dir = try std.fs.realpathAlloc(gpa, cmd.validator_dir);
+    current_config.validator_dir = try ensureValidatorDir(gpa, cmd.validator_dir);
 
     // If no subcommand was provided, print a friendly header and help information.
     const subcmd = cmd.subcmd orelse {
@@ -1292,16 +1292,29 @@ const AllocationMetrics = struct {
     allocated_bytes_sqlite: *Gauge(u64),
 };
 
-/// Ensures the validator directory exists.
-/// Returns an error if the directory cannot be accessed.
-fn ensureValidatorDir(logger: Logger, validator_dir: []const u8) !void {
-    _ = std.fs.cwd().openDir(validator_dir, .{}) catch |err| {
-        logger.err().logf(
-            "Cannot create or access validator directory '{s}': {}",
-            .{ validator_dir, err },
-        );
-        return err;
+/// Ensures the validator directory exists. Create it if it does not.
+fn ensureValidatorDir(allocator: std.mem.Allocator, validator_dir: []const u8) ![]const u8 {
+    std.fs.cwd().access(validator_dir, .{}) catch |access_err| {
+        switch (access_err) {
+            error.FileNotFound => {
+                std.fs.cwd().makePath(validator_dir) catch |create_err| {
+                    std.debug.print(
+                        "Cannot create validator directory '{s}': {}",
+                        .{ validator_dir, create_err },
+                    );
+                    return create_err;
+                };
+            },
+            else => {
+                std.debug.print(
+                    "Cannot access validator directory '{s}': {}",
+                    .{ validator_dir, access_err },
+                );
+                return access_err;
+            },
+        }
     };
+    return std.fs.realpathAlloc(allocator, validator_dir);
 }
 
 /// Ensures a genesis file is available by either using the provided path
@@ -1435,7 +1448,6 @@ fn validator(
 
     const allocator = gpa_metrics.allocator();
 
-    try ensureValidatorDir(app_base.logger, cfg.validator_dir);
     const genesis_file_path = try ensureGenesis(allocator, cfg, app_base.logger);
     defer allocator.free(genesis_file_path);
 
@@ -1732,20 +1744,24 @@ fn replayOffline(
 
     const allocator = gpa_metrics.allocator();
 
-    try ensureValidatorDir(app_base.logger, cfg.validator_dir);
     const genesis_file_path = try ensureGenesis(allocator, cfg, app_base.logger);
     defer allocator.free(genesis_file_path);
 
-    const snapshot_dir_str = cfg.accounts_db.snapshot_dir;
-    var snapshot_dir = try std.fs.cwd().makeOpenPath(snapshot_dir_str, .{ .iterate = true });
+    var snapshot_dir = try std.fs.cwd().makeOpenPath(
+        cfg.accounts_db.snapshot_dir,
+        .{ .iterate = true },
+    );
     defer snapshot_dir.close();
 
     const ledger_dir = try std.fs.path.join(allocator, &.{ cfg.validator_dir, "ledger" });
     defer allocator.free(ledger_dir);
 
     const snapshot_files = try SnapshotFiles.find(allocator, snapshot_dir);
 
-    const rooted_file = try std.fs.path.joinZ(allocator, &.{ snapshot_dir_str, "accounts.db" });
+    const rooted_file = try std.fs.path.joinZ(
+        allocator,
+        &.{ cfg.accounts_db.snapshot_dir, "accounts.db" },
+    );
     defer allocator.free(rooted_file);
 
     var rooted_db: sig.accounts_db.Two.Rooted = try .init(rooted_file);
@@ -1858,7 +1874,6 @@ fn shredNetwork(
         app_base.deinit();
     }
 
-    try ensureValidatorDir(app_base.logger, cfg.validator_dir);
     const genesis_file_path = try ensureGenesis(allocator, cfg, app_base.logger);
     defer allocator.free(genesis_file_path);
     const genesis_config = try GenesisConfig.init(allocator, genesis_file_path);
@@ -2051,7 +2066,6 @@ fn validateSnapshot(allocator: std.mem.Allocator, cfg: config.Cmd) !void {
         app_base.deinit();
     }
 
-    try ensureValidatorDir(.noop, cfg.validator_dir);
     const genesis_file_path = try ensureGenesis(allocator, cfg, .from(app_base.logger));
     defer allocator.free(genesis_file_path);