Skip to content

Commit e6dc4f7

Browse files
committed
♻️ support php 8.4
1 parent 1de1e96 commit e6dc4f7

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

.github/workflows/main.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ jobs:
88
strategy:
99
fail-fast: false
1010
matrix:
11-
php: [8.1, 8.2, 8.3]
11+
php: [8.1, 8.2, 8.3, 8.4]
1212
symfony_process: [4, 5, 6, 7]
1313
exclude:
1414
- php: 8.1

src/Browserless.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ class Browserless extends AbstractPDF
3535
* @param int $rotation The number of degrees to rotate the document by
3636
* @return self
3737
*/
38-
public function setRotation(int $rotation = null): self
38+
public function setRotation(?int $rotation = null): self
3939
{
4040
$this->rotate = $rotation;
4141
return $this;
@@ -60,7 +60,7 @@ public function setSafeMode(bool $safeMode): self
6060
* @param int $milliseconds
6161
* @return self
6262
*/
63-
public function setTimeout(int $milliseconds = null): self
63+
public function setTimeout(?int $milliseconds = null): self
6464
{
6565
$this->timeout = $milliseconds;
6666
return $this;

src/Browserless/Client.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ trait Client
2020
* @param \GuzzleHttp\Client $client custom Guzzle client
2121
*/
2222
public function __construct(
23-
string $apiKey = null,
23+
?string $apiKey = null,
2424
EndpointsEnum|string $endpoint = EndpointsEnum::Default,
2525
$client = null
2626
) {

0 commit comments

Comments
 (0)