[TASK] Prevent fluid 1st run bug

On first run fluid uses same VH instances on sub render processes, so we extract
data from $this->arguments array before the call to $this->renderChilds() happens,
so we have a local copy of the arguments needed.

Talked issue to Fluid Team.

Resolve: #632
Release: 12.1.0

Author: opi99

Classes/ViewHelpers/ArrayVariableViewHelper.php

@@ -24,16 +24,18 @@ public function initializeArguments()
      */
     public function render()
     {
+        $nameOfArray = $this->arguments['name'];
+        $nameOfKey = $this->arguments['key'];
+
         $value = ($this->arguments['value'] ?? $this->renderChildren());
 
         $container = [];
 
-        if ($this->renderingContext->getVariableProvider()->exists($this->arguments['name'])) {
-            $container = $this->renderingContext->getVariableProvider()->get($this->arguments['name']);
+        if ($this->renderingContext->getVariableProvider()->exists($nameOfArray)) {
+            $container = $this->renderingContext->getVariableProvider()->get($nameOfArray);
         }
+        $container = ArrayUtility::setValueByPath($container, $nameOfKey, $value, '.');
 
-        $container = ArrayUtility::setValueByPath($container, $this->arguments['key'], $value, '.');
-
-        $this->renderingContext->getVariableProvider()->add($this->arguments['name'], $container);
+        $this->renderingContext->getVariableProvider()->add($nameOfArray, $container);
     }
 }

Classes/ViewHelpers/Format/StripTagsViewHelper.php

@@ -109,13 +109,14 @@ public function initializeArguments()
      */
     public function render()
     {
-        $value = $this->renderChildren();
         $allowedTags = $this->arguments['allowedTags'];
+        $whitespaces = $this->arguments['whitespace'];
+        $value = $this->renderChildren();
         if (!is_string($value) && !(is_object($value) && method_exists($value, '__toString'))) {
             return $value;
         }
         $value = (string)$value;
-        if ($this->arguments['whitespace']) {
+        if ($whitespaces) {
             $value = preg_replace('/(\S)<\//', '\1 </', $value);
         }
         return strip_tags($value, $allowedTags);

Classes/ViewHelpers/Format/WordLengthViewHelper.php

@@ -43,12 +43,14 @@ public function initializeArguments()
      */
     public function render()
     {
+        $maxCharacter = $this->arguments['maxCharacters'];
+
         $value = $this->renderChildren();
 
         if (!is_string($value) && !(is_object($value) && method_exists($value, '__toString'))) {
             return $value;
         }
 
-        return  preg_replace('/(\S{' . $this->arguments['maxCharacters'] . '})/', '\1 ', (string)$value);
+        return  preg_replace('/(\S{' . $maxCharacter . '})/', '\1 ', (string)$value);
     }
 }

Classes/ViewHelpers/SplitIntoArrayViewHelper.php

@@ -25,9 +25,9 @@ public function initializeArguments()
     public function render()
     {
         $pattern = $this->arguments['pattern'] ?? ($this->arguments['delimiterDecimal'] ? '\x' . dechex($this->arguments['delimiterDecimal']) : '');
-        $value = $this->arguments['value'] ?? $this->renderChildren() ?? '';
-        $limit = $this->arguments['limit'] ?? -1;
         // mb_split default is -1
+        $limit = $this->arguments['limit'] ?? -1;
+        $value = $this->arguments['value'] ?? $this->renderChildren() ?? '';
 
         $result = mb_split($pattern, $value, $limit);