-
Notifications
You must be signed in to change notification settings - Fork 0
Description
Goal
Implement a common "Uploader" that is used by all existing file upload contexts, and supports both existing layouts, in https://github.com/TACC/Core-Portal.
Proposal
- There would be one component that supports both
dropzone-orlistinganddropzoneand-listing. - All components that have a file upload form would use this new component, e.g.
TicketCreateFormTicketModalDataFilesUploadModal
- The component would be common component.
- The component could be named
Uploader. - The component would be comprised of
Uploader,UploaderDropZone, andUploaderListing.
Direction
What Components Would be Relevant and How?
-
_common/Uploader_(is dropzone + listing) (supports two layouts) -
_common/UploaderDropZone(is dropzone) -
_common/UploaderListing(is listing) -
Tickets/TicketCreateForm_common/Uploader⤴
-
Tickets/TicketModal_common/Uploader⤴
-
`DataFiles/DataFilesModal/DataFilesUploadModal
_common/Uploader⤴
Note
The DataFilesUploadModal supports two layouts already.
Background
FP-388 attempted to do this. But its description did not include knowledge of the actual code. The original developer interpreted the ticket as best possible. The PR was difficult, unclear, and incomplete. The code was polished, and WP-529 was created to finish the work. WP-529 was to be closed, so this issue was created to save the idea with an appropriate codebase.