Skip to content

Task/fp 1499 cms pattern library - serve at /ui url #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wesleyboar wants to merge 1 commit into from
Closed

Task/fp 1499 cms pattern library - serve at /ui url #677

wesleyboar wants to merge 1 commit into from

Conversation

@wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Jul 25, 2022

Overview

Serve TACC/Core-CMS#512 taccsite_ui/ at /ui.

Related

Changes

  • (docker-compose) mount taccsite_ui/ at cms/ui
  • (nginx) serve cms/ui at /ui

Testing / UI

See TACC/Core-CMS#512 for remote servers.

@wesleyboar
feat: fp-1499 serve cms taccsite_ui → cms/ui @ /ui
0b2e884 
0. (core-cms) fp-1499 adds /taccsite_ui
1. (docker-compose) mount taccsite_ui/ at cms/ui
2. (nginx) serve cms/ui at /ui
@wesleyboar wesleyboar mentioned this pull request Jul 25, 2022
Closed
@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #677 (0b2e884) into main (8efdf57) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #677   +/-   ##
=======================================
  Coverage   67.35%   67.35%           
=======================================
  Files         429      429           
  Lines       13422    13422           
  Branches     2500     2500           
=======================================
  Hits         9040     9040           
  Misses       4090     4090           
  Partials      292      292
Flag Coverage Δ
javascript 69.01% <ø> (ø)
unittests 66.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@wesleyboar wesleyboar changed the title feat: fp-1499 serve cms taccsite_ui → cms/ui @ /ui Task/fp 1499 cms pattern library - serve at /ui url Jul 25, 2022
@wesleyboar
Copy link
Member Author

wesleyboar commented Jul 25, 2022 •
edited
Loading

This solution would only let me serve the files locally. The changes here have no effect on remote server.

I will use this to test Nginx syntax and PoC locally. But a new plan is required to serve on a remote server.

Details

S.T.
4 minutes ago
So the nginx file in the core-portal repo is only used locally. Deployed environments use camino

S.T.
4 minutes ago
Extended by core-portal-deployments

S.T.
4 minutes ago
Check out how the user guide is served for frontera prod

S.T.
4 minutes ago
I imagine a similar setup for these staticfiles

W.B.
🧠 4 minutes ago
Ah, okay. Yeah, I started [by emulating] the docs and Core-Portal-Deployments. (edited)

W.B.
🧠 4 minutes ago
I’ll return to that solution. (edited)

S.T.
2 minutes ago
A key part of that solution is that bringing the docs container “up” results in the container placing the staticfiles directly on a mounted volume. This lets nginx see those files

S.T.
2 minutes ago
Alternatively you could use a similar “running” container solution like how certain nginx locations point to either the cms or portal containers

@wesleyboar wesleyboar closed this Jul 25, 2022
@wesleyboar wesleyboar deleted the task/fp-1499-cms-pattern-library--fix-ui-pattern-url branch July 26, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wesleyboar