Skip to content

Commit 8435d56

Browse files
committed
feat: fp-1726 c-tag-list automatic tag styling
1 parent 8510789 commit 8435d56

File tree

11 files changed

+110
-31
lines changed

11 files changed

+110
-31
lines changed

dist/components/bootstrap.pagination.css

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/components/c-page.css

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/components/c-publication-preview.css

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/components/c-tag-list.css

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/lib/_imports/components/c-publication-preview.css

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,8 @@
1717

1818
/* Tags */
1919

20-
.c-tag-list/* ← to overwrite via specificity */.c-pub-item__tags {
20+
.c-publication-preview ul.c-tag-list,
21+
.c-publication-preview ol.c-tag-list {
2122
margin-block-end: var(--buffer);
2223
}
2324

src/lib/_imports/components/c-publication-preview/c-publication-preview.hbs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@
55
{{#each items}}
66
<article class="c-publication-preview">
77
{{#if tags}}
8-
<ul class="c-pub-item__tags c-tag-list">
8+
<ul class="c-tag-list c-tag-list--auto-text">
99
{{#each tags}}
10-
<li><a class="c-tag" href="#">{{this}}</a></li>
10+
<li><a href="#">{{this}}</a></li>
1111
{{/each}}
1212
</ul>
1313
{{/if}}

src/lib/_imports/components/c-tag-list.css

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,20 @@
1212
font-size: var(--global-font-size--small);
1313
}
1414

15-
/* To let nav lists not require `c-tag` on every child */
15+
/* To let lists not require `c-tag` on every child */
16+
ul.c-tag-list--auto-item > li,
17+
ul.c-tag-list--auto-text > li > *,
18+
ul.c-tag-list--auto-link > li > a, /* alias for `c-tag-list--auto-text` */
19+
ol.c-tag-list--auto-item > li,
20+
ol.c-tag-list--auto-text > li > *,
21+
ol.c-tag-list--auto-link > li > a, /* alias for `c-tag-list--auto-text` */
1622
nav.c-tag-list > a {
1723
@extend .c-tag;
1824
}
1925

2026
/* To overwrite browser styles */
21-
ol.c-tag-list,
22-
ul.c-tag-list {
27+
ul.c-tag-list,
28+
ol.c-tag-list {
2329
list-style: none;
2430

2531
padding-inline-start: 0;

src/lib/_imports/components/c-tag-list/c-tag-list--nav.hbs

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<dl>
2-
<dt>Link</dt>
2+
<dt>Link <small>(<code>c-tag</code> class not necessary)</small></dt>
33
<dd>
44
<nav class="c-tag-list">
55
{{#each tags}}
@@ -19,13 +19,5 @@
1919
{{/each}}
2020
</nav>
2121
</dd>
22-
<dt>Nav with Explicit Tag Elements</dt>
23-
<dd>
24-
<nav class="c-tag-list">
25-
{{#each tags}}
26-
<a class="c-tag" href="#">{{this}}</a>
27-
{{/each}}
28-
</nav>
29-
</dd>
3022
</dl>
3123
{{/ @misuse }}

src/lib/_imports/components/c-tag-list/c-tag-list--ol.hbs

Lines changed: 38 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,14 @@
1+
<h2>Manual Tags <small>(add <code>c-tag</code> class to each tag)</small></h2>
12
<dl>
2-
<dt>Default <small>(each list item is a tag)</small></dt>
3+
<dt>Item <small>(no child)</small></dt>
34
<dd>
45
<ol class="c-tag-list">
56
{{#each tags}}
67
<li class="c-tag">{{this}}</li>
78
{{/each}}
89
</ol>
910
</dd>
10-
<dt>Default <small>(each list item child is a tag)</small></dt>
11+
<dt>Text <small>within Item</small></dt>
1112
<dd>
1213
<ol class="c-tag-list">
1314
{{#each tags}}
@@ -17,7 +18,7 @@
1718
{{/each}}
1819
</ol>
1920
</dd>
20-
<dt>Link</dt>
21+
<dt>Link <small>within Item</small></dt>
2122
<dd>
2223
<ol class="c-tag-list">
2324
{{#each tags}}
@@ -29,9 +30,41 @@
2930
</dd>
3031
</dl>
3132

32-
{{#> @misuse }}
33+
<h2>Automatic Tags <small>(add matching <code>auto</code> class to list)</small></h2>
3334
<dl>
34-
<dt>No Explicit Tag Elements</dt>
35+
<dt>Item <small>(no child)</small></dt>
36+
<dd>
37+
<ol class="c-tag-list c-tag-list--auto-item">
38+
{{#each tags}}
39+
<li>{{this}}</li>
40+
{{/each}}
41+
</ol>
42+
</dd>
43+
<dt>Text <small>within Item</small></dt>
44+
<dd>
45+
<ol class="c-tag-list c-tag-list--auto-text">
46+
{{#each tags}}
47+
<li>
48+
<span>{{this}}</span>
49+
</li>
50+
{{/each}}
51+
</ol>
52+
</dd>
53+
<dt>Link <small>within Item</small></dt>
54+
<dd>
55+
<ol class="c-tag-list c-tag-list--auto-link">
56+
{{#each tags}}
57+
<li>
58+
<a class="c-tag" href="#">{{this}}</a>
59+
</li>
60+
{{/each}}
61+
</ol>
62+
</dd>
63+
</dl>
64+
65+
{{#> @misuse }}
66+
<dl>
67+
<dt>No Explicit Tag Elements & No Auto Class</dt>
3568
<dd>
3669
<ol class="c-tag-list">
3770
{{#each tags}}

src/lib/_imports/components/c-tag-list/c-tag-list--ul.hbs

Lines changed: 37 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,14 @@
1+
<h2>Manual Tags <small>(add <code>c-tag</code> class to each tag)</small></h2>
12
<dl>
2-
<dt>Default <small>(each list item is a tag)</small></dt>
3+
<dt>Item <small>(no child)</small></dt>
34
<dd>
45
<ul class="c-tag-list">
56
{{#each tags}}
67
<li class="c-tag">{{this}}</li>
78
{{/each}}
89
</ul>
910
</dd>
10-
<dt>Default <small>(each list item child is a tag)</small></dt>
11+
<dt>Text <small>within Item</small></dt>
1112
<dd>
1213
<ul class="c-tag-list">
1314
{{#each tags}}
@@ -17,7 +18,7 @@
1718
{{/each}}
1819
</ul>
1920
</dd>
20-
<dt>Link</dt>
21+
<dt>Link <small>within Item</small></dt>
2122
<dd>
2223
<ul class="c-tag-list">
2324
{{#each tags}}
@@ -29,9 +30,41 @@
2930
</dd>
3031
</dl>
3132

33+
<h2>Automatic Tags <small>(add matching <code>auto</code> class to list)</small></h2>
34+
<dl>
35+
<dt>Item <small>(no child)</small></dt>
36+
<dd>
37+
<ul class="c-tag-list c-tag-list--auto-item">
38+
{{#each tags}}
39+
<li>{{this}}</li>
40+
{{/each}}
41+
</ul>
42+
</dd>
43+
<dt>Text <small>within Item</small></dt>
44+
<dd>
45+
<ul class="c-tag-list c-tag-list--auto-text">
46+
{{#each tags}}
47+
<li>
48+
<span>{{this}}</span>
49+
</li>
50+
{{/each}}
51+
</ul>
52+
</dd>
53+
<dt>Link <small>within Item</small></dt>
54+
<dd>
55+
<ul class="c-tag-list c-tag-list--auto-link">
56+
{{#each tags}}
57+
<li>
58+
<a class="c-tag" href="#">{{this}}</a>
59+
</li>
60+
{{/each}}
61+
</ul>
62+
</dd>
63+
</dl>
64+
3265
{{#> @misuse }}
3366
<dl>
34-
<dt>No Explicit Tag Elements</dt>
67+
<dt>No Explicit Tag Elements & No Auto Class</dt>
3568
<dd>
3669
<ul class="c-tag-list">
3770
{{#each tags}}

0 commit comments

Comments
 (0)