Skip to content

Commit f67e620

Browse files
author
Joe Stubbs
committed
Fixed issue where the actor's token attribute was not being processed correctly causing tokens to be generated even for actors for which the attribute was false.
1 parent f8aab31 commit f67e620

File tree

2 files changed

+21
-6
lines changed

2 files changed

+21
-6
lines changed

CHANGELOG.md

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,18 @@
11
# Change Log
22
All notable changes to this project will be documented in this file.
33

4+
## 1.5.0 - 2019-09-16 (target 2019-11-01)
5+
### Added
6+
7+
### Changed
8+
- Fixed issue where the actor's token attribute was not being processed correctly causing tokens to be generated even for actors for which the attribute was false.
9+
- Fixed issue where hypyerlinks in response model for executions were not generated correctly, showing the actor's internal database id instead of the human readable id.
10+
11+
12+
### Removed
13+
- No change.
14+
15+
416
## 1.4.0 - 2019-09-16
517
### Added
618
- Added `hints` attribute to the actor data model, a list of strings representing metadata about an actor. "Official"

actors/spawner.py

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -187,12 +187,15 @@ def process(self, cmd):
187187
logger.debug("client generation was configured to be available; now checking the actor's token attr.")
188188
# updated 1.3.0-- check whether the actor requires a token:
189189
if actor.token:
190-
logger.debug("spawner starting client generation")
191-
client_id, \
192-
client_access_token, \
193-
client_refresh_token, \
194-
api_server, \
195-
client_secret = self.client_generation(actor_id, worker_id, tenant)
190+
if type(actor.token) == str and actor.token.lower() == 'false':
191+
logger.debug("actor.token was a string set to false, so not generating a token")
192+
else:
193+
logger.debug("spawner starting client generation")
194+
client_id, \
195+
client_access_token, \
196+
client_refresh_token, \
197+
api_server, \
198+
client_secret = self.client_generation(actor_id, worker_id, tenant)
196199
else:
197200
logger.debug("actor's token attribute was False. Not generating client.")
198201
ch = SpawnerWorkerChannel(worker_id=worker_id)

0 commit comments

Comments
 (0)