Dedup enumerations of Screen.AllScreens w/ safe helper method

fixes 2211a41, 05f06ae, adf7449, and 7a97ab4

Author: YoshiRulz

src/BizHawk.Client.EmuHawk/Extensions/ControlExtensions.cs

@@ -87,8 +87,7 @@ public static DialogResult ShowDialogOnScreen(this Form form)
 			var topLeft = new Point(
 				Math.Max(0, form.Location.X),
 				Math.Max(0, form.Location.Y));
-			var screen = Screen.AllScreens.Select(static s => s.WorkingArea)
-				.FirstOrNull(a => a.Contains(topLeft))
+			var screen = DrawingExtensions.BoundsOfDisplayContaining(topLeft)
 				?? default; //TODO is zeroed the correct fallback value? --yoshi
 			var w = screen.Right - form.Bounds.Right;
 			var h = screen.Bottom - form.Bounds.Bottom;

src/BizHawk.Client.EmuHawk/Extensions/DrawingExtensions.cs

@@ -1,11 +1,21 @@
 #nullable enable
 
 using System.Drawing;
+using System.Linq;
+using System.Windows.Forms;
+
+using BizHawk.Common.CollectionExtensions;
 
 namespace BizHawk.Client.EmuHawk
 {
 	public static class DrawingExtensions
 	{
+#pragma warning disable RCS1224 // don't want extension on nonspecific `Point`
+		public static Rectangle? BoundsOfDisplayContaining(Point p)
+#pragma warning restore RCS1224
+			=> Screen.AllScreens.Select(static scr => scr.WorkingArea)
+				.FirstOrNull(rect => rect.Contains(p));
+
 		public static T GetMutableCopy<T>(this T b)
 			where T : Brush
 			=> (T) b.Clone();

src/BizHawk.Client.EmuHawk/tools/TAStudio/BookmarksBranchesBox.cs

@@ -622,8 +622,9 @@ private void BranchView_PointedCellChanged(object sender, InputRoll.CellEventArg
 					}
 
 					location.Y = Math.Max(0, location.Y);
-					var screen = Screen.AllScreens.First(s => s.WorkingArea.Contains(location));
-					var h = screen.WorkingArea.Bottom - bottom;
+					var screen = DrawingExtensions.BoundsOfDisplayContaining(location)
+						?? default; //TODO is zeroed the correct fallback value? --yoshi
+					var h = screen.Bottom - bottom;
 
 					if (h < 0)
 					{

src/BizHawk.Client.EmuHawk/tools/TAStudio/TAStudio.ListView.cs

@@ -910,12 +910,17 @@ private void TasView_MouseUp(object sender, MouseEventArgs e)
 					var bottomRight = new Point(
 						topLeft.X + RightClickMenu.Width,
 						topLeft.Y + RightClickMenu.Height);
-					var screen = Screen.AllScreens.First(s => s.WorkingArea.Contains(topLeft));
+					var screen = DrawingExtensions.BoundsOfDisplayContaining(topLeft)
+						?? default; //TODO is zeroed the correct fallback value? --yoshi
 					// if we don't fully fit, move to the other side of the pointer
-					if (bottomRight.X > screen.WorkingArea.Right)
+					if (bottomRight.X > screen.Right)
+					{
 						offset.X -= RightClickMenu.Width;
-					if (bottomRight.Y > screen.WorkingArea.Bottom)
+					}
+					if (bottomRight.Y > screen.Bottom)
+					{
 						offset.Y -= RightClickMenu.Height;
+					}
 					topLeft.Offset(offset);
 					// if the screen is insultingly tiny, best we can do is avoid negative pos
 					RightClickMenu.Show(

src/BizHawk.Client.EmuHawk/tools/ToolManager.cs

@@ -447,10 +447,7 @@ public bool IsLoaded(Type toolType)
 			=> _tools.Find(t => t.GetType() == toolType)?.IsActive is true;
 
 		public bool IsOnScreen(Point topLeft)
-		{
-			return Screen.AllScreens.Any(
-				screen => screen.WorkingArea.Contains(topLeft));
-		}
+			=> DrawingExtensions.BoundsOfDisplayContaining(topLeft) is not null;
 
 		/// <summary>
 		/// Returns true if an instance of T exists