Fix turbo logic for invisible emulation.

Author: SuuperW

src/BizHawk.Client.Common/lua/CommonLibs/ClientLuaLibrary.cs

@@ -95,7 +95,7 @@ public string GetLuaEngine()
 			=> "NLua+Lua";
 
 		[LuaMethodExample("client.invisibleemulation( true );")]
-		[LuaMethod("invisibleemulation", "Disables and enables emulator updates")]
+		[LuaMethod("invisibleemulation", "Enters/exits turbo mode and disables/enables most emulator updates.")]
 		public void InvisibleEmulation(bool invisible)
 			=> APIs.EmuClient.InvisibleEmulation(invisible);
 

src/BizHawk.Client.EmuHawk/MainForm.cs

@@ -1101,7 +1101,6 @@ private set
 		public bool FrameInch { get; set; }
 		public bool HoldFrameAdvance { get; set; } // necessary for tastudio > button
 		public bool PressRewind { get; set; } // necessary for tastudio < button
-		public bool FastForward { get; set; }
 
 		/// <summary>
 		/// Disables updates for video/audio, and enters "turbo" mode.
@@ -1147,8 +1146,8 @@ private set
 
 		public bool IsSeeking => PauseOnFrame.HasValue;
 		private bool IsTurboSeeking => PauseOnFrame.HasValue && Config.TurboSeek;
-		public bool IsTurboing => InputManager.ClientControls["Turbo"] || IsTurboSeeking;
-		public bool IsFastForwarding => InputManager.ClientControls["Fast Forward"] || IsTurboing || InvisibleEmulation;
+		public bool IsTurboing => InputManager.ClientControls["Turbo"] || IsTurboSeeking || InvisibleEmulation;
+		public bool IsFastForwarding => InputManager.ClientControls["Fast Forward"] || IsTurboing;
 		public bool IsRewinding { get; private set; }
 
 		/// <summary>
@@ -2177,7 +2176,7 @@ private void SyncThrottle()
 			// method is selected, but the clock throttle determines that by itself and
 			// everything appears normal here.
 			var rewind = Rewinder?.Active == true && (InputManager.ClientControls["Rewind"] || PressRewind);
-			var fastForward = InputManager.ClientControls["Fast Forward"] || FastForward;
+			var fastForward = IsFastForwarding;
 			var turbo = IsTurboing;
 
 			int speedPercent = fastForward ? Config.SpeedPercentAlternate : Config.SpeedPercent;

src/BizHawk.Client.EmuHawk/RetroAchievements/IMainFormForRetroAchievements.cs

@@ -9,8 +9,6 @@ public interface IMainFormForRetroAchievements : IMainFormForTools
 
 		bool FrameInch { get; set; }
 
-		bool FastForward { get; }
-
 		GameInfo Game { get; }
 
 		IMovieSession MovieSession { get; }

src/BizHawk.Client.EmuHawk/RetroAchievements/RetroAchievements.Hardcore.cs

@@ -91,7 +91,7 @@ protected void CheckHardcoreModeConditions()
 			_inputManager.ClientControls.Overrides(_hardcoreHotkeyOverrides);
 			_mainForm.FrameInch = false;
 
-			var fastForward = _inputManager.ClientControls["Fast Forward"] || _mainForm.FastForward;
+			var fastForward = _mainForm.IsFastForwarding;
 			var speedPercent = fastForward ? _getConfig().SpeedPercentAlternate : _getConfig().SpeedPercent;
 			if (speedPercent < 100)
 			{