Pass this (tool) to RecentFiles.HandleLoadError instead of MainForm

Author: YoshiRulz

src/BizHawk.Client.EmuHawk/Extensions/ToolExtensions.cs

@@ -210,13 +210,20 @@ public static ToolStripItem[] RecentMenu(
 			return items.ToArray();
 		}
 
-		public static void HandleLoadError(this RecentFiles recent, IMainFormForTools mainForm, string path, string encodedPath = null)
+		public static void HandleLoadError(
+			this RecentFiles recent,
+			IDialogParent dialogParent,
+			string path,
+			string encodedPath = null)
 		{
-			mainForm.DoWithTempMute(() =>
+			dialogParent.DialogController.DoWithTempMute(() =>
 			{
 				if (recent.Frozen)
 				{
-					mainForm.ShowMessageBox($"Could not open {path}", "File not found", EMsgBoxIcon.Error);
+					dialogParent.ModalMessageBox(
+						caption: "File not found",
+						icon: EMsgBoxIcon.Error,
+						text: $"Could not open {path}");
 				}
 				else
 				{

src/BizHawk.Client.EmuHawk/tools/BasicBot/BasicBot.cs

@@ -562,7 +562,7 @@ private void LoadFileFromRecent(string path)
 			var result = LoadBotFile(path);
 			if (!result && !File.Exists(path))
 			{
-				Settings.RecentBotFiles.HandleLoadError(MainForm, path);
+				Settings.RecentBotFiles.HandleLoadError(this, path: path);
 			}
 		}
 

src/BizHawk.Client.EmuHawk/tools/Cheats/Cheats.cs

@@ -104,7 +104,7 @@ private void LoadFileFromRecent(string path)
 				var loadResult = MainForm.CheatList.Load(Core, path, append: false);
 				if (!loadResult)
 				{
-					Config.Cheats.Recent.HandleLoadError(MainForm, path);
+					Config.Cheats.Recent.HandleLoadError(this, path: path);
 				}
 				else
 				{

src/BizHawk.Client.EmuHawk/tools/HexEditor/HexEditor.cs

@@ -1330,7 +1330,7 @@ public void LoadFileFromRecent(string path)
 			var result = LoadTable(path);
 			if (!result)
 			{
-				RecentTables.HandleLoadError(MainForm, path);
+				RecentTables.HandleLoadError(this, path: path);
 			}
 			else
 			{

src/BizHawk.Client.EmuHawk/tools/Lua/LuaConsole.cs

@@ -709,7 +709,7 @@ private void LoadSessionFromRecent(string path)
 			{
 				if (!LoadLuaSession(path))
 				{
-					Config.RecentLuaSession.HandleLoadError(MainForm, path);
+					Config.RecentLuaSession.HandleLoadError(this, path: path);
 				}
 			}
 		}

src/BizHawk.Client.EmuHawk/tools/TAStudio/TAStudio.cs

@@ -694,7 +694,7 @@ private bool LoadFileWithFallback(string path)
 
 			if (!File.Exists(path))
 			{
-				Settings.RecentTas.HandleLoadError(MainForm, path);
+				Settings.RecentTas.HandleLoadError(this, path: path);
 			}
 			else
 			{

src/BizHawk.Client.EmuHawk/tools/Watch/RamSearch.cs

@@ -571,7 +571,7 @@ private void LoadFileFromRecent(string path)
 
 			if (!file.Exists)
 			{
-				Settings.RecentSearches.HandleLoadError(MainForm, path);
+				Settings.RecentSearches.HandleLoadError(this, path: path);
 			}
 			else
 			{

src/BizHawk.Client.EmuHawk/tools/Watch/RamWatch.cs

@@ -243,7 +243,7 @@ public void LoadFileFromRecent(string path)
 				var loadResult = _watches.Load(path, append: false);
 				if (!loadResult)
 				{
-					Config.RecentWatches.HandleLoadError(MainForm, path);
+					Config.RecentWatches.HandleLoadError(this, path: path);
 				}
 				else
 				{