Avoid parsing .xml bundles twice (resolves #4277)

Author: YoshiRulz

src/BizHawk.Client.Common/RomLoader.cs

@@ -120,6 +120,7 @@ private object GetCoreSyncSettings(Type t, Type syncSettingsType)
 		public GameInfo Game { get; private set; }
 		public RomGame Rom { get; private set; }
 		public string CanonicalFullPath { get; private set; }
+		public XmlGame XMLGameInfo = null;
 
 		public bool Deterministic { get; set; }
 
@@ -682,14 +683,22 @@ private static bool IsDiscForXML(string system, string path)
 			return Disc.IsValidExtension(ext);
 		}
 
-		private bool LoadXML(string path, CoreComm nextComm, HawkFile file, string forcedCoreName, out IEmulator nextEmulator, out RomGame rom, out GameInfo game)
+		private bool LoadXML(
+			string path,
+			CoreComm nextComm,
+			HawkFile file,
+			string forcedCoreName,
+			out IEmulator nextEmulator,
+			out RomGame rom,
+			out GameInfo game,
+			out XmlGame xmlGame)
 		{
 			nextEmulator = null;
 			rom = null;
 			game = null;
 			try
 			{
-				var xmlGame = XmlGame.Create(file); // if load fails, are we supposed to retry as a bsnes XML????????
+				xmlGame = XmlGame.Create(file); // if load fails, are we supposed to retry as a bsnes XML????????
 				game = xmlGame.GI;
 
 				var system = game.System;
@@ -725,6 +734,7 @@ private bool LoadXML(string path, CoreComm nextComm, HawkFile file, string force
 			}
 			catch (Exception ex)
 			{
+				xmlGame = null;
 				try
 				{
 					// need to get rid of this hack at some point
@@ -886,8 +896,18 @@ public bool LoadRom(string path, CoreComm nextComm, string launchLibretroCore, s
 							LoadM3U(path, nextComm, file, forcedCoreName, out nextEmulator, out game);
 							break;
 						case ".xml":
-							if (!LoadXML(path, nextComm, file, forcedCoreName, out nextEmulator, out rom, out game))
+							if (!LoadXML(
+								path,
+								nextComm,
+								file,
+								forcedCoreName,
+								out nextEmulator,
+								out rom,
+								out game,
+								out XMLGameInfo))
+							{
 								return false;
+							}
 							break;
 						case ".psf":
 						case ".minipsf":

src/BizHawk.Client.EmuHawk/MainForm.cs

@@ -3856,13 +3856,10 @@ private bool LoadRomInternal(string path, LoadRomArgs args, out bool failureIsFr
 					InputManager.SyncControls(Emulator, MovieSession, Config);
 					_multiDiskMode = false;
 
-					if (oaOpenrom is not null && ".xml".EqualsIgnoreCase(Path.GetExtension(oaOpenrom.Path.Replace("|", "")))
-						&& Emulator is not LibsnesCore)
+					if (loader.XMLGameInfo is XmlGame xmlGame && Emulator is not LibsnesCore)
 					{
 						// this is a multi-disk bundler file
 						// determine the xml assets and create RomStatusDetails for all of them
-						var xmlGame = XmlGame.Create(new HawkFile(oaOpenrom.Path));
-
 						using var xSw = new StringWriter();
 
 						for (int xg = 0; xg < xmlGame.Assets.Count; xg++)