WaitForExit instead of arbitrarily sleeping in DownloaderForm

YoshiRulz · YoshiRulz · commit 86c969195b1a · 2025-08-29T05:08:24.000+10:00
diff --git a/src/BizHawk.Client.EmuHawk/DownloaderForm.cs b/src/BizHawk.Client.EmuHawk/DownloaderForm.cs
@@ -106,8 +106,9 @@ private void Download()
 					fs.Dispose();
 					if (OSTailoredCode.IsUnixHost)
 					{
-						OSTailoredCode.ConstructSubshell("chmod", $"+x {DownloadTo}", checkStdout: false).Start();
-						Thread.Sleep(50); // Linux I/O flush idk
+						var proc = OSTailoredCode.ConstructSubshell("chmod", $"+x {DownloadTo}", checkStdout: false);
+						proc.Start();
+						proc.WaitForExit();
 					}
 				}
 

Original file line number	Diff line number	Diff line change
`@@ -106,8 +106,9 @@ private void Download()`
`106`	`106`	`fs.Dispose();`
`107`	`107`	`if (OSTailoredCode.IsUnixHost)`
`108`	`108`	`{`
`109`		`- OSTailoredCode.ConstructSubshell("chmod", $"+x {DownloadTo}", checkStdout: false).Start();`
`110`		`- Thread.Sleep(50); // Linux I/O flush idk`
	`109`	`+ var proc = OSTailoredCode.ConstructSubshell("chmod", $"+x {DownloadTo}", checkStdout: false);`
	`110`	`+ proc.Start();`
	`111`	`+ proc.WaitForExit();`
`111`	`112`	`}`
`112`	`113`	`}`
`113`	`114`