Include undo history form refreshing with TAStudio's refresh logic. Fix a bug that could cause an invalid scroll in undo history form.

Author: SuuperW

src/BizHawk.Client.Common/movie/tasproj/TasMovie.History.cs

@@ -8,7 +8,6 @@ public interface IMovieChangeLog
 	{
 		List<string> Names { get; }
 		int UndoIndex { get; }
-		string NextUndoStepName { get; }
 		/// <summary>
 		/// Gets or sets a value indicating whether the movie is recording action history.
 		/// This is not intended to turn off the ChangeLog, but to disable the normal recording process.
@@ -226,19 +225,6 @@ public void Redo()
 		public bool CanUndo => UndoIndex > -1;
 		public bool CanRedo => UndoIndex < _history.Count - 1;
 
-		public string NextUndoStepName
-		{
-			get
-			{
-				if (Names.Count == 0 || UndoIndex < 0)
-				{
-					return null;
-				}
-
-				return Names[UndoIndex];
-			}
-		}
-
 		private void AddMovieAction(string name)
 		{
 			if (UndoIndex + 1 != _history.Count)

src/BizHawk.Client.EmuHawk/tools/TAStudio/TAStudio.ListView.cs

@@ -853,11 +853,18 @@ public bool FrameEdited(int frame)
 					RefreshDialog();
 					return true;
 				}
-				else if (TasView.RowCount != CurrentTasMovie.InputLogLength + 1)
+				else
 				{
-					// Row count must always be kept up to date even if last row is not directly visible.
-					TasView.RowCount = CurrentTasMovie.InputLogLength + 1;
-					return true;
+					if (_undoForm != null && !_undoForm.IsDisposed)
+					{
+						_undoForm.UpdateValues();
+					}
+					if (TasView.RowCount != CurrentTasMovie.InputLogLength + 1)
+					{
+						// Row count must always be kept up to date even if last row is not directly visible.
+						TasView.RowCount = CurrentTasMovie.InputLogLength + 1;
+						return true;
+					}
 				}
 			}
 

src/BizHawk.Client.EmuHawk/tools/TAStudio/UndoHistoryForm.cs

@@ -10,7 +10,7 @@ public partial class UndoHistoryForm : Form
 		private const string UndoColumnName = "Undo Step";
 
 		private readonly TAStudio _tastudio;
-		private string _lastUndoAction;
+		private int _lastUndoAction;
 		private IMovieChangeLog Log => _tastudio.CurrentTasMovie.ChangeLog;
 
 		public UndoHistoryForm(TAStudio owner)
@@ -50,14 +50,14 @@ private void HistoryView_QueryItemBkColor(int index, RollColumn column, ref Colo
 		public void UpdateValues()
 		{
 			HistoryView.RowCount = Log.Names.Count;
-			if (AutoScrollCheck.Checked && _lastUndoAction != Log.NextUndoStepName)
+			if (AutoScrollCheck.Checked && _lastUndoAction != Log.UndoIndex)
 			{
-				HistoryView.ScrollToIndex(Log.UndoIndex);
+				HistoryView.ScrollToIndex(Math.Max(Log.UndoIndex, 0));
 				HistoryView.DeselectAll();
 				HistoryView.SelectRow(Log.UndoIndex - 1, true);
 			}
 
-			_lastUndoAction = Log.NextUndoStepName;
+			_lastUndoAction = Log.UndoIndex;
 
 			HistoryView.Refresh();
 		}