Remove redundant .AsSpan()

Author: YoshiRulz

src/BizHawk.Common/Extensions/CollectionExtensions.cs

@@ -291,7 +291,7 @@ public static T[] ConcatArrays<T>(/*params*/ IReadOnlyCollection<T[]> arrays)
 			var i = 0;
 			foreach (var arr in arrays)
 			{
-				arr.AsSpan().CopyTo(combined.AsSpan(start: i));
+				arr.CopyTo(combined.AsSpan(start: i));
 				i += arr.Length;
 			}
 			return combined;

src/BizHawk.Emulation.Common/N3DSHasher.cs

@@ -123,11 +123,11 @@ private void GetNCCHNormalKeys(ReadOnlySpan<byte> primaryKeyYRaw, byte secondary
 			Array.Reverse(primaryKeyYBytes); // convert big endian to little endian
 			var primaryKeyY = new BigInteger(primaryKeyYBytes);
 
-			Derive3DSNormalKey(primaryKeyX, primaryKeyY).AsSpan().CopyTo(primaryKey);
+			Derive3DSNormalKey(primaryKeyX, primaryKeyY).CopyTo(primaryKey);
 
 			if (programIdBytes.IsEmpty)
 			{
-				Derive3DSNormalKey(secondaryKeyX, primaryKeyY).AsSpan().CopyTo(secondaryKey);
+				Derive3DSNormalKey(secondaryKeyX, primaryKeyY).CopyTo(secondaryKey);
 				return;
 			}
 
@@ -162,7 +162,7 @@ private void GetNCCHNormalKeys(ReadOnlySpan<byte> primaryKeyYRaw, byte secondary
 				Buffer.BlockCopy(sha256Digest, 0, secondaryKeyYBytes, 1, 16);
 				Array.Reverse(secondaryKeyYBytes); // convert big endian to little endian
 				var secondaryKeyY = new BigInteger(secondaryKeyYBytes);
-				Derive3DSNormalKey(secondaryKeyX, secondaryKeyY).AsSpan().CopyTo(secondaryKey);
+				Derive3DSNormalKey(secondaryKeyX, secondaryKeyY).CopyTo(secondaryKey);
 				return;
 			}
 

src/BizHawk.Emulation.Cores/Computers/Commodore64/Media/DiskTrack.cs

@@ -55,7 +55,7 @@ public sealed class DiskTrack
 	public DiskTrack Clone()
 	{
 		var clone = new DiskTrack();
-		Bits.CopyTo(clone._bits.AsSpan());
+		Bits.CopyTo(clone._bits);
 		clone._original = _original;
 		return clone;
 	}

src/BizHawk.Emulation.DiscSystem/DiscHasher.cs

@@ -197,7 +197,7 @@ public string OldHash()
 
 				if (byteswapped)
 				{
-					EndiannessUtils.MutatingByteSwap16(buf2352.AsSpan());
+					EndiannessUtils.MutatingByteSwap16(buf2352);
 				}
 
 				buffer.AddRange(new ArraySegment<byte>(buf2352, bootOff, Math.Min(2352 - bootOff, bootLen)));
@@ -209,7 +209,7 @@ public string OldHash()
 
 					if (byteswapped)
 					{
-						EndiannessUtils.MutatingByteSwap16(buf2352.AsSpan());
+						EndiannessUtils.MutatingByteSwap16(buf2352);
 					}
 
 					buffer.AddRange(new ArraySegment<byte>(buf2352, 0, Math.Min(2352, bootLen)));