Refactor IMainFormForRetroAchievements

Author: YoshiRulz

src/BizHawk.Client.EmuHawk/IMainFormForTools.cs

@@ -12,7 +12,7 @@ public interface IMainFormForTools : IDialogController
 		/// <remarks>referenced by 3 or more tools</remarks>
 		string CurrentlyOpenRom { get; }
 
-		/// <remarks>only referenced from <see cref="HexEditor"/></remarks>
+		/// <remarks>referenced from <see cref="HexEditor"/> and RetroAchievements</remarks>
 		LoadRomArgs CurrentlyOpenRomArgs { get; }
 
 		/// <remarks>only referenced from <see cref="TAStudio"/></remarks>
@@ -54,7 +54,7 @@ public interface IMainFormForTools : IDialogController
 		/// <remarks>only referenced from <see cref="BasicBot"/></remarks>
 		bool LoadQuickSave(int slot, bool suppressOSD = false);
 
-		/// <remarks>only referenced from <see cref="MultiDiskBundler"/></remarks>
+		/// <remarks>referenced from <see cref="MultiDiskBundler"/> and RetroAchievements</remarks>
 		bool LoadRom(string path, LoadRomArgs args);
 
 		/// <remarks>only referenced from <see cref="BookmarksBranchesBox"/></remarks>
@@ -96,7 +96,7 @@ public interface IMainFormForTools : IDialogController
 		/// <remarks>only referenced from <see cref="BookmarksBranchesBox"/></remarks>
 		void UpdateStatusSlots();
 
-		/// <remarks>only referenced from <see cref="TAStudio"/></remarks>
+		/// <remarks>referenced from <see cref="TAStudio"/> and RetroAchievements</remarks>
 		void UpdateWindowTitle();
 	}
 }

src/BizHawk.Client.EmuHawk/RetroAchievements/IMainFormForRetroAchievements.cs

@@ -3,20 +3,16 @@
 
 namespace BizHawk.Client.EmuHawk
 {
-	public interface IMainFormForRetroAchievements
+	public interface IMainFormForRetroAchievements : IMainFormForTools
 	{
-		LoadRomArgs CurrentlyOpenRomArgs { get; }
-
 		IEmulator Emulator { get; }
 
 		bool FrameInch { get; set; }
 
-		bool FastForward { get; set; }
+		bool FastForward { get; }
 
 		GameInfo Game { get; }
 
-		CheatCollection CheatList { get; }
-
 		IMovieSession MovieSession { get; }
 
 		FirmwareManager FirmwareManager { get; }
@@ -25,14 +21,6 @@ public interface IMainFormForRetroAchievements
 
 		SettingsAdapter GetSettingsAdapterForLoadedCoreUntyped();
 
-		bool LoadRom(string path, LoadRomArgs args);
-
-		void PauseEmulator();
-
 		bool RebootCore();
-
-		void UpdateWindowTitle();
-
-		void UnpauseEmulator();
 	}
 }