Some misc. cleanups to project files and assembly metadata

Author: YoshiRulz

Common.props

@@ -12,20 +12,20 @@
 		<ContinuousIntegrationBuild Condition=" '$(GITLAB_CI)' != '' Or '$(APPVEYOR)' != '' ">true</ContinuousIntegrationBuild>
 		<DebugSymbols>true</DebugSymbols>
 		<DebugType>portable</DebugType>
-		<DefineConstants>$(DefineConstants);TRACE</DefineConstants>
 		<EnableNETAnalyzers>true</EnableNETAnalyzers>
 		<ErrorReport>prompt</ErrorReport>
 		<Features>strict</Features>
 		<IsTargetingNetFramework>$(TargetFramework.StartsWith("net4"))</IsTargetingNetFramework>
 		<GenerateDocumentationFile>true</GenerateDocumentationFile> <!-- it would be nice to rename these to *.api_reference.xml or something, but it seems https://github.com/dotnet/standard/issues/614 was never fixed -->
 		<LangVersion>12.0</LangVersion>
 		<ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
-		<NoWarn>$(NoWarn);CS1591;SA0001</NoWarn>
+		<NoWarn>$(NoWarn);CS1591</NoWarn> <!-- CS1591 wants doc comments on every type/member, which is a recipe for useless generated or blank comments -->
 		<Nullable>enable</Nullable>
 		<PlatformTarget>AnyCPU</PlatformTarget>
+		<ReportAnalyzer>true</ReportAnalyzer>
+		<WarningLevel>$(AnalysisLevel)</WarningLevel>
 	</PropertyGroup>
 	<PropertyGroup Condition=" '$(Configuration)' == 'Debug' ">
-		<DefineConstants>$(DefineConstants);DEBUG</DefineConstants>
 		<Optimize>false</Optimize>
 	</PropertyGroup>
 	<PropertyGroup Condition=" '$(Configuration)' == 'Release' ">

src/BizHawk.Client.Common/AssemblyInfo.cs

@@ -18,6 +18,7 @@
 		<ProjectReference Include="$(ProjectDir)../BizHawk.Bizware.Graphics/BizHawk.Bizware.Graphics.csproj" />
 		<ProjectReference Include="$(ProjectDir)../BizHawk.Bizware.Input/BizHawk.Bizware.Input.csproj" />
 		<EmbeddedResource Include="Resources/**/*" />
+		<InternalsVisibleTo Include="BizHawk.Tests" />
 	</ItemGroup>
 	<ItemGroup>
 		<Compile Update="movie/bk2/Bk2Movie.HeaderApi.cs" DependentUpon="Bk2Movie.cs" />

src/BizHawk.Client.Common/BizHawk.Client.Common.csproj

@@ -1,8 +1,6 @@
 using System.IO;
 using System.Reflection;
 
-[assembly: Parallelize(Scope = ExecutionScope.MethodLevel)]
-
 namespace BizHawk.Tests
 {
 	public static class EmbeddedData

src/BizHawk.Tests/EmbeddedData.cs

@@ -0,0 +1 @@
+[assembly: Parallelize(Scope = ExecutionScope.MethodLevel)]