Use the marker list collection changed event to drive TAStudio refreshing, instead of doing a manual refresh on undo and everywhere else.

Is this actually any better? Another option for undo purposes could be to have Undo/Redo return true/false indicating if the only change was to markers.

Author: SuuperW

src/BizHawk.Client.EmuHawk/tools/Lua/Libraries/TAStudioLuaLibrary.cs

@@ -474,7 +474,6 @@ public void RemoveMarker(int frame)
 				if (marker != null)
 				{
 					Tastudio.CurrentTasMovie.Markers.Remove(marker);
-					Tastudio.RefreshDialog();
 				}
 			}
 		}
@@ -494,7 +493,6 @@ public void SetMarker(int frame, string message = null)
 				else
 				{
 					Tastudio.CurrentTasMovie.Markers.Add(frame, message1);
-					Tastudio.RefreshDialog();
 				}
 			}
 		}

src/BizHawk.Client.EmuHawk/tools/TAStudio/MarkerControl.cs

@@ -157,7 +157,6 @@ private void RemoveMarkerToolStripMenuItem_Click(object sender, EventArgs e)
 			if (!MarkerView.AnyRowsSelected) return;
 			foreach (var i in MarkerView.SelectedRows.Select(index => Markers[index]).ToList()) Markers.Remove(i);
 			MarkerView.RowCount = Markers.Count;
-			Tastudio.RefreshDialog();
 		}
 
 		public void UpdateMarkerCount()
@@ -193,7 +192,6 @@ public void AddMarker(int frame, bool editText = false)
 			Markers.Add(marker);
 			var index = Markers.IndexOf(marker);
 			MarkerView.MakeIndexVisible(index);
-			Tastudio.RefreshDialog();
 		}
 
 		public void UpdateTextColumnWidth()
@@ -251,7 +249,6 @@ public void EditMarkerFramePopUp(TasMovieMarker marker)
 			Markers.Move(marker.Frame, promptValue);
 			UpdateTextColumnWidth();
 			UpdateValues();
-			Tastudio.RefreshDialog();
 		}
 
 		public void UpdateValues()

src/BizHawk.Client.EmuHawk/tools/TAStudio/TAStudio.ListView.cs

@@ -377,7 +377,6 @@ private void TasView_ColumnClick(object sender, InputRoll.ColumnClickEventArgs e
 				if (columnName == FrameColumnName)
 				{
 					CurrentTasMovie.Markers.Add(TasView.SelectionEndIndex!.Value, "");
-					RefreshDialog();
 				}
 				else if (columnName != CursorColumnName)
 				{

src/BizHawk.Client.EmuHawk/tools/TAStudio/TAStudio.MenuItems.cs

@@ -285,13 +285,11 @@ private void EditSubMenu_DropDownOpened(object sender, EventArgs e)
 		private void UndoMenuItem_Click(object sender, EventArgs e)
 		{
 			CurrentTasMovie.ChangeLog.Undo();
-			RefreshDialog(); // ?? redundant, except if undoing markers
 		}
 
 		private void RedoMenuItem_Click(object sender, EventArgs e)
 		{
 			CurrentTasMovie.ChangeLog.Redo();
-			RefreshDialog(); // ?? redundant, except if undoing markers
 		}
 
 		private void ShowUndoHistoryMenuItem_Click(object sender, EventArgs e)
@@ -607,7 +605,6 @@ private void RemoveMarkersMenuItem_Click(object sender, EventArgs e)
 		{
 			CurrentTasMovie.Markers.RemoveAll(m => TasView.IsRowSelected(m.Frame));
 			MarkerControl.UpdateMarkerCount();
-			RefreshDialog();
 		}
 
 		private void ClearGreenzoneMenuItem_Click(object sender, EventArgs e)

src/BizHawk.Client.EmuHawk/tools/TAStudio/TAStudio.cs

@@ -590,7 +590,15 @@ private bool StartNewMovieWrapper(ITasMovie movie, bool isNew)
 			movie.BindMarkersToInput = Settings.BindMarkersToInput;
 			movie.GreenzoneInvalidated = (f) => _ = FrameEdited(f);
 			movie.ChangeLog.MaxSteps = Settings.MaxUndoSteps;
+
 			movie.PropertyChanged += TasMovie_OnPropertyChanged;
+			System.Collections.Specialized.NotifyCollectionChangedEventHandler refreshOnMarker = (_, _) => RefreshDialog();
+			movie.Markers.CollectionChanged += refreshOnMarker;
+			this.Disposed += (s, e) =>
+			{
+				movie.PropertyChanged -= TasMovie_OnPropertyChanged;
+				movie.Markers.CollectionChanged -= refreshOnMarker;
+			};
 
 			SuspendLayout();
 			WantsToControlStopMovie = false;
@@ -1059,7 +1067,7 @@ private void TasView_CellDropped(object sender, InputRoll.CellEventArgs e)
 			if (e.NewCell?.RowIndex != null && !CurrentTasMovie.Markers.IsMarker(e.NewCell.RowIndex.Value))
 			{
 				CurrentTasMovie.Markers.Move(e.OldCell.RowIndex.Value, e.NewCell.RowIndex.Value);
-				RefreshDialog();
+				RefreshDialog(); // Marker move might have been rejected so we need to manually refresh.
 			}
 		}
 

src/BizHawk.Client.EmuHawk/tools/TAStudio/UndoHistoryForm.cs

@@ -71,13 +71,11 @@ private void ClearButton_Click(object sender, EventArgs e)
 		private void UndoButton_Click(object sender, EventArgs e)
 		{
 			_tastudio.UndoExternal();
-			_tastudio.RefreshDialog();
 		}
 
 		private void RedoButton_Click(object sender, EventArgs e)
 		{
 			_tastudio.RedoExternal();
-			_tastudio.RefreshDialog();
 		}
 
 		private int SelectedItem
@@ -94,9 +92,6 @@ private void UndoToHere(int index)
 			});
 
 			UpdateValues();
-
-			// potentially redundant refresh
-			_tastudio.RefreshDialog();
 		}
 
 		private void HistoryView_DoubleClick(object sender, EventArgs e)
@@ -143,9 +138,6 @@ private void RedoHereMenuItem_Click(object sender, EventArgs e)
 			});
 
 			UpdateValues();
-
-			// potentially redundant refresh
-			_tastudio.RefreshDialog();
 		}
 
 		private void ClearHistoryToHereMenuItem_Click(object sender, EventArgs e)