Update dependency MinVer to v6 - autoclosed #33
Annotations
12 warnings
|
Analyze (csharp)
Unexpected input(s) 'include-prerelease', valid inputs are ['dotnet-version', 'dotnet-quality', 'global-json-file', 'source-url', 'owner', 'config-file', 'cache', 'cache-dependency-path']
|
|
Analyze (csharp):
src/TBC.OpenAPI.SDK.ExchangeRates/ExchangeRatesClient.cs#L110
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
|
|
Analyze (csharp):
src/TBC.OpenAPI.SDK.ExchangeRates/Helpers/ParametersValidationHelper.cs#L10
Unused field 'CURRENCY_LIST_PATTERN' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1823)
|
|
Analyze (csharp):
src/TBC.OpenAPI.SDK.ExchangeRates/Interfaces/IExchangeRatesClient.cs#L12
In virtual/interface member IExchangeRatesClient.ConvertOfficialRates(decimal, string, string, CancellationToken), rename parameter to so that it no longer conflicts with the reserved language keyword 'To'. Using a reserved keyword as the name of a parameter on a virtual/interface member makes it harder for consumers in other languages to override/implement the member. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1716)
|
|
Analyze (csharp):
src/TBC.OpenAPI.SDK.ExchangeRates/Interfaces/IExchangeRatesClient.cs#L11
In virtual/interface member IExchangeRatesClient.GetOfficialRatesByDate(IEnumerable<string>, string, CancellationToken), rename parameter date so that it no longer conflicts with the reserved language keyword 'Date'. Using a reserved keyword as the name of a parameter on a virtual/interface member makes it harder for consumers in other languages to override/implement the member. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1716)
|
|
Analyze (csharp):
src/TBC.OpenAPI.SDK.ExchangeRates/Interfaces/IExchangeRatesClient.cs#L9
In virtual/interface member IExchangeRatesClient.ConvertCommercialRate(decimal, string, string, CancellationToken), rename parameter to so that it no longer conflicts with the reserved language keyword 'To'. Using a reserved keyword as the name of a parameter on a virtual/interface member makes it harder for consumers in other languages to override/implement the member. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1716)
|
|
Analyze (csharp):
src/TBC.OpenAPI.SDK.ExchangeRates/Extensions/FactoryExtensions.cs#L19
In externally visible method 'IExchangeRatesClient FactoryExtensions.GetExchangeRatesClient(OpenApiClientFactory factory)', validate parameter 'factory' is non-null before using it. If appropriate, throw an 'ArgumentNullException' when the argument is 'null'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1062)
|
|
Analyze (csharp):
src/TBC.OpenAPI.SDK.ExchangeRates/Extensions/FactoryExtensions.cs#L15
In externally visible method 'OpenApiClientFactoryBuilder FactoryExtensions.AddExchangeRatesClient(OpenApiClientFactoryBuilder builder, ExchangeRatesClientOptions options, Action<HttpClient> configureClient = null, Func<HttpClientHandler> configureHttpMessageHandler = null)', validate parameter 'builder' is non-null before using it. If appropriate, throw an 'ArgumentNullException' when the argument is 'null'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1062)
|
|
Analyze (csharp):
src/TBC.OpenAPI.SDK.ExchangeRates/Models/GetCommercialRatesResponse.cs#L16
Change 'List<CommercialRate>' in 'GetCommercialRatesResponse.CommercialRatesList' to use 'Collection<T>', 'ReadOnlyCollection<T>' or 'KeyedCollection<K,V>' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1002)
|
|
Analyze (csharp):
src/TBC.OpenAPI.SDK.ExchangeRates/Models/GetCommercialRatesResponse.cs#L16
Change 'CommercialRatesList' to be read-only by removing the property setter (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2227)
|
|
Analyze (csharp):
src/TBC.OpenAPI.SDK.ExchangeRates/ExchangeRatesClient.cs#L110
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
|
|
Analyze (csharp)
Unexpected input(s) 'include-prerelease', valid inputs are ['dotnet-version', 'dotnet-quality', 'global-json-file', 'source-url', 'owner', 'config-file', 'cache', 'cache-dependency-path']
|