Remove search delay

TBM13 · TBM13 · commit be6a06369e6c · 2025-07-14T23:40:02.000-03:00
diff --git a/Flow.Launcher.Infrastructure/UserSettings/PluginSettings.cs b/Flow.Launcher.Infrastructure/UserSettings/PluginSettings.cs
@@ -29,7 +29,6 @@ public void UpdatePluginSettings(List<PluginMetadata> metadatas)
                         settings.Version = metadata.Version;
                     }
                     settings.DefaultActionKeywords = metadata.ActionKeywords; // metadata provides default values
-                    settings.DefaultSearchDelayTime = metadata.SearchDelayTime; // metadata provides default values
 
                     // update metadata values with settings
                     if (settings.ActionKeywords?.Count > 0)
@@ -44,7 +43,6 @@ public void UpdatePluginSettings(List<PluginMetadata> metadatas)
                     }
                     metadata.Disabled = settings.Disabled;
                     metadata.Priority = settings.Priority;
-                    metadata.SearchDelayTime = settings.SearchDelayTime;
                     metadata.HomeDisabled = settings.HomeDisabled;
                 }
                 else
@@ -59,9 +57,7 @@ public void UpdatePluginSettings(List<PluginMetadata> metadatas)
                         ActionKeywords = metadata.ActionKeywords, // use default value
                         Disabled = metadata.Disabled,
                         HomeDisabled = metadata.HomeDisabled,
-                        Priority = metadata.Priority,
-                        DefaultSearchDelayTime = metadata.SearchDelayTime, // metadata provides default values
-                        SearchDelayTime = metadata.SearchDelayTime, // use default value
+                        Priority = metadata.Priority
                     };
                 }
             }
@@ -99,11 +95,6 @@ public class Plugin
 
         public int Priority { get; set; }
 
-        [JsonIgnore]
-        public int? DefaultSearchDelayTime { get; set; }
-
-        public int? SearchDelayTime { get; set; }
-
         /// <summary>
         /// Used only to save the state of the plugin in settings
         /// </summary>
diff --git a/Flow.Launcher.Infrastructure/UserSettings/Settings.cs b/Flow.Launcher.Infrastructure/UserSettings/Settings.cs
@@ -340,8 +340,6 @@ public bool ShowAtTopmost
             }
         }
 
-        public bool SearchQueryResultsWithDelay { get; set; }
-        public int SearchDelayTime { get; set; } = 150;
 
         [JsonConverter(typeof(JsonStringEnumConverter))]
         public SearchWindowScreens SearchWindowScreen { get; set; } = SearchWindowScreens.Cursor;
diff --git a/Flow.Launcher.Plugin/PluginMetadata.cs b/Flow.Launcher.Plugin/PluginMetadata.cs
@@ -103,15 +103,10 @@ internal set
         /// </summary>
         public bool HideActionKeywordPanel { get; set; }
 
-        /// <summary>
-        /// Plugin search delay time in ms. Null means use default search delay time.
-        /// </summary>
-        public int? SearchDelayTime { get; set; } = null;
-
         /// <summary>
         /// Plugin icon path.
         /// </summary>
-        public string IcoPath { get; set;}
+        public string IcoPath { get; set; }
 
         /// <summary>
         /// Plugin priority.
diff --git a/Flow.Launcher/Languages/en.xaml b/Flow.Launcher/Languages/en.xaml
@@ -105,11 +105,6 @@
     <system:String x:Key="ShouldUsePinyinToolTip">Allows using Pinyin to search. Pinyin is the standard system of romanized spelling for translating Chinese.</system:String>
     <system:String x:Key="AlwaysPreview">Always Preview</system:String>
     <system:String x:Key="AlwaysPreviewToolTip">Always open preview panel when Flow activates. Press {0} to toggle preview.</system:String>
-    <system:String x:Key="searchDelay">Search Delay</system:String>
-    <system:String x:Key="searchDelayToolTip">Adds a short delay while typing to reduce UI flicker and result load. Recommended if your typing speed is average.</system:String>
-    <system:String x:Key="searchDelayNumberBoxToolTip">Enter the wait time (in ms) until input is considered complete. This can only be edited if Search Delay is enabled.</system:String>
-    <system:String x:Key="searchDelayTime">Default Search Delay Time</system:String>
-    <system:String x:Key="searchDelayTimeToolTip">Wait time before showing results after typing stops. Higher values wait longer. (ms)</system:String>
     <system:String x:Key="homePage">Home Page</system:String>
     <system:String x:Key="homePageToolTip">Show home page results when query text is empty.</system:String>
     <system:String x:Key="homeToggleBoxToolTip">This can only be edited if plugin supports Home feature and Home Page is enabled.</system:String>
@@ -131,12 +126,9 @@
     <system:String x:Key="currentActionKeywords">Current action keyword</system:String>
     <system:String x:Key="newActionKeyword">New action keyword</system:String>
     <system:String x:Key="actionKeywordsTooltip">Change Action Keywords</system:String>
-    <system:String x:Key="pluginSearchDelayTime">Plugin search delay time</system:String>
-    <system:String x:Key="pluginSearchDelayTimeTooltip">Change Plugin Search Delay Time</system:String>
     <system:String x:Key="FilterComboboxLabel">Advanced Settings:</system:String>
     <system:String x:Key="DisplayModeOnOff">Enabled</system:String>
     <system:String x:Key="DisplayModePriority">Priority</system:String>
-    <system:String x:Key="DisplayModeSearchDelay">Search Delay</system:String>
     <system:String x:Key="DisplayModeHomeOnOff">Home Page</system:String>
     <system:String x:Key="currentPriority">Current Priority</system:String>
     <system:String x:Key="newPriority">New Priority</system:String>
@@ -322,11 +314,7 @@
     <system:String x:Key="failedToCopy">Failed to copy</system:String>
     <system:String x:Key="actionkeyword_tips">Enter the action keywords you like to use to start the plugin and use whitespace to divide them. Use * if you don't want to specify any, and the plugin will be triggered without any action keywords.</system:String>
 
-    <!--  Search Delay Settings Dialog  -->
-    <system:String x:Key="searchDelayTimeTitle">Search Delay Time Setting</system:String>
-    <system:String x:Key="searchDelayTimeTips">Input the search delay time in ms you like to use for the plugin. Input empty if you don't want to specify any, and the plugin will use default search delay time.</system:String>
-
-    <!--  Search Delay Settings Dialog  -->
+    <!--  Home Page  -->
     <system:String x:Key="homeTitle">Home Page</system:String>
     <system:String x:Key="homeTips">Enable the plugin home page state if you like to show the plugin results when query is empty.</system:String>
 
diff --git a/Flow.Launcher/MainWindow.xaml.cs b/Flow.Launcher/MainWindow.xaml.cs
@@ -958,13 +958,13 @@ private void SetupResizeMode()
 
         #endregion
 
-        #region Search Delay
+        #region Search
 
         private void QueryTextBox_TextChanged1(object sender, TextChangedEventArgs e)
         {
             var textBox = (TextBox)sender;
             _viewModel.QueryText = textBox.Text;
-            _viewModel.Query(_settings.SearchQueryResultsWithDelay);
+            _viewModel.Query(false);
         }
 
         #endregion
diff --git a/Flow.Launcher/Resources/Controls/InstalledPluginDisplay.xaml b/Flow.Launcher/Resources/Controls/InstalledPluginDisplay.xaml
@@ -75,34 +75,7 @@
                                 Value="{Binding Priority, Mode=TwoWay}" />
                         </StackPanel>
 
-                        <StackPanel
-                            x:Name="SearchDelayControl"
-                            VerticalAlignment="Center"
-                            Orientation="Horizontal"
-                            Visibility="{Binding DataContext.IsSearchDelaySelected, RelativeSource={RelativeSource AncestorType=ListBox}, Converter={StaticResource BooleanToVisibilityConverter}}">
-                            <TextBlock
-                                Margin="0 0 8 0"
-                                VerticalAlignment="Center"
-                                FontSize="13"
-                                Foreground="{DynamicResource Color08B}"
-                                Text="{DynamicResource searchDelay}"
-                                ToolTip="{DynamicResource searchDelayToolTip}" />
-                            <ui:NumberBox
-                                Width="120"
-                                Margin="0 0 8 0"
-                                IsEnabled="{Binding SearchDelayEnabled}"
-                                Maximum="1000"
-                                Minimum="0"
-                                PlaceholderText="{Binding DefaultSearchDelay}"
-                                SmallChange="10"
-                                SpinButtonPlacementMode="Compact"
-                                ToolTip="{DynamicResource searchDelayNumberBoxToolTip}"
-                                ToolTipService.InitialShowDelay="0"
-                                ToolTipService.ShowOnDisabled="True"
-                                Value="{Binding PluginSearchDelayTime, Mode=TwoWay}" />
-                        </StackPanel>
-
-                        <!--  Put OnOffControl after PriorityControl & SearchDelayControl so that it can display correctly  -->
+                        <!--  Put OnOffControl after PriorityControl so that it can display correctly  -->
                         <ui:ToggleSwitch
                             x:Name="HomeOnOffControl"
                             Margin="0 0 8 0"
diff --git a/Flow.Launcher/SettingPages/ViewModels/SettingsPaneGeneralViewModel.cs b/Flow.Launcher/SettingPages/ViewModels/SettingsPaneGeneralViewModel.cs
@@ -1,10 +1,7 @@
-﻿using System;
-using System.Collections.Generic;
-using System.Linq;
+﻿using System.Collections.Generic;
 using System.Windows.Forms;
 using CommunityToolkit.Mvvm.Input;
 using Flow.Launcher.Core.Resource;
-using Flow.Launcher.Infrastructure;
 using Flow.Launcher.Infrastructure.UserSettings;
 using Flow.Launcher.Plugin;
 using Flow.Launcher.Plugin.SharedModels;
@@ -56,19 +53,6 @@ public List<int> ScreenNumbers
     public List<LastQueryModeData> LastQueryModes { get; } =
         DropdownDataGeneric<LastQueryMode>.GetValues<LastQueryModeData>("LastQuery");
 
-    public int SearchDelayTimeValue
-    {
-        get => Settings.SearchDelayTime;
-        set
-        {
-            if (Settings.SearchDelayTime != value)
-            {
-                Settings.SearchDelayTime = value;
-                OnPropertyChanged();
-            }
-        }
-    }
-
     private void UpdateEnumDropdownLocalizations()
     {
         DropdownDataGeneric<SearchWindowScreens>.UpdateLabels(SearchWindowScreens);
diff --git a/Flow.Launcher/SettingPages/ViewModels/SettingsPanePluginsViewModel.cs b/Flow.Launcher/SettingPages/ViewModels/SettingsPanePluginsViewModel.cs
@@ -1,8 +1,8 @@
 ﻿using System.Collections.Generic;
 using System.Linq;
 using System.Threading.Tasks;
-using System.Windows.Controls;
 using System.Windows;
+using System.Windows.Controls;
 using CommunityToolkit.Mvvm.Input;
 using Flow.Launcher.Core.Plugin;
 using Flow.Launcher.Infrastructure.UserSettings;
@@ -66,20 +66,6 @@ public bool IsPrioritySelected
         }
     }
 
-    private bool _isSearchDelaySelected;
-    public bool IsSearchDelaySelected
-    {
-        get => _isSearchDelaySelected;
-        set
-        {
-            if (_isSearchDelaySelected != value)
-            {
-                _isSearchDelaySelected = value;
-                OnPropertyChanged();
-            }
-        }
-    }
-
     private bool _isHomeOnOffSelected;
     public bool IsHomeOnOffSelected
     {
@@ -156,18 +142,6 @@ private async Task OpenHelperAsync(Button button)
                         TextWrapping = TextWrapping.Wrap
                     },
                     new TextBlock
-                    {
-                        Text = (string)Application.Current.Resources["searchDelay"],
-                        FontSize = 18,
-                        Margin = new Thickness(0, 24, 0, 10),
-                        TextWrapping = TextWrapping.Wrap
-                    },
-                    new TextBlock
-                    {
-                        Text = (string)Application.Current.Resources["searchDelayTimeTips"],
-                        TextWrapping = TextWrapping.Wrap
-                    },
-                    new TextBlock
                     {
                         Text = (string)Application.Current.Resources["homeTitle"],
                         FontSize = 18,
@@ -201,25 +175,16 @@ private void UpdateDisplayModeFromSelection()
             case DisplayMode.Priority:
                 IsOnOffSelected = false;
                 IsPrioritySelected = true;
-                IsSearchDelaySelected = false;
-                IsHomeOnOffSelected = false;
-                break;
-            case DisplayMode.SearchDelay:
-                IsOnOffSelected = false;
-                IsPrioritySelected = false;
-                IsSearchDelaySelected = true;
                 IsHomeOnOffSelected = false;
                 break;
             case DisplayMode.HomeOnOff:
                 IsOnOffSelected = false;
                 IsPrioritySelected = false;
-                IsSearchDelaySelected = false;
                 IsHomeOnOffSelected = true;
                 break;
             default:
                 IsOnOffSelected = true;
                 IsPrioritySelected = false;
-                IsSearchDelaySelected = false;
                 IsHomeOnOffSelected = false;
                 break;
         }
@@ -230,6 +195,5 @@ public enum DisplayMode
 {
     OnOff,
     Priority,
-    SearchDelay,
     HomeOnOff
 }
diff --git a/Flow.Launcher/SettingPages/Views/SettingsPaneGeneral.xaml b/Flow.Launcher/SettingPages/Views/SettingsPaneGeneral.xaml
@@ -185,33 +185,6 @@
                 </cc:Card>
             </cc:CardGroup>
 
-            <cc:ExCard
-                Title="{DynamicResource searchDelay}"
-                Margin="0 14 0 0"
-                Icon="&#xE961;"
-                Sub="{DynamicResource searchDelayToolTip}">
-                <cc:ExCard.SideContent>
-                    <ui:ToggleSwitch
-                        IsOn="{Binding Settings.SearchQueryResultsWithDelay}"
-                        OffContent="{DynamicResource disable}"
-                        OnContent="{DynamicResource enable}" />
-                </cc:ExCard.SideContent>
-                <cc:Card
-                    Title="{DynamicResource searchDelayTime}"
-                    Sub="{DynamicResource searchDelayTimeToolTip}"
-                    Type="InsideFit">
-                    <ui:NumberBox
-                        Width="120"
-                        Margin="0 0 0 0"
-                        Maximum="1000"
-                        Minimum="0"
-                        SmallChange="10"
-                        SpinButtonPlacementMode="Compact"
-                        ValidationMode="InvalidInputOverwritten"
-                        Value="{Binding SearchDelayTimeValue}" />
-                </cc:Card>
-            </cc:ExCard>
-
             <cc:Card
                 Title="{DynamicResource homePage}"
                 Margin="0 14 0 0"
diff --git a/Flow.Launcher/ViewModel/MainViewModel.cs b/Flow.Launcher/ViewModel/MainViewModel.cs
@@ -1217,15 +1217,6 @@ async Task QueryTaskAsync(PluginPair plugin, CancellationToken token)
             {
                 App.API.LogDebug(ClassName, $"Wait for querying plugin <{plugin.Metadata.Name}>");
 
-                if (searchDelay && !currentIsHomeQuery) // Do not delay for home query
-                {
-                    var searchDelayTime = plugin.Metadata.SearchDelayTime ?? Settings.SearchDelayTime;
-
-                    await Task.Delay(searchDelayTime, token);
-
-                    if (token.IsCancellationRequested) return;
-                }
-
                 // Since it is wrapped within a ThreadPool Thread, the synchronous context is null
                 // Task.Yield will force it to run in ThreadPool
                 await Task.Yield();
diff --git a/Flow.Launcher/ViewModel/PluginViewModel.cs b/Flow.Launcher/ViewModel/PluginViewModel.cs
@@ -91,26 +91,6 @@ public int Priority
             }
         }
 
-        public double PluginSearchDelayTime
-        {
-            get => PluginPair.Metadata.SearchDelayTime == null ?
-                double.NaN :
-                PluginPair.Metadata.SearchDelayTime.Value;
-            set
-            {
-                if (double.IsNaN(value))
-                {
-                    PluginPair.Metadata.SearchDelayTime = null;
-                    PluginSettingsObject.SearchDelayTime = null;
-                }
-                else
-                {
-                    PluginPair.Metadata.SearchDelayTime = (int)value;
-                    PluginSettingsObject.SearchDelayTime = (int)value;
-                }
-            }
-        }
-
         private Control _settingControl;
         private bool _isExpanded;
 
@@ -142,12 +122,7 @@ public Control SettingControl
             App.API.GetTranslation("plugin_query_time") + " " +
             PluginPair.Metadata.AvgQueryTime + "ms";
         public string ActionKeywordsText => string.Join(Query.ActionKeywordSeparator, PluginPair.Metadata.ActionKeywords);
-        public string SearchDelayTimeText => PluginPair.Metadata.SearchDelayTime == null ?
-            App.API.GetTranslation("default") :
-            App.API.GetTranslation($"SearchDelayTime{PluginPair.Metadata.SearchDelayTime}");
         public Infrastructure.UserSettings.Plugin PluginSettingsObject { get; init; }
-        public bool SearchDelayEnabled => Settings.SearchQueryResultsWithDelay;
-        public string DefaultSearchDelay => Settings.SearchDelayTime.ToString();
         public bool HomeEnabled => Settings.ShowHomePage && PluginManager.IsHomePlugin(PluginPair.Metadata.ID);
 
         public void OnActionKeywordsTextChanged()

Original file line number	Diff line number	Diff line change
`@@ -340,8 +340,6 @@ public bool ShowAtTopmost`
`340`	`340`	`}`
`341`	`341`	`}`
`342`	`342`
`343`		`- public bool SearchQueryResultsWithDelay { get; set; }`
`344`		`- public int SearchDelayTime { get; set; } = 150;`
`345`	`343`
`346`	`344`	`[JsonConverter(typeof(JsonStringEnumConverter))]`
`347`	`345`	`public SearchWindowScreens SearchWindowScreen { get; set; } = SearchWindowScreens.Cursor;`
Original file line number	Diff line number	Diff line change
`@@ -958,13 +958,13 @@ private void SetupResizeMode()`
`958`	`958`
`959`	`959`	`#endregion`
`960`	`960`
`961`		`- #region Search Delay`
	`961`	`+ #region Search`
`962`	`962`
`963`	`963`	`private void QueryTextBox_TextChanged1(object sender, TextChangedEventArgs e)`
`964`	`964`	`{`
`965`	`965`	`var textBox = (TextBox)sender;`
`966`	`966`	`_viewModel.QueryText = textBox.Text;`
`967`		`- _viewModel.Query(_settings.SearchQueryResultsWithDelay);`
	`967`	`+ _viewModel.Query(false);`
`968`	`968`	`}`
`969`	`969`
`970`	`970`	`#endregion`