Fix RLE Compression

Author: BinaryConstruct

.github/workflows/codeql.yml.disabled

@@ -69,7 +69,7 @@ jobs:
       shell: pwsh
       run: |
         dotnet restore .\src
-        dotnet build .\src\TEdit.sln /p:EnableWindowsTargeting=true /p:Configuration=Release
+        dotnet build .\src\TEdit.slnx /p:EnableWindowsTargeting=true /p:Configuration=Release
 
     # ℹ️ Command-line programs to run using the OS shell.
     # 📚 See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsrun

.github/workflows/dotnet-desktop.yml

@@ -31,4 +31,4 @@ jobs:
         shell: pwsh
         run: |
           dotnet restore .\src
-          dotnet build .\src\TEdit.sln /p:EnableWindowsTargeting=true /p:Configuration=Release
+          dotnet build .\src\TEdit.slnx /p:EnableWindowsTargeting=true /p:Configuration=Release

.gitignore

@@ -53,3 +53,5 @@ build/
 /publish/
 /publish-avalonia/
 .idea/
+nul
+.claude

src/TEdit.Terraria/Tile.cs

@@ -1,10 +1,11 @@
 using System;
+using System.Collections.Generic;
 using TEdit.Configuration;
 using TEdit.Geometry;
 
 namespace TEdit.Terraria;
 
-public class Tile
+public class Tile : IEquatable<Tile>
 {
     public static readonly Tile Empty = new Tile();
 
@@ -62,6 +63,75 @@ public object Clone()
         return MemberwiseClone();
     }
 
+    public override bool Equals(object obj)
+    {
+        return Equals(obj as Tile);
+    }
+
+    /// <summary>
+    /// Compares serialized tile properties. Ignores [NonSerialized] cache fields.
+    /// </summary>
+    public bool Equals(Tile other)
+    {
+        return other is not null &&
+               IsActive == other.IsActive &&
+               Type == other.Type &&
+               U == other.U &&
+               V == other.V &&
+               TileColor == other.TileColor &&
+               Wall == other.Wall &&
+               WallColor == other.WallColor &&
+               LiquidAmount == other.LiquidAmount &&
+               LiquidType == other.LiquidType &&
+               WireRed == other.WireRed &&
+               WireGreen == other.WireGreen &&
+               WireBlue == other.WireBlue &&
+               WireYellow == other.WireYellow &&
+               BrickStyle == other.BrickStyle &&
+               Actuator == other.Actuator &&
+               InActive == other.InActive &&
+               InvisibleBlock == other.InvisibleBlock &&
+               InvisibleWall == other.InvisibleWall &&
+               FullBrightBlock == other.FullBrightBlock &&
+               FullBrightWall == other.FullBrightWall;
+    }
+
+    public override int GetHashCode()
+    {
+        int hashCode = -1661845228;
+        hashCode = hashCode * -1521134295 + IsActive.GetHashCode();
+        hashCode = hashCode * -1521134295 + Type.GetHashCode();
+        hashCode = hashCode * -1521134295 + U.GetHashCode();
+        hashCode = hashCode * -1521134295 + V.GetHashCode();
+        hashCode = hashCode * -1521134295 + TileColor.GetHashCode();
+        hashCode = hashCode * -1521134295 + Wall.GetHashCode();
+        hashCode = hashCode * -1521134295 + WallColor.GetHashCode();
+        hashCode = hashCode * -1521134295 + LiquidAmount.GetHashCode();
+        hashCode = hashCode * -1521134295 + LiquidType.GetHashCode();
+        hashCode = hashCode * -1521134295 + WireRed.GetHashCode();
+        hashCode = hashCode * -1521134295 + WireGreen.GetHashCode();
+        hashCode = hashCode * -1521134295 + WireBlue.GetHashCode();
+        hashCode = hashCode * -1521134295 + WireYellow.GetHashCode();
+        hashCode = hashCode * -1521134295 + BrickStyle.GetHashCode();
+        hashCode = hashCode * -1521134295 + Actuator.GetHashCode();
+        hashCode = hashCode * -1521134295 + InActive.GetHashCode();
+        hashCode = hashCode * -1521134295 + InvisibleBlock.GetHashCode();
+        hashCode = hashCode * -1521134295 + InvisibleWall.GetHashCode();
+        hashCode = hashCode * -1521134295 + FullBrightBlock.GetHashCode();
+        hashCode = hashCode * -1521134295 + FullBrightWall.GetHashCode();
+        return hashCode;
+    }
+
+    public static bool operator ==(Tile left, Tile right)
+    {
+        return EqualityComparer<Tile>.Default.Equals(left, right);
+    }
+
+    public static bool operator !=(Tile left, Tile right)
+    {
+        return !(left == right);
+    }
+
     // Added legacy enums back
     public enum WallType : int
     {

src/TEdit.Tests/Terraria/WorldTests.cs

@@ -296,4 +296,61 @@ public void SaveWorldV2_144x_Test(string fileName)
         // essentially, just a save and load test
         var w2 = World.LoadWorld(saveTest);
     }
+
+    [Theory]
+    [InlineData(".\\WorldFiles\\v1.4.4.1.wld")]
+    [InlineData(".\\WorldFiles\\v1.4.4.2.wld")]
+    [InlineData(".\\WorldFiles\\v1.4.4.3.wld")]
+    [InlineData(".\\WorldFiles\\v1.4.4.4.wld")]
+    [InlineData(".\\WorldFiles\\console.wld")]
+    public void SaveWorld_RLE_Compression_Test(string fileName)
+    {
+        var fileInfo = new FileInfo(fileName);
+        if (fileInfo.Length < 1_000_000)
+        {
+            // Skip files < 1MB (likely broken LFS links or stub files)
+            return;
+        }
+
+        var originalSize = fileInfo.Length;
+
+        var (world, errors) = World.LoadWorld(fileName);
+        var saveTest = fileName + ".rle.test";
+        World.Save(world, saveTest, incrementRevision: false);
+
+        var savedSize = new FileInfo(saveTest).Length;
+        double sizeRatio = (double)savedSize / originalSize;
+
+        // Clean up test file
+        if (File.Exists(saveTest))
+        {
+            File.Delete(saveTest);
+        }
+
+        // Saved file should not be significantly larger (5% tolerance for metadata)
+        Assert.True(sizeRatio <= 1.05,
+            $"File grew from {originalSize:N0} to {savedSize:N0} bytes ({sizeRatio:P1}). " +
+            $"RLE compression may not be working.");
+    }
+
+    [Fact]
+    public void Tile_Equals_Test()
+    {
+        var tile1 = new Tile { IsActive = true, Type = 1, Wall = 5 };
+        var tile2 = (Tile)tile1.Clone();
+
+        // Cloned tiles should be equal
+        Assert.True(tile1.Equals(tile2));
+        Assert.True(tile1 == tile2);
+        Assert.Equal(tile1.GetHashCode(), tile2.GetHashCode());
+
+        // Different cache values should not affect comparison
+        tile2.uvTileCache = 999;
+        Assert.True(tile1.Equals(tile2));
+
+        // Different serialized property should not be equal
+        tile2.Type = 2;
+        Assert.False(tile1.Equals(tile2));
+        Assert.False(tile1 == tile2);
+    }
 }

src/TEdit.sln

@@ -0,0 +1,25 @@
+<Solution>
+  <Folder Name="/Solution Items/">
+    <File Path="../.editorconfig" />
+    <File Path="../build.ps1" />
+  </Folder>
+  <Project Path="SettingsFileUpdater/SettingsFileUpdater.csproj">
+    <Platform Solution="Debug|*" Project="x86" />
+    <Build Project="false" />
+  </Project>
+  <Project Path="TEdit.Common/TEdit.Common.csproj" />
+  <Project Path="TEdit.Configuration.Tests/TEdit.Configuration.Tests.csproj" />
+  <Project Path="TEdit.Configuration/TEdit.Configuration.csproj" />
+  <Project Path="TEdit.Editor/TEdit.Editor.csproj" />
+  <Project Path="TEdit.Terraria/TEdit.Terraria.csproj" />
+  <Project Path="TEdit.Tests/TEdit.Tests.csproj" />
+  <Project Path="TEdit/TEdit.csproj" />
+  <Project Path="TEdit5/TEdit5.csproj" />
+  <Properties Name="ExtensibilityGlobals" Scope="PostLoad">
+    <Property Name="RESX_PrefixTranslations" Value="False" />
+    <Property Name="RESX_SortFileContentOnSave" Value="True" />
+  </Properties>
+  <Properties Name="TestCaseManagementSettings" Scope="PostLoad">
+    <Property Name="CategoryFile" Value="TEdit.vsmdi" />
+  </Properties>
+</Solution>