Add rector

Author: samuelwei

.github/workflows/ci.yml

@@ -100,6 +100,15 @@ jobs:
         run: php artisan migrate --no-interaction -vvv --force
       - name: Execute code style check via Laravel Pint
         run: vendor/bin/pint --test -v
+      - name: Rector Cache
+        uses: actions/cache@v4
+        with:
+          path: /tmp/rector
+          key: ${{ runner.os }}-rector-${{ github.run_id }}
+          restore-keys: ${{ runner.os }}-rector-
+      - run: mkdir -p /tmp/rector
+      - name: Rector Dry Run
+        run: vendor/bin/rector process --dry-run
       - name: Execute tests (Unit and Feature tests) via PHPUnit
         if: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork }}
         env:

app/Auth/ExternalUser.php

@@ -214,7 +214,7 @@ private function isRuleFulfilled($values, mixed $rule): bool
 
         // Loop through all values and try to match the regex and save the result
         foreach ($values as $value) {
-            $matches[] = preg_match($rule->regex, $value);
+            $matches[] = preg_match($rule->regex, (string) $value);
         }
 
         // Check if regex has to (not) match with all array entries

app/Auth/LDAP/LDAPController.php

@@ -57,7 +57,7 @@ public function login(Request $request)
         try {
             // Run login method from AuthenticatesUsers trait
             return $this->ldapLogin($request);
-        } catch (MissingAttributeException $e) {
+        } catch (MissingAttributeException) {
             // If an attribute is missing during the login process, return error
             return abort(500, __('auth.error.missing_attributes'));
         }

app/Auth/LDAP/LDAPProvider.php

@@ -40,6 +40,7 @@ public function __construct(Hasher $hasher, $model)
      * @param  mixed  $identifier
      * @return \Illuminate\Contracts\Auth\Authenticatable|null
      */
+    #[\Override]
     public function retrieveById($identifier)
     {
         return $this->eloquent->retrieveById($identifier);
@@ -52,6 +53,7 @@ public function retrieveById($identifier)
      * @param  string  $token
      * @return \Illuminate\Contracts\Auth\Authenticatable|null
      */
+    #[\Override]
     public function retrieveByToken($identifier, $token)
     {
         return $this->eloquent->retrieveByToken($identifier, $token);
@@ -63,11 +65,13 @@ public function retrieveByToken($identifier, $token)
      * @param  string  $token
      * @return void
      */
+    #[\Override]
     public function updateRememberToken(Authenticatable $user, $token)
     {
         $this->eloquent->updateRememberToken($user, $token);
     }
 
+    #[\Override]
     public function rehashPasswordIfRequired(Authenticatable $user, array $credentials, bool $force = false): void
     {
         $this->eloquent->rehashPasswordIfRequired($user, $credentials, $force);
@@ -78,6 +82,7 @@ public function rehashPasswordIfRequired(Authenticatable $user, array $credentia
      *
      * @return \Illuminate\Contracts\Auth\Authenticatable|null
      */
+    #[\Override]
     public function retrieveByCredentials(array $credentials)
     {
         // Find ldap user by username
@@ -102,6 +107,7 @@ public function retrieveByCredentials(array $credentials)
      *
      * @return bool
      */
+    #[\Override]
     public function validateCredentials(Authenticatable $user, array $credentials)
     {
         // Bind to LDAP with user credentials

app/Auth/LDAP/LDAPUser.php

@@ -25,7 +25,7 @@ public function __construct(LDAPUserObject $ldap_user)
             foreach ($raw_attributes as $attribute_name => $attribute_values) {
                 // If the current LDAP attribute matches the name of the LDAP attribute in the mapping
                 // add all values to the attribute of the user
-                if (strcasecmp($ldap_attribute, $attribute_name) == 0) {
+                if (strcasecmp((string) $ldap_attribute, $attribute_name) == 0) {
                     foreach ($attribute_values as $value) {
                         $this->addAttributeValue($attribute, $value);
                     }

app/Auth/LDAP/LDAPUserObject.php

@@ -10,6 +10,7 @@ class LDAPUserObject extends Model
     /**
      * The "booting" method of the model.
      */
+    #[\Override]
     protected static function boot(): void
     {
         parent::boot();
@@ -27,6 +28,7 @@ public function __construct(array $attributes = [])
     /**
      * Get a new query for builder filtered by the current models object classes.
      */
+    #[\Override]
     public function newQuery(): Builder
     {
         $query = $this->registerModelScopes(

app/Auth/Local/LocalProvider.php

@@ -12,6 +12,7 @@ class LocalProvider extends EloquentUserProvider implements UserProvider
      *
      * @return \Illuminate\Contracts\Auth\Authenticatable|null
      */
+    #[\Override]
     public function retrieveByCredentials(array $credentials)
     {
         $email = $credentials['email'] ?? null;

app/Auth/Shibboleth/ShibbolethController.php

@@ -45,9 +45,9 @@ public function callback(Request $request)
     {
         try {
             $user = $this->provider->login($request);
-        } catch (MissingAttributeException $e) {
+        } catch (MissingAttributeException) {
             return redirect('/external_login?error=missing_attributes');
-        } catch (ShibbolethSessionDuplicateException $e) {
+        } catch (ShibbolethSessionDuplicateException) {
             // Prevented login attempt with duplicate shibboleth session, redirect to logout to kill SP session
             return redirect($this->provider->logout(url('/external_login?error=shibboleth_session_duplicate_exception')));
         }

app/Auth/Shibboleth/ShibbolethProvider.php

@@ -134,6 +134,6 @@ public function login(Request $request)
 
     public function hashShibbolethSessionId($shibbolethSessionId)
     {
-        return hash('sha256', $shibbolethSessionId);
+        return hash('sha256', (string) $shibbolethSessionId);
     }
 }

app/Auth/Shibboleth/ShibbolethServiceProvider.php

@@ -10,10 +10,9 @@ class ShibbolethServiceProvider extends ServiceProvider
     /**
      * Register the Shibboleth provider.
      */
+    #[\Override]
     public function register(): void
     {
-        $this->app->singleton(ShibbolethProvider::class, function (Application $app) {
-            return new ShibbolethProvider;
-        });
+        $this->app->singleton(fn (Application $app): \App\Auth\Shibboleth\ShibbolethProvider => new ShibbolethProvider);
     }
 }