Skip to content

Commit 4f66fbb

Browse files
authored
sync from internal (#1229)
1 parent 77c4e08 commit 4f66fbb

File tree

2 files changed

+13
-6
lines changed

2 files changed

+13
-6
lines changed

slime/rollout/sglang_rollout.py

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -279,7 +279,9 @@ async def generate_and_rm_group(
279279
if getattr(args, "sglang_enable_deterministic_inference", False):
280280
seed = state.group_sampling_seeds[idx]
281281
current_sampling_params["sampling_seed"] = seed
282-
tasks.append(generate_and_rm(args, sample, current_sampling_params, evaluation=evaluation))
282+
tasks.append(
283+
asyncio.create_task(generate_and_rm(args, sample, current_sampling_params, evaluation=evaluation))
284+
)
283285

284286
group = await asyncio.gather(*tasks)
285287

@@ -529,11 +531,13 @@ async def eval_rollout_single_dataset(
529531
sampling_params = base_sampling_params.copy()
530532
sampling_params["sampling_seed"] = args.rollout_seed + j
531533
tasks.append(
532-
generate_and_rm(
533-
args,
534-
sample,
535-
sampling_params=sampling_params,
536-
evaluation=True,
534+
asyncio.create_task(
535+
generate_and_rm(
536+
args,
537+
sample,
538+
sampling_params=sampling_params,
539+
evaluation=True,
540+
)
537541
)
538542
)
539543

slime/utils/eval_config.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,9 @@ class EvalDatasetConfig:
111111
top_p: float | None = None
112112
top_k: int | None = None
113113
max_response_len: int | None = None
114+
stop: list[str] | None = None
115+
stop_token_ids: list[int] | None = None
116+
min_new_tokens: int | None = None
114117

115118
metadata_overrides: dict[str, Any] = field(default_factory=dict)
116119

0 commit comments

Comments
 (0)