Skip to content

Commit 0fabf36

Browse files
LuciferYangSumedh Wale
authored andcommitted
[SPARK-37693][TESTS] Fix ChildProcAppHandleSuite failed in Jenkins maven test
### What changes were proposed in this pull request? After SPARK-6035 merged, there are some test failed in Jenkins maven test like [spark-master-test-maven-hadoop-3.2/3522](https://amplab.cs.berkeley.edu/jenkins/job/spark-master-test-maven-hadoop-3.2/3522/#showFailuresLink) , this pr fixed maven configuration to pass the failed tests. ### Why are the changes needed? Fix Jenkins maven test. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? - Pass the Jenkins or GitHub Action - Manual test run `mvn clean install -pl launcher -am` **Before** ``` [ERROR] Tests run: 11, Failures: 3, Errors: 0, Skipped: 0, Time elapsed: 0.522 s <<< FAILURE! - in org.apache.spark.launcher.ChildProcAppHandleSuite [ERROR] org.apache.spark.launcher.ChildProcAppHandleSuite.testRedirectOutputToLog Time elapsed: 0.207 s <<< FAILURE! java.lang.AssertionError at org.apache.spark.launcher.ChildProcAppHandleSuite.testRedirectOutputToLog(ChildProcAppHandleSuite.java:146) [ERROR] org.apache.spark.launcher.ChildProcAppHandleSuite.testRedirectErrorToLog Time elapsed: 0.032 s <<< FAILURE! java.lang.AssertionError at org.apache.spark.launcher.ChildProcAppHandleSuite.testRedirectErrorToLog(ChildProcAppHandleSuite.java:130) [ERROR] org.apache.spark.launcher.ChildProcAppHandleSuite.testRedirectToLog Time elapsed: 0.016 s <<< FAILURE! java.lang.AssertionError at org.apache.spark.launcher.ChildProcAppHandleSuite.testRedirectToLog(ChildProcAppHandleSuite.java:114) [INFO] Running org.apache.spark.launcher.SparkSubmitOptionParserSuite [INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.193 s - in org.apache.spark.launcher.SparkSubmitOptionParserSuite [INFO] Running org.apache.spark.launcher.CommandBuilderUtilsSuite [INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.005 s - in org.apache.spark.launcher.CommandBuilderUtilsSuite [INFO] Running org.apache.spark.launcher.InProcessLauncherSuite [INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.032 s - in org.apache.spark.launcher.InProcessLauncherSuite [INFO] Running org.apache.spark.launcher.SparkSubmitCommandBuilderSuite [INFO] Tests run: 17, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.036 s - in org.apache.spark.launcher.SparkSubmitCommandBuilderSuite [INFO] Running org.apache.spark.launcher.LauncherServerSuite [INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.018 s - in org.apache.spark.launcher.LauncherServerSuite [DEBUG] Closing the fork 1 after saying GoodBye. [INFO] [INFO] Results: [INFO] [ERROR] Failures: [ERROR] ChildProcAppHandleSuite.testRedirectErrorToLog:130 [ERROR] ChildProcAppHandleSuite.testRedirectOutputToLog:146 [ERROR] ChildProcAppHandleSuite.testRedirectToLog:114 [INFO] [ERROR] Tests run: 46, Failures: 3, Errors: 0, Skipped: 0 ``` **After** ``` [INFO] Running org.apache.spark.launcher.ChildProcAppHandleSuite [INFO] Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.68 s - in org.apache.spark.launcher.ChildProcAppHandleSuite [INFO] Running org.apache.spark.launcher.SparkSubmitOptionParserSuite [INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.19 s - in org.apache.spark.launcher.SparkSubmitOptionParserSuite [INFO] Running org.apache.spark.launcher.CommandBuilderUtilsSuite [INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 s - in org.apache.spark.launcher.CommandBuilderUtilsSuite [INFO] Running org.apache.spark.launcher.InProcessLauncherSuite [INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.034 s - in org.apache.spark.launcher.InProcessLauncherSuite [INFO] Running org.apache.spark.launcher.SparkSubmitCommandBuilderSuite [INFO] Tests run: 17, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.034 s - in org.apache.spark.launcher.SparkSubmitCommandBuilderSuite [INFO] Running org.apache.spark.launcher.LauncherServerSuite [INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.022 s - in org.apache.spark.launcher.LauncherServerSuite [INFO] [INFO] Results: [INFO] [INFO] Tests run: 46, Failures: 0, Errors: 0, Skipped: 0 ``` Closes apache#34958 from LuciferYang/SPARK-37693. Authored-by: yangjie01 <[email protected]> Signed-off-by: Liang-Chi Hsieh <[email protected]>
1 parent fd4e964 commit 0fabf36

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

pom.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2151,7 +2151,7 @@
21512151
<JAVA_HOME>${test.java.home}</JAVA_HOME>
21522152
</environmentVariables>
21532153
<systemProperties>
2154-
<log4j.configuration>file:src/test/resources/log4j.properties</log4j.configuration>
2154+
<log4j.configurationFile>file:src/test/resources/log4j2.properties</log4j.configurationFile>
21552155
<derby.system.durability>test</derby.system.durability>
21562156
<java.awt.headless>true</java.awt.headless>
21572157
<java.io.tmpdir>${project.build.directory}/tmp</java.io.tmpdir>
@@ -2201,7 +2201,7 @@
22012201
<JAVA_HOME>${test.java.home}</JAVA_HOME>
22022202
</environmentVariables>
22032203
<systemProperties>
2204-
<log4j.configuration>file:src/test/resources/log4j.properties</log4j.configuration>
2204+
<log4j.configurationFile>file:src/test/resources/log4j2.properties</log4j.configurationFile>
22052205
<derby.system.durability>test</derby.system.durability>
22062206
<java.awt.headless>true</java.awt.headless>
22072207
<java.io.tmpdir>${project.build.directory}/tmp</java.io.tmpdir>
@@ -2554,7 +2554,7 @@
25542554
</goals>
25552555
<configuration>
25562556
<excludes>
2557-
<exclude>log4j.properties</exclude>
2557+
<exclude>log4j2.properties</exclude>
25582558
</excludes>
25592559
</configuration>
25602560
</execution>

0 commit comments

Comments
 (0)