Skip to content

Commit 50a0f0a

Browse files
Fixed readme comments based on legal review
1 parent a49b224 commit 50a0f0a

File tree

10 files changed

+189
-108
lines changed

10 files changed

+189
-108
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,5 @@ All notable changes to this project will be documented in this file.
44

55
2.0.0
66
---
7-
* Merge of TIBCO BusinessWorks 5.x and TIBCO BusinessWorks 6.x/TIBCO BusinessWorks Container Edition 2.x plugin in a single component
7+
* Merge of TIBCO BusinessWorks 5.x and TIBCO BusinessWorks 6.x/TIBCO BusinessWorks Container Edition 2.x plugin in a single component
88
* First open-source version

README.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
# Extension for SonarQube for use with TIBCO BusinessWorks
1+
# Extension for SonarQube for use with TIBCO BusinessWorks
22

33
## Introduction
44

5-
This is a quality-enforcement component for TIBCO ActiveMatrix BusinessWorks 5.x, TIBCO ActiveMatrix BusinessWorks BW6.x and TIBCO BusinessWorks Container Edition 2.x applications. The component is able to understand the details of your TIBCO BW application and then applies "rules" that detect various conditions that are either required for the application or are blocked. In this way the plugin is able to enforce a "quality" policy for TIBCO BW applications within an organization.
5+
This is a quality-enforcement component for TIBCO ActiveMatrix BusinessWorks 5.x, TIBCO ActiveMatrix BusinessWorks BW6.x and TIBCO BusinessWorks Container Edition 2.x applications. The component is able to understand the details of your TIBCO BW application and then applies "rules" that detect various conditions that are either required for the application or are blocked. In this way the plugin is able to enforce a "quality" policy for TIBCO BW applications within an organization.
66

77
Each detected issue may then be tracked individually and quality gates assigned so that code that does not meet a specific quality level cannot be released:
88

@@ -12,11 +12,11 @@ Each detected issue may then be tracked individually and quality gates assigned
1212
In either event the component will usually be executed as part of a CICD build pipeline. Typically this step will be executed before attempting to compile the application and then a "gate" will be defined to only allow build and deployment to progress if the code is of adequate quality.
1313

1414
## Supported Rules
15-
The component is intended to be extensible in that any of the currently defined rules may be used, or ommited as required for a given system. Additional rules may also be added as required although this will typically require Java development.
15+
The component is intended to be extensible in that any of the currently defined rules may be used, or omitted as required for a given system. Additional rules may also be added as required although this will typically require Java development.
1616
The currently supported rules and metrics for this version of the plugin are described
1717

18-
* TIBCO BusinessWorks 5.x Rules [here](docs/rules/bw5/RULES.md)
19-
* TIBCO BusinessWorks 6.x / TIBCO BusinessWorks Container Edition Rules [here](docs/rules/bw6/RULES.md)
18+
* TIBCO BusinessWorks 5.x Rules [here](docs/rules/bw5/RULES.md)
19+
* TIBCO BusinessWorks 6.x / TIBCO BusinessWorks Container Edition Rules [here](docs/rules/bw6/RULES.md)
2020

2121
## Overriding Rules
2222
Although typically an administrator will define which rules should be used for analysis, it is sometimes useful to allow developers to skip particular rules in a specific case if that would lead to a false alarm. In this case rules may be overridden.
@@ -30,4 +30,4 @@ Installation and configuration details are described [here](docs/INSTALLATION.md
3030

3131

3232
## Software Licenses and Third Party Usage
33-
This software is provided subject to the terms of the following licenses and uses third party libraries describes [here](docs/third-party-licenses/third-party-report.html)
33+
This software is provided under the terms of the Apache 2.0 license and incorporates third-party libraries, as detailed [here](docs/third-party-licenses/third-party-report.html).

docs/rules/bw6/BWVersionCheck.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
## What condition does this detect?
44

5-
Check if this BusinessWorks Module matches recommended version which has better performance and less vulnerabilities
5+
Check if this BusinessWorks Module matches recommended version which has better performance and less vulnerabilities
66

77
This is an ***Application*** rule - the rule will test for some condition within the application
88

@@ -12,7 +12,7 @@ Software currency is an important topic. As time goes the existing libraries bei
1212

1313
## How to fix it?
1414

15-
Upgrade the TIBCO BusinessWorks version to the most actual to keep the software currency
15+
Upgrade the TIBCO BusinessWorks version to the most actual to keep the software currency
1616

1717
## How do I use this rule?
1818

docs/rules/bw6/DeadlockDetection.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ This is a ***Process*** rule - the rule will test each process of the applicatio
1010

1111
In computing programing Deadlock is a situation where a set of processes are blocked because each process is holding a resource and waiting for another resource acquired by some other process.
1212

13-
In terms of BusinessWorks, this can happen when we have parallel flows and each of them depends on the other. This is something easy to detect when the dependency is direct but sometimes with the definition of many subprocess this dependency can be hidden, so we should be aware that there dependency is no there even if the relation is not so clear. Also relevant to this topic is the loop-infinite deadlock. As part of dependency situation you can have a process that can be calling it itself again in some special circunstances and generate this infinity loop that not also create a failure scenario but also a waste of your computing resources. </thead>
13+
In terms of BusinessWorks, this can happen when we have parallel flows and each of them depends on the other. This is something easy to detect when the dependency is direct but sometimes with the definition of many subprocess this dependency can be hidden, so we should be aware that there dependency is no there even if the relation is not so clear. Also relevant to this topic is the loop-infinite deadlock. As part of dependency situation you can have a process that can be calling it itself again in some special circunstances and generate this infinity loop that not also create a failure scenario but also a waste of your computing resources. </thead>
1414

1515
## How to fix it?
1616

docs/rules/bw6/IsMavenProject.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
## What condition does this detect?
44

5-
Check is this BusinessWorks Module is a Maven Project
5+
Check is this BusinessWorks Module is a Maven Project
66

77
This is an ***Application*** rule - the rule will test for some condition within the application
88

@@ -12,7 +12,7 @@ The usage of Maven nature for the project it allows an easy integration with thi
1212

1313
## How to fix it?
1414

15-
Set the Maven Nature for each project. To do that, you need to select the TIBCO BusinessWorks Application and in the context menu click on the Generate POM for Application. If that options is not present installation of the TIBCO Maven Plugin is required. This plugin can be obtained from the following link: https://github.com/TIBCOSoftware/bw6-plugin-maven
15+
Set the Maven Nature for each project. To do that, you need to select the TIBCO BusinessWorks Application and in the context menu click on the Generate POM for Application. If that options is not present installation of the TIBCO Maven Plugin is required. This plugin can be obtained from the following link: https://github.com/TIBCOSoftware/bw6-plugin-maven
1616

1717
## How do I use this rule?
1818

docs/rules/bw6/NumberOfPropertiesSameGroup.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ This is an ***Application*** rule - the rule will test for some condition within
88

99
## Why is this condition important?
1010

11-
Readability and maintenance is a characteristic that not only applies to the design of the process itself but also to all the components that are part of the development. And that includes the management of the properties. BusinessWorks has the option to define different groups to be able to group and categorize the different properties and if we managed those properties well is more easy to understand the purpose of each of those and at the end contribute to increase the readability of the whole process
11+
Readability and maintenance is a characteristic that not only applies to the design of the process itself but also to all the components that are part of the development. And that includes the management of the properties. BusinessWorks has the option to define different groups to be able to group and categorize the different properties and if we managed those properties well is more easy to understand the purpose of each of those and at the end contribute to increase the readability of the whole process
1212

1313
## How to fix it?
1414

docs/rules/bw6/ProcessWithoutTest.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ This is a ***Process*** rule - the rule will test each process of the applicatio
88

99
## Why is this condition important?
1010

11-
Unit Testing is a critical part of any development software. We should leverage of the out of the box unit testing capabilities TIBCO BusinessWorks has to make sure our developments are working and also to ease the process to any evolution of the process without breaking the old behavior or add unexpected bugs
11+
Unit Testing is a critical part of any development software. We should leverage of the out of the box unit testing capabilities TIBCO BusinessWorks has to make sure our developments are working and also to ease the process to any evolution of the process without breaking the old behavior or add unexpected bugs
1212

1313
## How to fix it?
1414

docs/rules/bw6/RULES.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ This version of the plugin provides ***62 quality rules*** and [***0 metrics***]
55
| Name | Type | Has Parameters | Initial State | Description |
66
| ---- | ---- | -------------- | -------------- | ----------- |
77
| [`AtLeastOneStarter`](AtLeastOneStarter.md) | Project | No | Enabled | Check that an application module should have one starter additional to the Activator process |
8-
| [`BWVersionCheck`](BWVersionCheck.md) | Project | No | Enabled | Check if this BusinessWorks Module matches recommended version which has better performance and less vulnerabilities |
8+
| [`BWVersionCheck`](BWVersionCheck.md) | Project | No | Enabled | Check if this BusinessWorks Module matches recommended version which has better performance and less vulnerabilities |
99
| [`BindingShouldHavePolicyAssociated`](BindingShouldHavePolicyAssociated.md) | Project | No | Enabled | To ensure that the communications are authentified all input connections should check that the binding has a policy associated |
1010
| [`BindingShouldNotHaveHTTPBasicPolicyAssociated`](BindingShouldNotHaveHTTPBasicPolicyAssociated.md) | Project | No | Enabled | To ensure that the communications are authentified all input connections should check that the binding has a policy associated that is secure |
1111
| [`BwSharedResourceUsingModuleProperty`](BwSharedResourceUsingModuleProperty.md) | Resource | No | Enabled | Parameter Resource using Module Property |
@@ -24,7 +24,7 @@ This version of the plugin provides ***62 quality rules*** and [***0 metrics***]
2424
| [`HttpClientMustBeUsedinHTTPBinding`](HttpClientMustBeUsedinHTTPBinding.md) | Process | No | Enabled | HTTP Binding should have an HTTP Client Resource |
2525
| [`HttpClientSSLShouldHaveConfidentiality`](HttpClientSSLShouldHaveConfidentiality.md) | Resource | No | Enabled | HTTP Client using 443 port should have set confidentiality settings |
2626
| [`HttpConnectorShouldHaveConfidentiality`](HttpConnectorShouldHaveConfidentiality.md) | Resource | No | Enabled | HTTP Connector should have set confidentiality settings |
27-
| [`IsMavenProject`](IsMavenProject.md) | Project | No | Enabled | Check is this BusinessWorks Module is a Maven Project |
27+
| [`IsMavenProject`](IsMavenProject.md) | Project | No | Enabled | Check is this BusinessWorks Module is a Maven Project |
2828
| [`JDBCHardCoded`](JDBCHardCoded.md) | Process | No | Enabled | This rule checks JDBC activities for hardcoded values for fields Timeout and MaxRows. Use Process property or Module property. |
2929
| [`JDBCTransactionParallelFlow`](JDBCTransactionParallelFlow.md) | Process | No | Enabled | This rule checks if there is no parallel flows with JDBC activities inside a Transaction Group |
3030
| [`JDBCWildcards`](JDBCWildcards.md) | Process | No | Enabled | This rule checks whether JDBC activities are using wildcards in the query. As a good coding practice, never use wildcards in JDBC queries. |

docs/rules/bw6/ThreadpoolUsageInJDBCActivities.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ This is a ***Process*** rule - the rule will test each process of the applicatio
88

99
## Why is this condition important?
1010

11-
JDBC activities in TIBCO BusinessWorks are asynchronous ones so that means that it uses an internal thread pool to manage the execution of those activities. This internal pool is not limited and can be increased for so many reasons leading to unexpected memory increase and also performance issues. To avoid that we should set up as part of the JDBC activity configuration a Shared Resource Instance for a Threadpool Resource so we can managed ourlves the amount of threads to be used for those activities.
11+
JDBC activities in TIBCO BusinessWorks are asynchronous ones so that means that it uses an internal thread pool to manage the execution of those activities. This internal pool is not limited and can be increased for so many reasons leading to unexpected memory increase and also performance issues. To avoid that we should set up as part of the JDBC activity configuration a Shared Resource Instance for a Threadpool Resource so we can managed ourlves the amount of threads to be used for those activities.
1212

1313
## How to fix it?
1414

0 commit comments

Comments
 (0)