Skip to content

Backward is missing in the training_step method of the GradCacheLateProcessTrainer #181

@Kalik-Kun

Description

@Kalik-Kun

Hello, I was working with your code and noticed that if GradCacheLateProcessTrainer is used without ddp, then it simply does not do backward in the training_step method.

_distributed = dist.is_initialized() and dist.get_world_size() > 1
if _distributed:
gc_queries, gc_targets = {'qry': queries}, {'tgt': targets}
self.gc.models = [model, model]
loss = self.gc(gc_queries, gc_targets, no_sync_except_last=True)
else:
loss = model(queries, targets)

return loss / self._dist_loss_scale_factor

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions