-
-
Notifications
You must be signed in to change notification settings - Fork 293
feat(starr-french): add Audio Description (AD) CF #2569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
NiceTSY
wants to merge
3
commits into
master
Choose a base branch
from
feat/starr-french-add-audio-description-cf
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "trash_id": "127bdbadcf3e4463a8c707759fbaad75", | ||
| "trash_regex": "https://regex101.com/r/GCIcFI", | ||
| "name": "WiTH.AD", | ||
| "includeCustomFormatWhenRenaming": true, | ||
| "specifications": [ | ||
| { | ||
| "name": "Audio Description", | ||
| "implementation": "ReleaseTitleSpecification", | ||
| "negate": false, | ||
| "required": true, | ||
| "fields": { | ||
| "value": "\\b((FRENCH|MULTi|WiTH)[ .-]AD)\\b" | ||
| } | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "trash_id": "44ccbcbc74506f208973e1463b11705f", | ||
| "trash_regex": "https://regex101.com/r/GCIcFI", | ||
| "name": "WiTH.AD", | ||
| "includeCustomFormatWhenRenaming": true, | ||
| "specifications": [ | ||
| { | ||
| "name": "Audio Description", | ||
| "implementation": "ReleaseTitleSpecification", | ||
| "negate": false, | ||
| "required": true, | ||
| "fields": { | ||
| "value": "\\b((FRENCH|MULTi|WiTH)[ .-]AD)\\b" | ||
| } | ||
| } | ||
| ] | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| <!-- markdownlint-disable MD041--> | ||
| **With Audio Description**<br> | ||
|
|
||
| [From Wikipedia, the free encyclopedia](<https://en.wikipedia.org/wiki/Audio_description>){:target="\_blank" rel="noopener noreferrer"} | ||
|
|
||
| Audio description (AD), also referred to as a video description, described video, or visual description, is a form of narration used to provide information surrounding key visual elements in a media work (such as a film or television program, or theatrical performance) for the benefit of blind and visually impaired consumers. | ||
| <!-- markdownlint-enable MD041--> |
12 changes: 12 additions & 0 deletions
12
includes/french-guide/radarr-french-audio-description-en.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| <!-- markdownlint-disable MD041--> | ||
| ??? abstract "Audio Description - [Click to show/hide]" | ||
|
|
||
| Some releases are now available with Audio Description, which is a way for visually impaired people to enjoy their media. | ||
| Those are flagged `WiTH.AD` or just `AD`, and not be confused with advertisements as they are not. | ||
|
|
||
| If you want to prefer those for any reason, please add the following CF with a score of `101`. You can still use it for information if you decide to not score it. | ||
|
|
||
| | Custom Format | Trash ID | | ||
| |-----------------------------------------------------------------------------------------------|-------------------------------------------| | ||
| | [{{ radarr['cf']['with-ad']['name'] }}](/Radarr/Radarr-collection-of-custom-formats/#with-ad) | {{ radarr['cf']['with-ad']['trash_id'] }} | | ||
| <!-- markdownlint-enable MD041--> |
12 changes: 12 additions & 0 deletions
12
includes/french-guide/radarr-french-audio-description-fr.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| <!-- markdownlint-disable MD041--> | ||
| ??? abstract "Audio Description - [Click to show/hide]" | ||
|
|
||
| Certaines releases sont maintenant disponibles avec un canal d'Audio Description, ceci afin de rendre un média accessible aux personnes aveugles ou malvoyantes. | ||
| Celles-ci sont marquées avec `WiTH.AD` ou `AD`, celles-ci ne doivent pas être confondues avec un média possédant des pubs (advertisements ou ads en anglais). | ||
|
|
||
| Si vous souhaitez préférer ce type de releases, merci d'ajouter le CF suivant avec un score de `101`. Vous pouvez tout aussi l'utiliser mais à titre informatif sans le scorer. | ||
|
|
||
| | Custom Format | Trash ID | | ||
| |-----------------------------------------------------------------------------------------------|-------------------------------------------| | ||
| | [{{ radarr['cf']['with-ad']['name'] }}](/Radarr/Radarr-collection-of-custom-formats/#with-ad) | {{ radarr['cf']['with-ad']['trash_id'] }} | | ||
| <!-- markdownlint-enable MD041--> |
12 changes: 12 additions & 0 deletions
12
includes/french-guide/sonarr-french-audio-description-en.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| <!-- markdownlint-disable MD041--> | ||
| ??? abstract "Audio Description - [Click to show/hide]" | ||
|
|
||
| Some releases are now available with Audio Description, which is a way for visually impaired people to enjoy their media. | ||
| Those are flagged `WiTH.AD` or just `AD`, and not be confused with advertisements as they are not. | ||
|
|
||
| If you want to prefer those for any reason, please add the following CF with a score of `101`. You can still use it for information if you decide to not score it. | ||
|
|
||
| | Custom Format | Trash ID | | ||
| |-----------------------------------------------------------------------------------------------|-------------------------------------------| | ||
| | [{{ sonarr['cf']['with-ad']['name'] }}](/sonarr/sonarr-collection-of-custom-formats/#with-ad) | {{ sonarr['cf']['with-ad']['trash_id'] }} | | ||
| <!-- markdownlint-enable MD041--> |
12 changes: 12 additions & 0 deletions
12
includes/french-guide/sonarr-french-audio-description-fr.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| <!-- markdownlint-disable MD041--> | ||
| ??? abstract "Audio Description - [Click to show/hide]" | ||
|
|
||
| Certaines releases sont maintenant disponibles avec un canal d'Audio Description, ceci afin de rendre un média accessible aux personnes aveugles ou malvoyantes. | ||
| Celles-ci sont marquées avec `WiTH.AD` ou `AD`, celles-ci ne doivent pas être confondues avec un média possédant des pubs (advertisements ou ads en anglais). | ||
|
|
||
| Si vous souhaitez préférer ce type de releases, merci d'ajouter le CF suivant avec un score de `101`. Vous pouvez tout aussi l'utiliser mais à titre informatif sans le scorer. | ||
|
|
||
| | Custom Format | Trash ID | | ||
| |-----------------------------------------------------------------------------------------------|-------------------------------------------| | ||
| | [{{ sonarr['cf']['with-ad']['name'] }}](/sonarr/sonarr-collection-of-custom-formats/#with-ad) | {{ sonarr['cf']['with-ad']['trash_id'] }} | | ||
| <!-- markdownlint-enable MD041--> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It’s just missing the ignore-case flag in the trash_regex. That's not very importante ahah (
MULTican also beMULTI)