refactor: define parameter types and change name of a variable

Author: nadjajovancevic

grader_service/handlers/config.py

@@ -1,23 +1,28 @@
+import traitlets.config
+
+from grader_service.autograding.kube.kube_grader import KubeAutogradeExecutor
+from grader_service.autograding.local_grader import LocalAutogradeExecutor
 from grader_service.handlers.base_handler import GraderBaseHandler, authorize
 from grader_service.orm.takepart import Scope
 from grader_service.registry import VersionSpecifier, register_handler
 
 
-def _get_effective_executor_value(app_cfg, executor_class, trait_name):
+def _get_effective_executor_value(
+    app_cfg: traitlets.config.Config,
+    executor_class: type[LocalAutogradeExecutor] | type[KubeAutogradeExecutor],
+    trait_name,
+):
     """
     Return the configured value for trait_name if present in app_cfg,
     otherwise return the class default pulled from the trait metadata.
     """
-    # app_cfg is a traitlets.config.Config object (mapping-like)
-    # executor_class is the class (LocalAutogradeExecutor or similar)
 
-    # 1) look up the per-class node as a mapping (not attribute access)
-    user_node = app_cfg.get(executor_class.__name__, None)
+    # 1) retrieve the provided class field from the config
+    executor_class_field = app_cfg.get(executor_class.__name__, None)
 
-    # user_node may be None, or a Config object / dict-like. Use mapping access.
-    if user_node is not None and trait_name in user_node:
-        # Use .get to return the exact user-supplied value (won't be a lazy object)
-        return user_node.get(trait_name)
+    # executor_class_field may be None, or a Config object / dict-like. Use mapping access.
+    if executor_class_field is not None and trait_name in executor_class_field:
+        return executor_class_field.get(trait_name)
 
     # 2) fallback to the trait's default from the class metadata
     return executor_class.class_traits()[trait_name].default()