Fix/python files filtering (#318)

* fix: explicitly check if file is a jupyter notebook instead of using glob pattern

* test: rewrote test to check the inclusion of python files

* chore: rewrite an outdated comment

Author: nadjajovancevic

grader_service/convert/converters/base.py

@@ -264,6 +264,10 @@ def matches_allowed_patterns(file_path):
             """
             Check if a file matches any of the allowed glob patterns.
             """
+            # Note: ignoring notebooks is needed to not overwrite converted notebooks
+            # with the original ones as currently the copying process is done after the conversion
+            if file_path.endswith(".ipynb"):
+                return False
             return any(fnmatch.fnmatch(file_path, pattern) for pattern in files_patterns)
 
         def is_ignored(file_path):

grader_service/tests/convert/converters/test_generate_assignment.py

@@ -43,23 +43,23 @@ def test_generate_assignment_no_copy_with_files(tmp_path):
 
 def test_generate_assignment_copy_with_files(tmp_path):
     input_dir, output_dir = _create_input_output_dirs(tmp_path, ["simple.ipynb"])
-    test_file = input_dir / "test.txt"
+    test_file = input_dir / "test.py"
     test_file.touch()
     assert test_file.exists()
 
     GenerateAssignment(
         input_dir=str(input_dir),
         output_dir=str(output_dir),
         file_pattern="*.ipynb",
-        assignment_settings=AssignmentSettings(allowed_files=["*[!.ipynb]"]),
+        assignment_settings=AssignmentSettings(allowed_files=["*"]),
         config=None,
     ).start()
 
     assert (output_dir / "simple.ipynb").exists()
     # Ensure the notebook was converted
     assert "BEGIN SOLUTION" not in (output_dir / "simple.ipynb").read_text()
     assert (output_dir / "gradebook.json").exists()
-    assert (output_dir / "test.txt").exists()
+    assert (output_dir / "test.py").exists()
 
 
 def test_generate_assignment_copy_with_dirs(tmp_path):