tests: Add tests for the GenerateFeedback converter

Author: natkam

grader_service/tests/convert/converters/__init__.py

@@ -1,9 +1,12 @@
 import shutil
 from pathlib import Path
 from typing import Any, Dict
+from unittest.mock import patch
+
+from nbclient import NotebookClient
 
 from grader_service.api.models.assignment_settings import AssignmentSettings
-from grader_service.convert.converters import GenerateAssignment
+from grader_service.convert.converters import Autograde, GenerateAssignment
 
 tests_dir = Path(__file__).parent.parent
 
@@ -21,7 +24,7 @@ def _create_input_output_dirs(p: Path, input_notebooks=None):
     return input_dir, output_dir
 
 
-def _generate_test_assignment(
+def _generate_test_submission(
     input_dir: str,
     output_dir: str,
     file_pattern: str = "*.ipynb",
@@ -37,3 +40,22 @@ def _generate_test_assignment(
         assignment_settings=AssignmentSettings(**assignment_settings_kwargs),
         config=None,
     ).start()
+
+
+def _autograde_test_submission(
+    input_dir: str,
+    output_dir: str,
+    file_pattern: str = "*.ipynb",
+    assignment_settings_kwargs: Dict[str, Any] = None,
+):
+    if assignment_settings_kwargs is None:
+        assignment_settings_kwargs = {}
+
+    with patch.object(NotebookClient, "kernel_name", "python3"):
+        Autograde(
+            input_dir=str(input_dir),
+            output_dir=str(output_dir),
+            file_pattern=file_pattern,
+            config=None,
+            assignment_settings=AssignmentSettings(**assignment_settings_kwargs),
+        ).start()

grader_service/tests/convert/converters/test_autograde.py

@@ -7,14 +7,14 @@
 from grader_service.convert.converters import Autograde
 from grader_service.tests.convert.converters import (
     _create_input_output_dirs,
-    _generate_test_assignment,
+    _generate_test_submission,
 )
 
 
 def test_autograde(tmp_path):
     input_dir, output_dir = _create_input_output_dirs(tmp_path, ["simple.ipynb"])
 
-    _generate_test_assignment(input_dir, output_dir)
+    _generate_test_submission(input_dir, output_dir)
 
     assert (output_dir / "simple.ipynb").exists()
     assert (output_dir / "gradebook.json").exists()
@@ -43,7 +43,7 @@ def test_autograde(tmp_path):
 def test_autograde_copy_with_all_files(tmp_path):
     input_dir, output_dir = _create_input_output_dirs(tmp_path, ["simple.ipynb"])
 
-    _generate_test_assignment(
+    _generate_test_submission(
         input_dir, output_dir, assignment_settings_kwargs={"allowed_files": ["*"]}
     )
 
@@ -79,7 +79,7 @@ def test_autograde_copy_with_dirs(tmp_path):
     test_file = dir_3 / "test.txt"
     test_file.touch()
 
-    _generate_test_assignment(
+    _generate_test_submission(
         input_dir, output_dir, assignment_settings_kwargs={"allowed_files": ["*"]}
     )
 
@@ -113,7 +113,7 @@ def test_autograde_with_student_notebooks_copied_over(tmp_path):
     by the student should also be copied over."""
     input_dir, output_dir = _create_input_output_dirs(tmp_path, ["simple.ipynb"])
 
-    _generate_test_assignment(input_dir, output_dir)
+    _generate_test_submission(input_dir, output_dir)
 
     student_nb = output_dir / "student.ipynb"
     student_nb.touch()