Replace preview_edit links with GeoJSON fenced blocks in coordinate proposed edits (#2762)

* Initial plan

* feat: replace preview_edit links with GeoJSON fenced blocks for coordinate edits

Co-authored-by: CommanderStorm <26258709+CommanderStorm@users.noreply.github.com>

* Update server/src/routes/feedback/proposed_edits/description.rs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* fix: update test_apply_set_as_blocks to match indented block output

Co-authored-by: CommanderStorm <26258709+CommanderStorm@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: CommanderStorm <26258709+CommanderStorm@users.noreply.github.com>
Co-authored-by: Frank Elsinga <frank@elsinga.de>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Author: 3 people

server/src/routes/feedback/proposed_edits/coordinate.rs

@@ -68,11 +68,22 @@ impl AppliableEdit for Coordinate {
         // Replace original file with temp file
         std::fs::rename(&temp_file, &csv_file).unwrap();
 
-        format!(
-            "https://nav.tum.de/api/preview_edit/{key}?to_lat={lat}&to_lon={lon}",
-            lat = self.lat,
-            lon = self.lon
-        )
+        let geojson = serde_json::json!({
+            "type": "Feature",
+            "geometry": {
+                "type": "Point",
+                // GeoJSON uses [longitude, latitude] ordering per RFC 7946
+                "coordinates": [self.lon, self.lat]
+            },
+            "properties": {
+                "kind": "coordinate-change",
+                "id": key,
+                "to_lat": self.lat,
+                "to_lon": self.lon
+            }
+        });
+        let pretty = serde_json::to_string_pretty(&geojson).unwrap_or_else(|_| geojson.to_string());
+        format!("```geojson\n{pretty}\n```")
     }
 }
 
@@ -233,4 +244,43 @@ mod tests {
         let expected = "id,lat,lon\n0,0,0\n";
         assert_eq!(fs::read_to_string(&csv_file).unwrap(), expected);
     }
+
+    #[test]
+    fn test_apply_returns_geojson_block() {
+        let coord = Coordinate {
+            lat: 48.262,
+            lon: 11.668,
+        };
+        let (dir, _csv_file) = setup();
+        let result = coord.apply("mi", dir.path(), "branch");
+
+        // The result must start and end with the geojson fenced block markers.
+        assert!(
+            result.starts_with("```geojson\n"),
+            "expected fenced geojson block, got: {result}"
+        );
+        assert!(
+            result.ends_with("\n```"),
+            "expected closing fence, got: {result}"
+        );
+
+        // Strip the fences and parse as JSON.
+        let json_str = result
+            .strip_prefix("```geojson\n")
+            .unwrap()
+            .strip_suffix("\n```")
+            .unwrap();
+        let value: serde_json::Value = serde_json::from_str(json_str)
+            .expect("apply() must return valid JSON inside the fenced block");
+
+        assert_eq!(value["type"], "Feature");
+        assert_eq!(value["geometry"]["type"], "Point");
+        // GeoJSON coordinate order is [longitude, latitude].
+        assert_eq!(value["geometry"]["coordinates"][0], 11.668);
+        assert_eq!(value["geometry"]["coordinates"][1], 48.262);
+        assert_eq!(value["properties"]["kind"], "coordinate-change");
+        assert_eq!(value["properties"]["id"], "mi");
+        assert_eq!(value["properties"]["to_lat"], 48.262);
+        assert_eq!(value["properties"]["to_lon"], 11.668);
+    }
 }

server/src/routes/feedback/proposed_edits/description.rs

@@ -40,6 +40,36 @@ impl Description {
             }
         }
     }
+
+    pub fn apply_set_as_blocks<T: AppliableEdit>(
+        &mut self,
+        category_name: &'static str,
+        set: HashMap<String, T>,
+        base_dir: &Path,
+        branch: &str,
+    ) {
+        if !set.is_empty() {
+            let edits = if set.len() == 1 { "edit" } else { "edits" };
+            if self.title.is_empty() {
+                self.title = format!("{amount} {category_name} {edits}", amount = set.len());
+            } else {
+                self.title += &format!(" and {amount} {category_name} {edits}", amount = set.len());
+            }
+
+            self.body += &format!("\nThe following {category_name} edits were made:\n");
+
+            for (key, value) in set {
+                let result = value.apply(&key, base_dir, branch);
+                let indented_result = result
+                    .lines()
+                    .map(|line| format!("    {line}"))
+                    .collect::<Vec<_>>()
+                    .join("\n");
+                self.body +=
+                    &format!("- [`{key}`](https://nav.tum.de/view/{key}):\n\n{indented_result}\n");
+            }
+        }
+    }
 }
 
 #[cfg(test)]
@@ -94,4 +124,37 @@ mod tests {
             "\nThe following category edits were made:\n| entry | edit |\n| ---   | ---  |\n| [`key`](https://nav.tum.de/view/key) | applied_value |\n"
         );
     }
+
+    #[test]
+    fn test_apply_set_as_blocks_empty() {
+        let mut description = Description::default();
+        let set: HashMap<String, TestEdit> = HashMap::default();
+        description.apply_set_as_blocks("coordinate", set, Path::new(""), "none");
+        assert_eq!(description.title, "");
+        assert_eq!(description.body, "");
+    }
+
+    #[test]
+    fn test_apply_set_as_blocks() {
+        let mut description = Description::default();
+        let set = HashMap::from([("key".to_string(), TestEdit)]);
+        description.apply_set_as_blocks("coordinate", set, Path::new(""), "none");
+        assert_eq!(description.title, "1 coordinate edit");
+        // A blank line after the list-item colon and 4-space indentation ensure the fenced block
+        // is rendered as content of the list item in GitHub-flavored Markdown.
+        assert_eq!(
+            description.body,
+            "\nThe following coordinate edits were made:\n- [`key`](https://nav.tum.de/view/key):\n\n    applied_value\n"
+        );
+    }
+
+    #[test]
+    fn test_apply_set_as_blocks_does_not_use_table() {
+        let mut description = Description::default();
+        let set = HashMap::from([("key".to_string(), TestEdit)]);
+        description.apply_set_as_blocks("coordinate", set, Path::new(""), "none");
+        // Block output must not contain table syntax.
+        assert!(!description.body.contains("| entry |"));
+        assert!(!description.body.contains("| ---"));
+    }
 }

server/src/routes/feedback/proposed_edits/tmp_repo.rs

@@ -54,7 +54,12 @@ impl TempRepo {
         description.add_context(&edits.additional_context);
 
         let coordinate_edits = edits.edits_for(|edit| edit.coordinate);
-        description.appply_set("coordinate", coordinate_edits, self.dir.path(), branch_name);
+        description.apply_set_as_blocks(
+            "coordinate",
+            coordinate_edits,
+            self.dir.path(),
+            branch_name,
+        );
         let image_edits = edits.edits_for(|edit| edit.image);
         description.appply_set("image", image_edits, self.dir.path(), branch_name);