Skip to content
This repository was archived by the owner on Mar 6, 2023. It is now read-only.

Commit e5b104e

Browse files
committed
LogListenAndServe now take Server not *http.Server
Only log FinishedHTTP if Shutdowner is a *http.Server
1 parent 6b5717c commit e5b104e

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

graceful.go

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ var (
100100
)
101101

102102
// LogListenAndServe logs using the logger and then calls ListenAndServe
103-
func LogListenAndServe(hs *http.Server, loggers ...Logger) {
103+
func LogListenAndServe(s Server, loggers ...Logger) {
104104
if len(loggers) > 0 {
105105
if logger = loggers[0]; logger == nil {
106106
logger = log.New(ioutil.Discard, "", 0)
@@ -109,9 +109,11 @@ func LogListenAndServe(hs *http.Server, loggers ...Logger) {
109109
logger = log.New(os.Stdout, "", 0)
110110
}
111111

112-
logger.Printf(ListeningFormat, hs.Addr)
112+
if hs, ok := s.(*http.Server); ok {
113+
logger.Printf(ListeningFormat, hs.Addr)
114+
}
113115

114-
ListenAndServe(hs)
116+
ListenAndServe(s)
115117
}
116118

117119
// ListenAndServe starts the server in a goroutine and then calls Shutdown
@@ -154,9 +156,9 @@ func shutdown(s Shutdowner, logger Logger) {
154156
if err := s.Shutdown(ctx); err != nil {
155157
logger.Printf(ErrorFormat, err)
156158
} else {
157-
logger.Printf(FinishedHTTP)
158-
159159
if hs, ok := s.(*http.Server); ok {
160+
logger.Printf(FinishedHTTP)
161+
160162
if hss, ok := hs.Handler.(Shutdowner); ok {
161163
select {
162164
case <-ctx.Done():

0 commit comments

Comments
 (0)