Set input stream right after connection is made, so that even failed calls can properly clean up input streams

Author: Jeff Bornemann

src/main/groovy/com/twcable/grabbit/client/batch/steps/http/CreateHttpConnectionTasklet.groovy

@@ -66,14 +66,15 @@ class CreateHttpConnectionTasklet implements Tasklet {
 
         final Connection connection = createConnection(request, username, password)
 
+        ClientBatchJobContext.setInputStream(connection.inputStream)
+
         if(connection.status != SC_OK) {
             log.warn "Received a status of ${connection.status} when attempting to create a connection to ${jobParameters.get(ClientBatchJob.HOST)}. Bailing out. See debug log for more details."
             log.debug "Request to start a connection with ${jobParameters.get(ClientBatchJob.HOST)} resulted in: ${connection.networkResponse}."
             contribution.setExitStatus(ExitStatus.FAILED)
             return RepeatStatus.FINISHED
         }
 
-        ClientBatchJobContext.setInputStream(connection.inputStream)
         return RepeatStatus.FINISHED
     }
 

src/test/groovy/com/twcable/grabbit/client/batch/steps/http/CreateHttpConnectionTaskletSpec.groovy

@@ -81,14 +81,17 @@ class CreateHttpConnectionTaskletSpec extends Specification {
         final StepContribution stepContribution = Mock(StepContribution) {
             1 * setExitStatus(ExitStatus.FAILED)
         }
+        final InputStream inputStream = Mock(InputStream)
         final CreateHttpConnectionTasklet tasklet = Spy(CreateHttpConnectionTasklet) {
             createConnection(_, 'username', 'password') >> Mock(Connection) {
                 getStatus() >> SC_BAD_GATEWAY
+                getInputStream() >> inputStream
             }
         }
 
         then:
         tasklet.execute(stepContribution, chunkContext) == RepeatStatus.FINISHED
+        ClientBatchJobContext.inputStream != null
     }