File tree Expand file tree Collapse file tree 1 file changed +13
-0
lines changed
Documentation/HandlingAPatch Expand file tree Collapse file tree 1 file changed +13
-0
lines changed Original file line number Diff line number Diff line change @@ -313,6 +313,19 @@ Testing
313313* Is there a need to add **unit/functional testing ** for specific changes
314314* Are **regression tests ** for a bugfix needed?
315315
316+ .. _common-review-checks-acceptance :
317+
318+ Acceptance Tests
319+ ~~~~~~~~~~~~~~~~
320+
321+ * Does the proposed patch work functionally, does it implement what the commit message
322+ offers?
323+ * Are acceptance tests for this needed (Playwright for new ones) and if they are implemented,
324+ do they cover all needed functionality?
325+ * If backend GUI functionality is involved, does the functionality work as both Admin as well
326+ as restricted users? Especially important if any "isAdmin" checks are involved, and how
327+ the functionality gracefully resolves as non-admin.
328+
316329.. _common-review-checks-formalities :
317330
318331Formalities
You can’t perform that action at this time.
0 commit comments