Skip to content

Commit 34302a8

Browse files
committed
[TASK] Add newline to properly parse headings
1 parent 0d3aac0 commit 34302a8

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

Documentation/HandlingAPatch/Tips.rst

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -283,6 +283,7 @@ For reviewing and giving feedback, here's a couple of things that are often addr
283283
use this list both for checking other people's patches, as well as your own.
284284

285285
.. _common-review-checks-general:
286+
286287
General checks
287288
~~~~~~~~~~~~~~
288289

@@ -305,13 +306,15 @@ General checks
305306
the patch, and were built with the right environment?
306307

307308
.. _common-review-checks-testing:
309+
308310
Testing
309311
~~~~~~~
310312

311313
* Is there a need to add **unit/functional testing** for specific changes
312314
* Are **regression tests** for a bugfix needed?
313315

314316
.. _common-review-checks-formalities:
317+
315318
Formalities
316319
~~~~~~~~~~~
317320

@@ -323,6 +326,7 @@ Formalities
323326
* When **new PHP files** are added, do they contain the TYPO3 License and a `declare strict_types` header?
324327

325328
.. _common-review-checks-php:
329+
326330
PHP specifics
327331
~~~~~~~~~~~~~
328332

@@ -331,6 +335,7 @@ PHP specifics
331335
* Is **Dependency Injection** used where applicable?
332336

333337
.. _common-review-checks-docs:
338+
334339
Documentation
335340
~~~~~~~~~~~~~
336341

@@ -344,6 +349,7 @@ Documentation
344349
* Does your patch **deprecate** anything? If so, have you followed :ref:`deprecations`?
345350

346351
.. _common-review-checks-xlf:
352+
347353
Xliff / language files
348354
~~~~~~~~~~~~~~~~~~~~~~
349355

@@ -378,6 +384,7 @@ When changes are made to **Xliff files** (translations):
378384
of spelling/grammar, but **never change in meaning or arguments**.
379385

380386
.. _common-review-checks-missing:
387+
381388
More?
382389
~~~~~
383390

0 commit comments

Comments
 (0)