[TASK] Remove leftover reference to EMU::getFileFieldTCAConfig() (#5408)

* [TASK] Remove leftover reference to EMU::getFileFieldTCAConfig()

Releases: main, 13.4, 12.4

* [TASK] Remove leftover reference to EMU::getFileFieldTCAConfig()

Releases: main, 13.4, 12.4

* [TASK] Remove leftover reference to EMU::getFileFieldTCAConfig()

Releases: main, 13.4, 12.4

* [TASK] Remove leftover reference to EMU::getFileFieldTCAConfig()

Releases: main, 13.4, 12.4

Author: linawolf

Documentation/CodeSnippets/Config/Tutorials/Tea.php

@@ -38,13 +38,6 @@
         'sourceFile' => 'EXT:tea/ext_emconf.php',
         'targetFileName' => 'CodeSnippets/Tutorials/Tea/ExtEmconf.rst.txt',
     ],
-    [
-        'action' => 'createCodeSnippet',
-        'caption' => 'EXT:tea/ext_tables.sql',
-        'sourceFile' => 'EXT:tea/ext_tables.sql',
-        'targetFileName' => 'CodeSnippets/Tutorials/Tea/ExtTablesSql.rst.txt',
-        'language' => 'sql',
-    ],
     [
         'action' => 'createPhpArrayCodeSnippet',
         'caption' => 'EXT:tea/Configuration/TCA/tx_tea_domain_model_product_tea.php',
@@ -61,14 +54,6 @@
         'showLineNumbers' => true,
         'targetFileName' => 'CodeSnippets/Tutorials/Tea/Configuration/TCA/TeaColumnTitle.rst.txt',
     ],
-    [
-        'action' => 'createPhpArrayCodeSnippet',
-        'caption' => 'EXT:tea/Configuration/TCA/tx_tea_domain_model_product_tea.php',
-        'sourceFile' => 'EXT:tea/Configuration/TCA/tx_tea_domain_model_product_tea.php',
-        'fields' => ['columns/image'],
-        'showLineNumbers' => true,
-        'targetFileName' => 'CodeSnippets/Tutorials/Tea/Configuration/TCA/TeaColumnImage.rst.txt',
-    ],
     [
         'action' => 'createPhpArrayCodeSnippet',
         'caption' => 'EXT:tea/Configuration/TCA/tx_tea_domain_model_product_tea.php',

Documentation/CodeSnippets/Tutorials/Tea/Configuration/TCA/TeaColumnImage.rst.txt

@@ -10,21 +10,10 @@ Model: a bag of tea
 
 We keep the model basic: Each tea can have a title, a description, and an optional image.
 
-..  uml::
-
-    class Tea {
-        title
-        ==
-        description
-        ==
-        image
-    }
-
 The title and description are strings, the image is stored as a relation
 to the model class :php:`\TYPO3\CMS\Extbase\Domain\Model\FileReference`, provided
 by Extbase.
 
-
 ..  _extbase_tutorial_tea_model_database:
 
 The database model
@@ -76,8 +65,6 @@ keys on the first level:
     describe at least one type. Here we define the order in which
     the fields are displayed in the backend.
 
-
-
 ..  _extbase_tutorial_tea_model_ctrl:
 
 TCA :php:`ctrl` - Settings for the complete table
@@ -156,53 +143,16 @@ The other text fields are defined in a similar manner.
 
 ..  _extbase_tutorial_tea_model_columns_image:
 
-The :php:`image` field
-~~~~~~~~~~~~~~~~~~~~~~
-
-As the tea extension always supports two major TYPO3 versions it still uses
-the deprecated way of creating an image field in TCA. If your extension only
-has to support TYPO3 v12, you should use the field type :ref:`t3tca:columns-file`.
+The `image` field
+~~~~~~~~~~~~~~~~~
 
-The image field is a special case, as it is created by a call to the API function
-:php:`\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::getFileFieldTCAConfig()`.
-This method returns a preconfigured array, and saves you from writing a long and complicated configuration array.
+Field type :ref:`t3tca:columns-file` can be used to upload files. As the image
+should be an image, we limit the allowed file extensions to the `common-image-types`.
+See also :ref:`TCA type 'file', property 'allowed' <t3tca:confval-file-allowed>`.
 
-..  code-block:: php
+..  literalinclude:: _Model/_image_tca.php
     :caption: EXT:tea/Configuration/TCA/tx_tea_domain_model_tea.php
 
-    [
-        'columns' => [
-            'image' => [
-                'label' => 'LLL:EXT:tea/Resources/Private/Language/locallang_db.xlf:tx_tea_domain_model_tea.image',
-                'config' => \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::getFileFieldTCAConfig(
-                    'image',
-                    [
-                        'maxitems' => 1,
-                        'appearance' => [
-                            'collapseAll' => true,
-                            'useSortable' => false,
-                            'enabledControls' => [
-                                'hide' => false,
-                            ],
-                        ],
-                    ]
-                ),
-            ],
-        ],
-    ];
-
-..  tip::
-    Do not worry about performance caused by the API call, the TCA files are
-    cached in compiled form.
-
-The array generated by the method
-:php:`ExtensionManagementUtility::getFileFieldTCAConfig()` looks like this:
-
-..  include:: /CodeSnippets/Tutorials/Tea/Configuration/TCA/TeaColumnImage.rst.txt
-
-You are probably happy that this was generated for you and that you did not have to type it
-yourself.
-
 ..  _extbase_tutorial_tea_model_types:
 
 TCA :php:`types` - Configure the input form
@@ -219,11 +169,13 @@ backend input form, in the order they should be displayed.
     :ref:`TCA reference, showitem <t3tca:types-properties-showitem>` for
     details.
 
+..  _extbase_tutorial_tea_model-tca-result:
+
 Result - the complete TCA
 --------------------------
 
 Have a look at the complete file
-`EXT:tea/Configuration/TCA/tx_tea_domain_model_tea.php <https://github.com/TYPO3-Documentation/tea/blob/main/Configuration/TCA/tx_tea_domain_model_tea.php>`__.
+`EXT:tea/Configuration/TCA/tx_tea_domain_model_tea.php <https://github.com/TYPO3BestPractices/tea/blob/main/Configuration/TCA/tx_tea_domain_model_tea.php>`_.
 
 Now the edit form for tea records will look like this:
 
@@ -244,6 +196,8 @@ The list of teas in the module :guilabel:`Web -> List` looks like this:
     Up to this point we have only used TYPO3 Core features. You can create
     tables and backend forms exactly the same way without using Extbase.
 
+..  _extbase_tutorial_tea_model-entity:
+
 The Extbase model
 =================
 
@@ -284,11 +238,4 @@ The getter for the image also has to resolve the :ref:`lazy loading <extbase-ann
 ..  include:: /CodeSnippets/Tutorials/Tea/Classes/Domain/Model/TeaImage.rst.txt
 
 See the complete
-`class on Github: Tea <https://github.com/TYPO3-Documentation/tea/blob/main/Classes/Domain/Model/Tea.php>`__.
-
-Next steps
-==========
-
-.. TODO: Link this as soon as written
-
-*   The repository - Query for tea
+`class on Github: Tea <https://github.com/TYPO3BestPractices/tea/blob/main/Classes/Domain/Model/Tea.php>`_.

Documentation/ExtensionArchitecture/Tutorials/Tea/Model.rst

@@ -0,0 +1,20 @@
+<?php
+
+return [
+    // ...
+    'columns' => [
+        'image' => [
+            'label' => 'LLL:EXT:tea/Resources/Private/Language/locallang_db.xlf:tx_tea_domain_model_tea.image',
+            'type' => 'file',
+            'maxitems' => 1,
+            'appearance' => [
+                'collapseAll' => true,
+                'useSortable' => false,
+                'enabledControls' => [
+                    'hide' => false,
+                ],
+            ],
+            'allowed' => 'common-image-types',
+        ],
+    ],
+];