Skip to content

Commit 4553d76

Browse files
christophlehmanndkd-kaehm
authored andcommitted
[TASK] Do not ignore database exceptions
This removes a try catch block around a select query. When a database query is not okay for any reason, then i like to get the reason directly.
1 parent b0ddab0 commit 4553d76

File tree

1 file changed

+8
-12
lines changed

1 file changed

+8
-12
lines changed

Classes/Domain/Index/Queue/UpdateHandler/GarbageHandler.php

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -241,18 +241,14 @@ protected function isRelatedQueueRecordMarkedAsIndexed(string $table, array $rec
241241
public function getRecordWithFieldRelevantForGarbageCollection(string $table, int $uid): ?array
242242
{
243243
$garbageCollectionRelevantFields = $this->tcaService->getVisibilityAffectingFieldsByTable($table);
244-
try {
245-
$queryBuilder = $this->getQueryBuilderForTable($table);
246-
$queryBuilder->getRestrictions()->removeAll();
247-
$row = $queryBuilder
248-
->select(...GeneralUtility::trimExplode(',', $garbageCollectionRelevantFields, true))
249-
->from($table)
250-
->where($queryBuilder->expr()->eq('uid', $queryBuilder->createNamedParameter($uid, \Doctrine\DBAL\ParameterType::INTEGER)))
251-
->executeQuery()
252-
->fetchAssociative();
253-
} catch (Throwable) {
254-
$row = false;
255-
}
244+
$queryBuilder = $this->getQueryBuilderForTable($table);
245+
$queryBuilder->getRestrictions()->removeAll();
246+
$row = $queryBuilder
247+
->select(...GeneralUtility::trimExplode(',', $garbageCollectionRelevantFields, true))
248+
->from($table)
249+
->where($queryBuilder->expr()->eq('uid', $queryBuilder->createNamedParameter($uid, \Doctrine\DBAL\ParameterType::INTEGER)))
250+
->executeQuery()
251+
->fetchAssociative();
256252

257253
return is_array($row) ? $row : null;
258254
}

0 commit comments

Comments
 (0)