[FEATURE] implement ConfigurationApiService

Author: etobi

Classes/Command/ConfigurationApiCommandController.php

@@ -25,7 +25,6 @@
  ***************************************************************/
 
 use TYPO3\CMS\Extbase\Mvc\Controller\CommandController;
-use TYPO3\CMS\Extbase\Reflection\ObjectAccess;
 
 /**
  * Configuration API Command Controller
@@ -36,23 +35,27 @@
 class ConfigurationApiCommandController extends CommandController {
 
 	/**
-	 * listCommand
+	 * @var \Etobi\CoreAPI\Service\ConfigurationApiService
+	 * @inject
+	 */
+	protected $configurationApiService;
+
+	/**
+	 * List all configurations
 	 *
 	 * @return string
 	 */
 	public function listCommand() {
-		$typo3ConfVars = $GLOBALS['TYPO3_CONF_VARS'];
-		$this->outputLine(json_encode($typo3ConfVars));
+		$this->outputLine(json_encode($this->configurationApiService->getConfigurationArray()));
 	}
 
 	/**
-	 * showCommand
+	 * Get configuration value for given key
 	 *
-	 * @param string $param
+	 * @param string $key
 	 * @return string
 	 */
 	public function showCommand($key) {
-		$typo3ConfVars = ObjectAccess::getPropertyPath($GLOBALS['TYPO3_CONF_VARS'], $key);
-		$this->outputLine(json_encode($typo3ConfVars));
+		$this->outputLine(json_encode($this->configurationApiService->getValue($key)));
 	}
 }

Classes/Service/ConfigurationApiService.php

@@ -0,0 +1,43 @@
+<?php
+namespace Etobi\CoreAPI\Service;
+
+/**
+ * This file is part of the TYPO3 CMS project.
+ *
+ * It is free software; you can redistribute it and/or modify it under
+ * the terms of the GNU General Public License, either version 2
+ * of the License, or any later version.
+ *
+ * For the full copyright and license information, please read the
+ * LICENSE.txt file that was distributed with this source code.
+ *
+ * The TYPO3 project - inspiring people to share!
+ */
+use TYPO3\CMS\Core\Utility\GeneralUtility;
+use TYPO3\CMS\Extbase\Reflection\ObjectAccess;
+
+/**
+ * Site API service
+ *
+ * @author Tobias Liebig <[email protected]>
+ * @package Etobi\CoreAPI\Service\ConfigurationApiService
+ */
+class ConfigurationApiService {
+
+	/**
+	 * @param string $key
+	 * @return mixed
+	 */
+	public function getValue($key) {
+		return ObjectAccess::getPropertyPath($this->getConfigurationArray(), $key);
+	}
+
+	/**
+	 * Returns the configuration array
+	 *
+	 * @return array
+	 */
+	public function getConfigurationArray() {
+		return $GLOBALS['TYPO3_CONF_VARS'];
+	}
+}