Return valid exit codes

Resolves: #19

Author: Stefano Kowalke

Classes/Command/BackendApiCommandController.php

@@ -59,13 +59,13 @@ public function unlockCommand() {
 			unlink(PATH_typo3conf . 'LOCK_BACKEND');
 			if (@is_file((PATH_typo3conf . 'LOCK_BACKEND'))) {
 				$this->outputLine('ERROR: Could not remove lock file \'typo3conf/LOCK_BACKEND\'!');
-				$this->sendAndExit(1);
+				$this->quit(1);
 			} else {
 				$this->outputLine('Removed lock file \'typo3conf/LOCK_BACKEND\'');
 			}
 		} else {
 			$this->outputLine('No lock file \'typo3conf/LOCK_BACKEND\' was found, hence no lock could be removed.');
-			$this->sendAndExit(2);
+			$this->quit(1);
 		}
 	}
 }

Classes/Command/CacheApiCommandController.php

@@ -117,4 +117,4 @@ public function clearAllExceptPageCacheCommand() {
 		$clearedCaches = $this->cacheApiService->clearAllExceptPageCache();
 		$this->outputLine('Cleared caches: ' . implode(', ', $clearedCaches));
 	}
-}
+}

Classes/Command/DatabaseApiCommandController.php

@@ -70,7 +70,7 @@ public function databaseCompareCommand($actions = '', $dry = FALSE) {
 				$this->outputLine('DB has been compared');
 			} else {
 				$this->outputLine('DB could not be compared, Error(s): %s', array(LF . implode(LF, $result)));
-				$this->quit();
+				$this->quit(1);
 			}
 		}
 	}

Classes/Command/ExtensionApiCommandController.php

@@ -63,7 +63,7 @@ public function infoCommand($key) {
 			$data = $this->extensionApiService->getExtensionInformation($key);
 		} catch (Exception $e) {
 			$this->outputLine($e->getMessage());
-			$this->quit();
+			$this->quit(1);
 		}
 
 		$this->outputLine('');
@@ -121,7 +121,7 @@ public function listInstalledCommand($type = '') {
 		$type = ucfirst(strtolower($type));
 		if (!empty($type) && $type !== 'Local' && $type !== 'Global' && $type !== 'System') {
 			$this->outputLine('Only "Local", "System" and "Global" are supported as type (or nothing)');
-			$this->quit();
+			$this->quit(1);
 		}
 
 		$extensions = $this->extensionApiService->listExtensions($type);
@@ -166,7 +166,7 @@ public function installCommand($key) {
 			$this->extensionApiService->installExtension($key);
 		} catch (Exception $e) {
 			$this->outputLine($e->getMessage());
-			$this->quit();
+			$this->quit(1);
 		}
 		$this->outputLine(sprintf('Extension "%s" is now installed!', $key));
 	}
@@ -183,7 +183,7 @@ public function uninstallCommand($key) {
 			$this->extensionApiService->uninstallExtension($key);
 		} catch (Exception $e) {
 			$this->outputLine($e->getMessage());
-			$this->quit();
+			$this->quit(1);
 		}
 		$this->outputLine(sprintf('Extension "%s" is now uninstalled!', $key));
 	}
@@ -230,14 +230,15 @@ public function configureCommand($key, $configFile = '', $settings = '') {
 			}
 
 			if (empty($conf)) {
+				$this->response->setExitCode(1);
 				throw new InvalidArgumentException(sprintf('No configuration settings!', $key));
 			}
 
 			$this->extensionApiService->configureExtension($key, $conf);
 
 		} catch (Exception $e) {
 			$this->outputLine($e->getMessage());
-			$this->quit();
+			$this->quit(1);
 		}
 		$this->outputLine(sprintf('Extension "%s" has been configured!', $key));
 	}
@@ -259,7 +260,7 @@ public function fetchCommand($key, $version = '', $location = 'Local', $overwrit
 			$this->outputLine(sprintf('Extension "%s" version %s has been fetched from repository! Dependencies were not resolved.', $data['main']['extKey'], $data['main']['version']));
 		} catch (Exception $e) {
 			$this->outputLine($e->getMessage());
-			$this->quit();
+			$this->quit(1);
 		}
 	}
 
@@ -278,7 +279,7 @@ public function listMirrorsCommand() {
 			}
 		} catch (Exception $e) {
 			$this->outputLine($e->getMessage());
-			$this->quit();
+			$this->quit(1);
 		}
 	}
 
@@ -297,7 +298,7 @@ public function importCommand($file, $location = 'Local', $overwrite = FALSE) {
 			$this->outputLine(sprintf('Extension "%s" has been imported!', $data['extKey']));
 		} catch (Exception $e) {
 			$this->outputLine($e->getMessage());
-			$this->quit();
+			$this->quit(1);
 		}
 	}
 

Classes/Command/SiteApiCommandController.php

@@ -81,13 +81,14 @@ public function createSysNewsCommand($header, $text = '') {
 			$result = $this->siteApiService->createSysNews($header, $text);
 		} catch (\Exception $e) {
 			$this->outputLine($e->getMessage());
-			$this->quit();
+			$this->quit(1);
 		}
 
 		if ($result) {
 			$this->outputLine('News entry successfully created.');
 		} else {
 			$this->outputLine('News entry NOT created.');
+			$this->quit(1);
 		}
 	}
 }