Skip to content

Commit 3351439

Browse files
committed
[TASK] Remove obsolete prepareArguments() call
As suspected in the todo annotation, this call is obsolete: In the next line, `$this->parseArguments()` is called, which calls `ViewHelperResolver::getArgumentDefinitionsForViewHelper()` in its first line, which then calls (and returns the result of `prepareArguments()`.
1 parent 0b9f07e commit 3351439

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

src/Core/Parser/TemplateParser.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -294,8 +294,6 @@ protected function openingViewHelperTagHandler(ParsingState $state, string $name
294294
}
295295

296296
$viewHelper = $viewHelperResolver->createViewHelperInstance($namespaceIdentifier, $methodIdentifier);
297-
// @todo: Is this call needed?
298-
$viewHelper->prepareArguments();
299297
$viewHelperNode = $this->initializeViewHelperAndAddItToStack(
300298
$state,
301299
$namespaceIdentifier,

0 commit comments

Comments
 (0)