[BUGFIX] Adjust Symfony Validator tests for 7.4 compatibility

The number of arguments passed to error messages has been
raised in Symfony Validator 7.4 and thus no longer meets
the hard-coded structure in the test.

The tests are now adjusted to only test for the rendered
error message, making it independant from argument order
and count.

Resolves: #108356
Related: #106945
Releases: main
Change-Id: Id4e541715accc8f5571409b4ab6c6825bc26eb89
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/91927
Tested-by: Simon Schaufelberger <[email protected]>
Reviewed-by: Markus Klein <[email protected]>
Tested-by: Garvin Hicking <[email protected]>
Reviewed-by: Garvin Hicking <[email protected]>
Reviewed-by: Simon Schaufelberger <[email protected]>
Tested-by: Markus Klein <[email protected]>
Tested-by: core-ci <[email protected]>
Tested-by: Stefan Bürk <[email protected]>
Reviewed-by: Stefan Bürk <[email protected]>

Author: garvinhicking

typo3/sysext/extbase/Tests/Functional/Validation/ValidatorResolverTest.php

@@ -19,7 +19,6 @@
 
 use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\Attributes\Test;
-use TYPO3\CMS\Core\Imaging\IconFactory;
 use TYPO3\CMS\Extbase\Error\Error;
 use TYPO3\CMS\Extbase\Error\Result;
 use TYPO3\CMS\Extbase\Reflection\ReflectionService;
@@ -282,23 +281,14 @@ public function SymfonyValidatorsCanBeValidated(): void
 
         $expectation = new Result();
         $expectation->addError(new Error('Your foo must be at least %2$s characters long', 286244044, ['""', 1, 0]));
-        self::assertEquals(
-            $propertyValidator->validate(''),
-            $expectation,
-        );
+        $this->assertErrorObjectsAreSame([$expectation], [$propertyValidator->validate('')]);
 
         $expectation = new Result();
-        self::assertEquals(
-            $propertyValidator->validate('success'),
-            $expectation,
-        );
+        $this->assertErrorObjectsAreSame([$expectation], [$propertyValidator->validate('success')]);
 
         $expectation = new Result();
         $expectation->addError(new Error('Your foo cannot be longer than %2$s characters', 1497521431, ['"failure because too long"', 10, 24]));
-        self::assertEquals(
-            $propertyValidator->validate('failure because too long'),
-            $expectation,
-        );
+        $this->assertErrorObjectsAreSame([$expectation], [$propertyValidator->validate('failure because too long')]);
     }
 
     public static function SymfonyAndExtbaseValidatorsDataProvider(): \Generator
@@ -359,6 +349,27 @@ public function SymfonyValidatorsCanBeMixedWithExtbaseValidators(string $input,
         foreach ($fooPropertyValidators as $fooPropertyValidator) {
             $results[] = $fooPropertyValidator->validate($input);
         }
-        self::assertEquals($results, $expectedErrorResults);
+        $this->assertErrorObjectsAreSame($expectedErrorResults, $results);
+    }
+
+    private function assertErrorObjectsAreSame(array $expectedErrorResults, array $results): void
+    {
+        self::assertCount(count($expectedErrorResults), $results);
+        /** @var Result $expectedErrorResult */
+        foreach ($expectedErrorResults as $resultIndex => $expectedErrorResult) {
+            self::assertSame($expectedErrorResult->hasErrors(), $results[$resultIndex]->hasErrors());
+            if (!$expectedErrorResult->hasErrors()) {
+                continue;
+            }
+
+            $resultErrors = $results[$resultIndex]->getErrors();
+            $expectedErrors = $expectedErrorResult->getErrors();
+            self::assertCount(count($expectedErrors), $resultErrors);
+            foreach ($expectedErrors as $errorIndex => $error) {
+                $msgExpected = sprintf($error->getMessage(), ...$error->getArguments());
+                $msgActual = sprintf($resultErrors[$errorIndex]->getMessage(), ...$resultErrors[$errorIndex]->getArguments());
+                self::assertSame($msgExpected, $msgActual);
+            }
+        }
     }
 }